From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seungwon Jeon Subject: RE: [PATCH 1/2] mmc: core: fix permanent sleep of mmcqd during card removal Date: Thu, 31 Jan 2013 20:25:54 +0900 Message-ID: <002101cdffa5$bb8ab990$32a02cb0$%jun@samsung.com> References: <1356513966-24945-1-git-send-email-kdorfman@codeaurora.org> <001d01cdf88d$f4214270$dc63c750$%jun@samsung.com> <510A4FFF.4070100@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ks_c_5601-1987 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:42319 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016Ab3AaLZ4 (ORCPT ); Thu, 31 Jan 2013 06:25:56 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MHH0007BMF2H900@mailout2.samsung.com> for linux-mmc@vger.kernel.org; Thu, 31 Jan 2013 20:25:54 +0900 (KST) Received: from DOTGIHJUN01 ([12.23.118.161]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MHH00KIDMF63N30@mmp1.samsung.com> for linux-mmc@vger.kernel.org; Thu, 31 Jan 2013 20:25:54 +0900 (KST) In-reply-to: <510A4FFF.4070100@samsung.com> Content-language: ko Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: 'Jaehoon Chung' Cc: linux-mmc@vger.kernel.org, 'Chris Ball' , 'Konstantin Dorfman' , 'Subhash Jadavani' I hope that you find another patch. [PATCH 2/2] mmc: block: don't start new request when the card is removed I'd appreciate if you can review it. Thanks, Seungwon Jeon On Thursday, January 31, 2013, Jaehoon Chung wrote: > Great.. > > I also found this problem and sent the similar patch at mailing. > But i think this patch is more generic. > > Acked-by: Jaehoon Chung > > On 01/22/2013 07:48 PM, Seungwon Jeon wrote: > > This patch is derived from 'mmc: fix async request mechanism ...'. > > According as async transfer, a request is handled with twice mmc_start_req. > > When the card is removed, the request is actually not issued in the first > > mmc_start_req [__mmc_start_data_req]. And then mmc_wait_for_data_req_done > > will come in the next mmc_start_req. But there is no event for completions. > > wake_up_interruptible is needed in __mmc_start_data_req for the case of > > removed card. > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/mmc/core/core.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > > index 8b3a122..997b257 100644 > > --- a/drivers/mmc/core/core.c > > +++ b/drivers/mmc/core/core.c > > @@ -350,6 +350,7 @@ static int __mmc_start_data_req(struct mmc_host *host, struct mmc_request *mrq) > > mrq->host = host; > > if (mmc_card_removed(host->card)) { > > mrq->cmd->error = -ENOMEDIUM; > > + mmc_wait_data_done(mrq); > > return -ENOMEDIUM; > > } > > mmc_start_request(host, mrq); > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html