From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, INVALID_MSGID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72E3C07E96 for ; Thu, 8 Jul 2021 08:57:09 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D7EB761CCA for ; Thu, 8 Jul 2021 08:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7EB761CCA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9A1F4069C; Thu, 8 Jul 2021 10:57:07 +0200 (CEST) Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105]) by mails.dpdk.org (Postfix) with ESMTP id 77B0840687 for ; Thu, 8 Jul 2021 10:57:06 +0200 (CEST) X-QQ-mid: bizesmtp34t1625734619tu7vyzz3 Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Thu, 08 Jul 2021 16:56:58 +0800 (CST) X-QQ-SSF: 01400000000000D0E000000A0000000 X-QQ-FEAT: wZTf/GsjKWDiW81E2pRMo77z3QthGvmBZkeokIKaYVKU7RHg0Wpeg3DMeQ+tG fjL+5QA3AcGaPd1rqAFWkxjyzBHeGwkaKxHEjYe7r5iAA2gxH8cUBdhqEG0U9tzzMVbr0ln Oo0IapTxjkVS6Rc2t+PLMZ/XZRrPdwJcCro5ywamQljr2a9XY+DcFZiJthR7HV9n/lJCRC+ C+5tqCSG1rmeo0KnNBS0S4Ne/4GhVtYsRiBI/xwoOmu2Hhzn3AFOZweg0JgONnIGrwBpEpP r9IiXlOT0yAKon38em8xsy2SqIdlCA9zYWtPYMqD2WmRlEZst1gl2vqzUo9OI/1ZylPeJ3z MJxJIzwVmMOYFY/sAIuaO8zblLEtw== X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Andrew Rybchenko'" , References: <20210706095545.10776-1-jiawenwu@trustnetic.com> <20210706095545.10776-20-jiawenwu@trustnetic.com> In-Reply-To: Date: Thu, 8 Jul 2021 16:56:58 +0800 Message-ID: <002101d773d7$36111110$a2333330$@trustnetic.com>+824B39AF0D37DAE6 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLzOIuDxIImuXvqoTQ2pR2VqkNk+AJNuGS1AgX9oi6o3p5T4A== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v7 19/19] net/ngbe: support to close and reset device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On July 7, 2021 10:13 PM, Andrew Rybchenko wrote: > On 7/6/21 12:55 PM, Jiawen Wu wrote: > > Support to close and reset device. > > > > Signed-off-by: Jiawen Wu > > --- > > drivers/net/ngbe/ngbe_ethdev.c | 63 > > ++++++++++++++++++++++++++++++++-- > > drivers/net/ngbe/ngbe_ethdev.h | 2 ++ > > drivers/net/ngbe/ngbe_rxtx.c | 20 +++++++++++ > > 3 files changed, 82 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ngbe/ngbe_ethdev.c > > b/drivers/net/ngbe/ngbe_ethdev.c index 944fea6a11..1e3c11533b 100644 > > --- a/drivers/net/ngbe/ngbe_ethdev.c > > +++ b/drivers/net/ngbe/ngbe_ethdev.c > > @@ -256,7 +256,7 @@ eth_ngbe_dev_uninit(struct rte_eth_dev *eth_dev) > > > > ngbe_dev_close(eth_dev); > > > > - return -EINVAL; > > + return 0; > > } > > > > static int > > @@ -557,11 +557,66 @@ ngbe_dev_stop(struct rte_eth_dev *dev) static > > int ngbe_dev_close(struct rte_eth_dev *dev) { > > + struct ngbe_hw *hw = ngbe_dev_hw(dev); > > + struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); > > + struct rte_intr_handle *intr_handle = &pci_dev->intr_handle; > > + int retries = 0; > > + int ret; > > + > > PMD_INIT_FUNC_TRACE(); > > > > - RTE_SET_USED(dev); > > + ngbe_pf_reset_hw(hw); > > + > > + ret = ngbe_dev_stop(dev); > > Is it OK that the ret ignored? > In fact, there is no other value than 0 returned. Maybe I should just remove 'ret'. > > + > > + ngbe_dev_free_queues(dev); > > + > > + /* reprogram the RAR[0] in case user changed it. */ > > + ngbe_set_rar(hw, 0, hw->mac.addr, 0, true); > > + > > + /* Unlock any pending hardware semaphore */ > > + ngbe_swfw_lock_reset(hw); > > + > > + /* disable uio intr before callback unregister */ > > + rte_intr_disable(intr_handle); > > + > > + do { > > + ret = rte_intr_callback_unregister(intr_handle, > > + ngbe_dev_interrupt_handler, dev); > > + if (ret >= 0 || ret == -ENOENT) { > > + break; > > + } else if (ret != -EAGAIN) { > > + PMD_INIT_LOG(ERR, > > + "intr callback unregister failed: %d", > > + ret); > > + } > > + rte_delay_ms(100); > > + } while (retries++ < (10 + NGBE_LINK_UP_TIME)); > > + > > + rte_free(dev->data->mac_addrs); > > + dev->data->mac_addrs = NULL; > > + > > + rte_free(dev->data->hash_mac_addrs); > > + dev->data->hash_mac_addrs = NULL; > > + > > + return ret; > > +} > > + > > +/* > > + * Reset PF device. > > + */ > > +static int > > +ngbe_dev_reset(struct rte_eth_dev *dev) { > > + int ret; > > + > > + ret = eth_ngbe_dev_uninit(dev); > > + if (ret) > > Compare vs 0 > > [snip]