* [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
@ 2021-08-23 9:25 Jackie Liu
2021-08-23 13:33 ` Hanjun Guo
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jackie Liu @ 2021-08-23 9:25 UTC (permalink / raw)
To: lorenzo.pieralisi, guohanjun; +Cc: linux-acpi, liuyun01
From: Jackie Liu <liuyun01@kylinos.cn>
Fix modpost Section mismatch error in next_platform_timer().
[...]
WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.
WARNING: modpost: vmlinux.o(.text.unlikely+0x26e64): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.
ERROR: modpost: Section mismatches detected.
Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
make[1]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1
make[1]: *** Deleting file 'vmlinux.symvers'
make: *** [Makefile:1176: vmlinux] Error 2
[...]
Fixes: a712c3ed9b8a ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 0a0a982f9c28..c0e77c1c8e09 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
-static inline void *next_platform_timer(void *platform_timer)
+static inline __init void *next_platform_timer(void *platform_timer)
{
struct acpi_gtdt_header *gh = platform_timer;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
2021-08-23 9:25 [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error Jackie Liu
@ 2021-08-23 13:33 ` Hanjun Guo
2021-08-31 10:11 ` Jackie Liu
2021-10-12 16:44 ` Catalin Marinas
2 siblings, 0 replies; 5+ messages in thread
From: Hanjun Guo @ 2021-08-23 13:33 UTC (permalink / raw)
To: Jackie Liu, lorenzo.pieralisi; +Cc: linux-acpi, liuyun01
On 2021/8/23 17:25, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> Fix modpost Section mismatch error in next_platform_timer().
>
> [...]
> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e64): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> ERROR: modpost: Section mismatches detected.
> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
> make[1]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1
> make[1]: *** Deleting file 'vmlinux.symvers'
> make: *** [Makefile:1176: vmlinux] Error 2
> [...]
>
> Fixes: a712c3ed9b8a ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 0a0a982f9c28..c0e77c1c8e09 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>
> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>
> -static inline void *next_platform_timer(void *platform_timer)
> +static inline __init void *next_platform_timer(void *platform_timer)
> {
> struct acpi_gtdt_header *gh = platform_timer;
Looks good to me,
Acked-by: Hanjun Guo <guohanjun@huawei.com>
Thanks
Hanjun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
2021-08-23 9:25 [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error Jackie Liu
2021-08-23 13:33 ` Hanjun Guo
@ 2021-08-31 10:11 ` Jackie Liu
2021-09-01 2:27 ` Hanjun Guo
2021-10-12 16:44 ` Catalin Marinas
2 siblings, 1 reply; 5+ messages in thread
From: Jackie Liu @ 2021-08-31 10:11 UTC (permalink / raw)
To: lorenzo.pieralisi; +Cc: linux-acpi, liuyun01, Hanjun Guo
Friendly ping...
August 23, 2021 9:33 PM, "Hanjun Guo" <guohanjun@huawei.com> 写到:
> On 2021/8/23 17:25, Jackie Liu wrote:
>
>> From: Jackie Liu <liuyun01@kylinos.cn>
>> Fix modpost Section mismatch error in next_platform_timer().
>> [...]
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the
>> function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
>> The function next_platform_timer() references
>> the variable __initdata acpi_gtdt_desc.
>> This is often because next_platform_timer lacks a __initdata
>> annotation or the annotation of acpi_gtdt_desc is wrong.
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e64): Section mismatch in reference from the
>> function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
>> The function next_platform_timer() references
>> the variable __initdata acpi_gtdt_desc.
>> This is often because next_platform_timer lacks a __initdata
>> annotation or the annotation of acpi_gtdt_desc is wrong.
>> ERROR: modpost: Section mismatches detected.
>> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>> make[1]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1
>> make[1]: *** Deleting file 'vmlinux.symvers'
>> make: *** [Makefile:1176: vmlinux] Error 2
>> [...]
>> Fixes: a712c3ed9b8a ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
>> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
>> ---
>> drivers/acpi/arm64/gtdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
>> index 0a0a982f9c28..c0e77c1c8e09 100644
>> --- a/drivers/acpi/arm64/gtdt.c
>> +++ b/drivers/acpi/arm64/gtdt.c
>> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>>> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>>> -static inline void *next_platform_timer(void *platform_timer)
>> +static inline __init void *next_platform_timer(void *platform_timer)
>> {
>> struct acpi_gtdt_header *gh = platform_timer;
>
> Looks good to me,
>
> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>
> Thanks
> Hanjun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
2021-08-31 10:11 ` Jackie Liu
@ 2021-09-01 2:27 ` Hanjun Guo
0 siblings, 0 replies; 5+ messages in thread
From: Hanjun Guo @ 2021-09-01 2:27 UTC (permalink / raw)
To: Jackie Liu, lorenzo.pieralisi; +Cc: linux-acpi, liuyun01
On 2021/8/31 18:11, Jackie Liu wrote:
> Friendly ping...
Lorenzo, would you mind take this patch?
Thanks
Hanjun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
2021-08-23 9:25 [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error Jackie Liu
2021-08-23 13:33 ` Hanjun Guo
2021-08-31 10:11 ` Jackie Liu
@ 2021-10-12 16:44 ` Catalin Marinas
2 siblings, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2021-10-12 16:44 UTC (permalink / raw)
To: guohanjun, Jackie Liu, lorenzo.pieralisi
Cc: Will Deacon, liuyun01, linux-acpi, Rafael J. Wysocki, Arnd Bergmann
On Mon, 23 Aug 2021 17:25:26 +0800, Jackie Liu wrote:
> Fix modpost Section mismatch error in next_platform_timer().
>
> [...]
> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] acpi/arm64: fix next_platform_timer() section mismatch error
https://git.kernel.org/arm64/c/596143e3aec3
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-12 16:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 9:25 [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error Jackie Liu
2021-08-23 13:33 ` Hanjun Guo
2021-08-31 10:11 ` Jackie Liu
2021-09-01 2:27 ` Hanjun Guo
2021-10-12 16:44 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.