From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11422C10DCE for ; Wed, 18 Mar 2020 19:11:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E06842077A for ; Wed, 18 Mar 2020 19:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584558669; bh=i8/4x4L6BzJAkJGRo/v8prKLCHA1ASdllNL4i+xuPoM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XU8mIZrvBrEAtbihqyUUMpBms+mYoPEkB4g6lnuMQ9LmQelU8SCcjdtrlXmG+1cqs ulsrVlG6vKH/L0fXsCR8XjMDnIiBXwivtrcI5/S2ntEBo5Q6T7FPgtJxm7Noc8+2lD ehTCjORaLa8anW3wwwURYys41JRlWvIRC+Ub9qf4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbgCRTLI (ORCPT ); Wed, 18 Mar 2020 15:11:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:53466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgCRTLI (ORCPT ); Wed, 18 Mar 2020 15:11:08 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6795320768; Wed, 18 Mar 2020 19:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584558667; bh=i8/4x4L6BzJAkJGRo/v8prKLCHA1ASdllNL4i+xuPoM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Dt0nHeg7Qcu0KW7uQbQ2qwUrNujsVAuLeAiJrrKBfvfGCVCeKWWsB3VlZn9e3qlsd QyqJnS9r2Z3UhO8B52td/QEWvjPisF6g94G9C+MWp7pHHwNHTABvj0mCKpZDUQqGSq HNXZA2KunSE7Uzunjz/1sR2GT5XB7FE8uNPWTvbY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEe5p-00Diha-NV; Wed, 18 Mar 2020 19:11:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 18 Mar 2020 19:11:05 +0000 From: Marc Zyngier To: Sungbo Eo Cc: linux-oxnas@groups.io, Linus Walleij , Thomas Gleixner , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly In-Reply-To: References: <20200318170904.1461278-1-mans0n@gorani.run> <112cdab389aa9cc30189c7aec0baded2@kernel.org> Message-ID: <002b72cab9896fa5ac76a52e0cb503ff@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mans0n@gorani.run, linux-oxnas@groups.io, linus.walleij@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, narmstrong@baylibre.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-18 18:20, Sungbo Eo wrote: > Hi Marc, > > On 2020-03-19 02:48, Marc Zyngier wrote: >> Hi Sungbo, >> >> On 2020-03-18 17:09, Sungbo Eo wrote: >>> Enclose the chained handler with chained_irq_{enter,exit}(), so that >>> the >>> muxed interrupts get properly acked. >>> >>> This patch also fixes a reboot bug on OX820 SoC, where the jiffies >>> timer >>> interrupt is never acked. The kernel waits a clock tick forever in >>> calibrate_delay_converge(), which leads to a boot hang. >> >> Nice catch. >> >>> >>> Signed-off-by: Sungbo Eo >>> Cc: Neil Armstrong >>> --- >>>  drivers/irqchip/irq-versatile-fpga.c | 9 ++++++++- >>>  1 file changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/irqchip/irq-versatile-fpga.c >>> b/drivers/irqchip/irq-versatile-fpga.c >>> index 928858dada75..08faab2fec3e 100644 >>> --- a/drivers/irqchip/irq-versatile-fpga.c >>> +++ b/drivers/irqchip/irq-versatile-fpga.c >>> @@ -6,6 +6,7 @@ >>>  #include >>>  #include >>>  #include >>> +#include >>>  #include >>>  #include >>>  #include >>> @@ -68,12 +69,15 @@ static void fpga_irq_unmask(struct irq_data *d) >>> >>>  static void fpga_irq_handle(struct irq_desc *desc) >>>  { >>> +    struct irq_chip *chip = irq_desc_get_chip(desc); >>>      struct fpga_irq_data *f = irq_desc_get_handler_data(desc); >>>      u32 status = readl(f->base + IRQ_STATUS); >>> >>> +    chained_irq_enter(chip, desc); >>> + >> >> It's probably not a big deal, but I'm not fond of starting talking to >> the muxing irqchip before having done the chained_irq_enter() call. >> >> Moving that read here would probably be safer. > > Oops, I missed it. Thanks for pointing it out. > >> >>>      if (status == 0) { >>>          do_bad_IRQ(desc); >>> -        return; >>> +        goto out; >>>      } >>> >>>      do { >>> @@ -82,6 +86,9 @@ static void fpga_irq_handle(struct irq_desc *desc) >>>          status &= ~(1 << irq); >>>          generic_handle_irq(irq_find_mapping(f->domain, irq)); >>>      } while (status); >>> + >>> +out: >>> +    chained_irq_exit(chip, desc); >>>  } >>> >>>  /* >> >> Otherwise looks good. If you send it again with the above fixed >> and a Fixes: tag, I'll queue it. > > It seems the handler had been broken from the very beginning. Could > you give me a hint on how the tag should be like? Indeed, it has been broken forever. I'm tempted to say: Fixes: c41b16f8c9d9d ("ARM: integrator/versatile: consolidate FPGA IRQ handling code") even if it probably predates the introduction of the chained_irq_enter() helpers. This will ensure this gets backported to older kernels... Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAADC10DCE for ; Wed, 18 Mar 2020 19:11:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E87A2077B for ; Wed, 18 Mar 2020 19:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nW0tg7e0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dt0nHeg7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E87A2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6OOf3h7L1LmHpTdqTls3YIER5h9D/9RC1NBCaEqYScY=; b=nW0tg7e0JuQteNTReLIb6hiFY Z11sSMYxkXMb+ah/y3+8Uq9XCueJfyjHpeepT1gwZtlPI6GTJvZ4H5bfWfCkYTupyD3pXYQwKhkPu buSfiZ+0mHG3bHjtLb1jmWBgaOYjVDqOgvd2zoDoWSmpDxy+290LFPYkmdQjNiZQ6fSMRMRtrTGzy 6U3iRlF/53DACy85P+EQB8OmgBbV1aBMqjn8mCAQ8BKYaiC5x+iMDAbxRYv5QRF1zxCdTPiNUSUjH 2XyKi/ZJUAc0x+IDnW2XwCr4H2U9NNtH7+cl71QMGeitwF9oDspV3UXXKrJ2oYBDqaOL2+v8MbO8D pcx2y7odQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEe5v-00027b-1A; Wed, 18 Mar 2020 19:11:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEe5r-00026p-Ul for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2020 19:11:09 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6795320768; Wed, 18 Mar 2020 19:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584558667; bh=i8/4x4L6BzJAkJGRo/v8prKLCHA1ASdllNL4i+xuPoM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Dt0nHeg7Qcu0KW7uQbQ2qwUrNujsVAuLeAiJrrKBfvfGCVCeKWWsB3VlZn9e3qlsd QyqJnS9r2Z3UhO8B52td/QEWvjPisF6g94G9C+MWp7pHHwNHTABvj0mCKpZDUQqGSq HNXZA2KunSE7Uzunjz/1sR2GT5XB7FE8uNPWTvbY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEe5p-00Diha-NV; Wed, 18 Mar 2020 19:11:05 +0000 MIME-Version: 1.0 Date: Wed, 18 Mar 2020 19:11:05 +0000 From: Marc Zyngier To: Sungbo Eo Subject: Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly In-Reply-To: References: <20200318170904.1461278-1-mans0n@gorani.run> <112cdab389aa9cc30189c7aec0baded2@kernel.org> Message-ID: <002b72cab9896fa5ac76a52e0cb503ff@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mans0n@gorani.run, linux-oxnas@groups.io, linus.walleij@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, narmstrong@baylibre.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200318_121108_031585_C035FE57 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , Neil Armstrong , Linus Walleij , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-oxnas@groups.io, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wMy0xOCAxODoyMCwgU3VuZ2JvIEVvIHdyb3RlOgo+IEhpIE1hcmMsCj4gCj4gT24g MjAyMC0wMy0xOSAwMjo0OCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBIaSBTdW5nYm8sCj4+IAo+ PiBPbiAyMDIwLTAzLTE4IDE3OjA5LCBTdW5nYm8gRW8gd3JvdGU6Cj4+PiBFbmNsb3NlIHRoZSBj aGFpbmVkIGhhbmRsZXIgd2l0aCBjaGFpbmVkX2lycV97ZW50ZXIsZXhpdH0oKSwgc28gdGhhdCAK Pj4+IHRoZQo+Pj4gbXV4ZWQgaW50ZXJydXB0cyBnZXQgcHJvcGVybHkgYWNrZWQuCj4+PiAKPj4+ IFRoaXMgcGF0Y2ggYWxzbyBmaXhlcyBhIHJlYm9vdCBidWcgb24gT1g4MjAgU29DLCB3aGVyZSB0 aGUgamlmZmllcyAKPj4+IHRpbWVyCj4+PiBpbnRlcnJ1cHQgaXMgbmV2ZXIgYWNrZWQuIFRoZSBr ZXJuZWwgd2FpdHMgYSBjbG9jayB0aWNrIGZvcmV2ZXIgaW4KPj4+IGNhbGlicmF0ZV9kZWxheV9j b252ZXJnZSgpLCB3aGljaCBsZWFkcyB0byBhIGJvb3QgaGFuZy4KPj4gCj4+IE5pY2UgY2F0Y2gu Cj4+IAo+Pj4gCj4+PiBTaWduZWQtb2ZmLWJ5OiBTdW5nYm8gRW8gPG1hbnMwbkBnb3JhbmkucnVu Pgo+Pj4gQ2M6IE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KPj4+IC0t LQo+Pj4gwqBkcml2ZXJzL2lycWNoaXAvaXJxLXZlcnNhdGlsZS1mcGdhLmMgfCA5ICsrKysrKysr LQo+Pj4gwqAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+ PiAKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lycWNoaXAvaXJxLXZlcnNhdGlsZS1mcGdhLmMK Pj4+IGIvZHJpdmVycy9pcnFjaGlwL2lycS12ZXJzYXRpbGUtZnBnYS5jCj4+PiBpbmRleCA5Mjg4 NThkYWRhNzUuLjA4ZmFhYjJmZWMzZSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvaXJxY2hpcC9p cnEtdmVyc2F0aWxlLWZwZ2EuYwo+Pj4gKysrIGIvZHJpdmVycy9pcnFjaGlwL2lycS12ZXJzYXRp bGUtZnBnYS5jCj4+PiBAQCAtNiw2ICs2LDcgQEAKPj4+IMKgI2luY2x1ZGUgPGxpbnV4L2lycS5o Pgo+Pj4gwqAjaW5jbHVkZSA8bGludXgvaW8uaD4KPj4+IMKgI2luY2x1ZGUgPGxpbnV4L2lycWNo aXAuaD4KPj4+ICsjaW5jbHVkZSA8bGludXgvaXJxY2hpcC9jaGFpbmVkX2lycS5oPgo+Pj4gwqAj aW5jbHVkZSA8bGludXgvaXJxY2hpcC92ZXJzYXRpbGUtZnBnYS5oPgo+Pj4gwqAjaW5jbHVkZSA8 bGludXgvaXJxZG9tYWluLmg+Cj4+PiDCoCNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPj4+IEBA IC02OCwxMiArNjksMTUgQEAgc3RhdGljIHZvaWQgZnBnYV9pcnFfdW5tYXNrKHN0cnVjdCBpcnFf ZGF0YSAqZCkKPj4+IAo+Pj4gwqBzdGF0aWMgdm9pZCBmcGdhX2lycV9oYW5kbGUoc3RydWN0IGly cV9kZXNjICpkZXNjKQo+Pj4gwqB7Cj4+PiArwqDCoMKgIHN0cnVjdCBpcnFfY2hpcCAqY2hpcCA9 IGlycV9kZXNjX2dldF9jaGlwKGRlc2MpOwo+Pj4gwqDCoMKgwqAgc3RydWN0IGZwZ2FfaXJxX2Rh dGEgKmYgPSBpcnFfZGVzY19nZXRfaGFuZGxlcl9kYXRhKGRlc2MpOwo+Pj4gwqDCoMKgwqAgdTMy IHN0YXR1cyA9IHJlYWRsKGYtPmJhc2UgKyBJUlFfU1RBVFVTKTsKPj4+IAo+Pj4gK8KgwqDCoCBj aGFpbmVkX2lycV9lbnRlcihjaGlwLCBkZXNjKTsKPj4+ICsKPj4gCj4+IEl0J3MgcHJvYmFibHkg bm90IGEgYmlnIGRlYWwsIGJ1dCBJJ20gbm90IGZvbmQgb2Ygc3RhcnRpbmcgdGFsa2luZyB0bwo+ PiB0aGUgbXV4aW5nIGlycWNoaXAgYmVmb3JlIGhhdmluZyBkb25lIHRoZSBjaGFpbmVkX2lycV9l bnRlcigpIGNhbGwuCj4+IAo+PiBNb3ZpbmcgdGhhdCByZWFkIGhlcmUgd291bGQgcHJvYmFibHkg YmUgc2FmZXIuCj4gCj4gT29wcywgSSBtaXNzZWQgaXQuIFRoYW5rcyBmb3IgcG9pbnRpbmcgaXQg b3V0Lgo+IAo+PiAKPj4+IMKgwqDCoMKgIGlmIChzdGF0dXMgPT0gMCkgewo+Pj4gwqDCoMKgwqDC oMKgwqDCoCBkb19iYWRfSVJRKGRlc2MpOwo+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybjsKPj4+ ICvCoMKgwqDCoMKgwqDCoCBnb3RvIG91dDsKPj4+IMKgwqDCoMKgIH0KPj4+IAo+Pj4gwqDCoMKg wqAgZG8gewo+Pj4gQEAgLTgyLDYgKzg2LDkgQEAgc3RhdGljIHZvaWQgZnBnYV9pcnFfaGFuZGxl KHN0cnVjdCBpcnFfZGVzYyAqZGVzYykKPj4+IMKgwqDCoMKgwqDCoMKgwqAgc3RhdHVzICY9IH4o MSA8PCBpcnEpOwo+Pj4gwqDCoMKgwqDCoMKgwqDCoCBnZW5lcmljX2hhbmRsZV9pcnEoaXJxX2Zp bmRfbWFwcGluZyhmLT5kb21haW4sIGlycSkpOwo+Pj4gwqDCoMKgwqAgfSB3aGlsZSAoc3RhdHVz KTsKPj4+ICsKPj4+ICtvdXQ6Cj4+PiArwqDCoMKgIGNoYWluZWRfaXJxX2V4aXQoY2hpcCwgZGVz Yyk7Cj4+PiDCoH0KPj4+IAo+Pj4gwqAvKgo+PiAKPj4gT3RoZXJ3aXNlIGxvb2tzIGdvb2QuIElm IHlvdSBzZW5kIGl0IGFnYWluIHdpdGggdGhlIGFib3ZlIGZpeGVkCj4+IGFuZCBhIEZpeGVzOiB0 YWcsIEknbGwgcXVldWUgaXQuCj4gCj4gSXQgc2VlbXMgdGhlIGhhbmRsZXIgaGFkIGJlZW4gYnJv a2VuIGZyb20gdGhlIHZlcnkgYmVnaW5uaW5nLiBDb3VsZAo+IHlvdSBnaXZlIG1lIGEgaGludCBv biBob3cgdGhlIHRhZyBzaG91bGQgYmUgbGlrZT8KCkluZGVlZCwgaXQgaGFzIGJlZW4gYnJva2Vu IGZvcmV2ZXIuIEknbSB0ZW1wdGVkIHRvIHNheToKCkZpeGVzOiBjNDFiMTZmOGM5ZDlkICgiQVJN OiBpbnRlZ3JhdG9yL3ZlcnNhdGlsZTogY29uc29saWRhdGUgRlBHQSBJUlEgCmhhbmRsaW5nIGNv ZGUiKQoKZXZlbiBpZiBpdCBwcm9iYWJseSBwcmVkYXRlcyB0aGUgaW50cm9kdWN0aW9uIG9mIHRo ZSBjaGFpbmVkX2lycV9lbnRlcigpIApoZWxwZXJzLgpUaGlzIHdpbGwgZW5zdXJlIHRoaXMgZ2V0 cyBiYWNrcG9ydGVkIHRvIG9sZGVyIGtlcm5lbHMuLi4KClRoYW5rcywKCiAgICAgICAgIE0uCi0t IApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4uLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=