[Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms

[Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms

[Giulio Benetti]

Based on Gary Bisson patch qt5base: add qmake.conf fixup for i.MX platforms
Same happens for eglfs_mali.

As stated in QTBUG-61156 [1], since Qt5.9 all the Qt apps fail to start
on sunxi-mali platforms.

The reason is that the qmake.conf should apparently now specify which
eglfs backend to use.

Although this issue can be worked around by exporting a variable
(QT_QPA_EGLFS_INTEGRATION=eglfs_mali), this patch aims at providing
a more user-friendly approach by modifying qmake.conf when created.

[1]: https://bugreports.qt.io/browse/QTBUG-61156

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/qt5/qt5base/qt5base.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index b3f9c79..494031e 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -248,6 +248,14 @@ define QT5BASE_CONFIGURE_QMAKE_CONFIG
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST)$(BR2_PACKAGE_SUNXI_MALI_MAINLINE),yy)
+# use vivante backend
+define QT5BASE_CONFIGURE_QMAKE_CONFIG
+	echo "EGLFS_DEVICE_INTEGRATION = eglfs_mali" >> \
+		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
+endef
+endif
+
 ifneq ($(QT5BASE_CONFIG_FILE),)
 define QT5BASE_CONFIGURE_CONFIG_FILE
 	cp $(QT5BASE_CONFIG_FILE) $(@D)/src/corelib/global/qconfig-buildroot.h
-- 
2.7.4

[Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms

[Giulio Benetti]

This patch is buggy.
The same for Gary Bisson patch.
Must put "EGLFS_DEVICE_INTEGRATION = eglfs_mali"
before:

include(../common/linux_device_post.conf)
load(qt_config)

otherwise qmake ignores it.
I thought to use sed to append EGLFS_DEVICE_INTEGRATION = eglfs_mali/viv 
just after include(arch.conf).

What do you think?

Kind regards

Il 07/11/2017 15:48, Giulio Benetti ha scritto:
> Based on Gary Bisson patch qt5base: add qmake.conf fixup for i.MX platforms
> Same happens for eglfs_mali.
> 
> As stated in QTBUG-61156 [1], since Qt5.9 all the Qt apps fail to start
> on sunxi-mali platforms.
> 
> The reason is that the qmake.conf should apparently now specify which
> eglfs backend to use.
> 
> Although this issue can be worked around by exporting a variable
> (QT_QPA_EGLFS_INTEGRATION=eglfs_mali), this patch aims at providing
> a more user-friendly approach by modifying qmake.conf when created.
> 
> [1]: https://bugreports.qt.io/browse/QTBUG-61156
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>   package/qt5/qt5base/qt5base.mk | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index b3f9c79..494031e 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -248,6 +248,14 @@ define QT5BASE_CONFIGURE_QMAKE_CONFIG
>   endef
>   endif
>   
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST)$(BR2_PACKAGE_SUNXI_MALI_MAINLINE),yy)
> +# use vivante backend
> +define QT5BASE_CONFIGURE_QMAKE_CONFIG
> +	echo "EGLFS_DEVICE_INTEGRATION = eglfs_mali" >> \
> +		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
> +endef
> +endif
> +
>   ifneq ($(QT5BASE_CONFIG_FILE),)
>   define QT5BASE_CONFIGURE_CONFIG_FILE
>   	cp $(QT5BASE_CONFIG_FILE) $(@D)/src/corelib/global/qconfig-buildroot.h
> 


-- 
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

[Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms

[Arnout Vandecappelle]

On 07-11-17 19:58, Giulio Benetti wrote:
> This patch is buggy.
> The same for Gary Bisson patch.
> Must put "EGLFS_DEVICE_INTEGRATION = eglfs_mali"
> before:
> 
> include(../common/linux_device_post.conf)
> load(qt_config)
> 
> otherwise qmake ignores it.
> I thought to use sed to append EGLFS_DEVICE_INTEGRATION = eglfs_mali/viv just
> after include(arch.conf).

 Yes, with sed is a good idea. Preferably by renaming qmake.conf to
qmake.conf.in and always using sed to generate the actual qmake.conf file. Add a
line

EGLFS_DEVICE_INTEGRATION = @EGLFS_DEVICE@

at the appropriate place. The sed then either replaces @EGLFS_DEVICE@ with the
proper string, or deletes the line.

 Regards,
 Arnout

> 
> What do you think?
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms

[Giulio Benetti]

Perfect,

tomorrow I submit a patch.

Thanks
Cheers

Il 07/11/2017 21:21, Arnout Vandecappelle ha scritto:
>
> On 07-11-17 19:58, Giulio Benetti wrote:
>> This patch is buggy.
>> The same for Gary Bisson patch.
>> Must put "EGLFS_DEVICE_INTEGRATION = eglfs_mali"
>> before:
>>
>> include(../common/linux_device_post.conf)
>> load(qt_config)
>>
>> otherwise qmake ignores it.
>> I thought to use sed to append EGLFS_DEVICE_INTEGRATION = eglfs_mali/viv just
>> after include(arch.conf).
>   Yes, with sed is a good idea. Preferably by renaming qmake.conf to
> qmake.conf.in and always using sed to generate the actual qmake.conf file. Add a
> line
>
> EGLFS_DEVICE_INTEGRATION = @EGLFS_DEVICE@
>
> at the appropriate place. The sed then either replaces @EGLFS_DEVICE@ with the
> proper string, or deletes the line.
>
>   Regards,
>   Arnout
>
>> What do you think?
> [snip]
>

-- 
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642