Re: [Fuego] [PATCH] LTP_Smack: add a new job to test "smack" module

["Daniel Sangorrin" <daniel.sangorrin@toshiba.co.jp>]

> From: Tim.Bird@sony.com <Tim.Bird@sony.com>
> Sent: Saturday, July 14, 2018 2:15 AM
> > From: Daniel Sangorrin
> >
> > Hi Li, Tim:
> >
> > The smack tests can be run using:
> >   $ ftc run-test -b myboard -t Functional.LTP --dynamic-vars "{'tests':'smack'}"
> 
> Which reminds me that I want to get the dynamic-vars feature merged.
> Maybe we can find some time next week to split it from the 'call-ftc-directly'
> patches and get it into master?

OK, I will prepare clean patches for master and re-send.


> 
> >
> > Alternatively, while "Dynamic vars" are merged, you can instead add a spec
> > to Functional.LTP/spec.json
> 
> Do you mean "not merged"?

Yes, sorry.

> But yes, Li, you should be able to do this as a spec for Functional.LTP.  Is
> there a reason this was done as a separate test?  I thought there would
> be special setup (and there is, to some degree).  Is that the reason this
> is not just another LTP spec?
> 
> >
> > Note: make sure that you prepare your machine for smack by modifying
> > fstab and adding the security=smack kernel parameter
> > # vi /etc/fstab
> > smackfs /sys/fs/smackfs smackfs defaults 0 0
> > # reboot
> >   -> grub: add security=smack
> >
> > If you want to run a single smack test (e.g. smack_set_ambient) then you
> > should be able to use Function.LTP_one_test. Unfortunately,
> > Function.LTP_one_test's test_deploy function still needs some
> > improvements.
> >
> > After those improvements this should work:
> >   $ ftc run-test -b myboard -t Functional.LTP_one_test --dynamic-vars
> > "{'TEST':'smack_set_environment', 'scenario':'smack'}"
> 
> This looks like it will perform the smack setup, but does it also
> run the smack tests?

Sorry the test was supposed to read smack_set_ambient	
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/security/smack/smack_set_ambient.sh

Thanks,
Daniel