From: "Kyungmin Park" <kmpark@infradead.org>
To: "'Adrian Hunter'" <ext-adrian.hunter@nokia.com>,
<linux-mtd@lists.infradead.org>
Subject: RE: [PATCH] [MTD] OneNAND: Invalidate bufferRAM after erase
Date: Fri, 9 Feb 2007 09:16:43 +0900 [thread overview]
Message-ID: <002f01c74bdf$98098760$c7a3580a@swcenter.sec.samsung.co.kr> (raw)
In-Reply-To: <45CAF583.8000709@nokia.com>
Hi Adrian,
I checked it with pagetest module. Without the patch it failed.
I have two minor comments.
Thank you,
Kyungmin Park
> /**
> + * onenand_invalidate_bufferram_range - [GENERIC] Invalidate
> BufferRAM information
> + * @param mtd MTD data structure
> + * @param addr start address to invalidate
> + * @param len length to invalidate
> + *
> + * Invalidate BufferRAM information
> + */
> +static void onenand_invalidate_bufferram_range(struct
> mtd_info *mtd, loff_t addr,
> + unsigned int len)
It's name too long even though it invalidate with some range.
How about just call "onenand_invalidate_bufferram"?
> +/**
> * onenand_get_device - [GENERIC] Get chip for selected access
> * @param mtd MTD device structure
> * @param new_state the state which is requested
> @@ -1466,6 +1489,8 @@ static int onenand_erase(struct mtd_info
> goto erase_exit;
> }
>
> + onenand_invalidate_bufferram_range(mtd, addr,
> block_size);
> +
> this->command(mtd, ONENAND_CMD_ERASE, addr, block_size);
Place onenand_invalidate_bufferram_range here
Since erase command takes a long time, 2msec so we overlap the some cpu
works and onenand physicall works between command and wait.
>
> ret = this->wait(mtd, FL_ERASING);
next prev parent reply other threads:[~2007-02-09 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 10:03 [PATCH] [MTD] OneNAND: Invalidate bufferRAM after erase Adrian Hunter
2007-02-09 0:16 ` Kyungmin Park [this message]
2007-02-09 9:47 ` Adrian Hunter
2007-02-09 15:17 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01c74bdf$98098760$c7a3580a@swcenter.sec.samsung.co.kr' \
--to=kmpark@infradead.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.