From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: RE: [PATCH 3/6] ARM: S5PC110: Add si470x radio device to the GONI board Date: Tue, 14 Sep 2010 07:43:22 +0200 Message-ID: <003001cb53cf$c158a960$4409fc20$%szyprowski@samsung.com> References: <1284103403-10696-1-git-send-email-m.szyprowski@samsung.com> <1284103403-10696-4-git-send-email-m.szyprowski@samsung.com> <000601cb50ce$b24f5620$16ee0260$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:29594 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005Ab0INFna (ORCPT ); Tue, 14 Sep 2010 01:43:30 -0400 Received: from epmmp1 (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0L8Q00IHE2KHRO30@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 14 Sep 2010 14:43:29 +0900 (KST) Received: from AMDC159 ([106.116.37.153]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L8Q00DGT2KCAH@mmp1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 14 Sep 2010 14:43:29 +0900 (KST) In-reply-to: <000601cb50ce$b24f5620$16ee0260$%kim@samsung.com> Content-language: pl Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Kukjin Kim' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kyungmin.park@samsung.com, 'Joonyoung Shim' , ben-linux@fluff.org Hello, On Friday, September 10, 2010 11:58 AM Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Add required platform definitions for si470x radio device on Samsung > > Goni board. > > > Is this the same with following? > http://marc.info/?l=linux-arm-kernel&m=128220793700997&w=2 Yes, but I rebased it onto latest kgene/for-next kernel tree together with other Goni patches. I did this to collect all Goni patches together for easier merging. > > Signed-off-by: Joonyoung Shim > > Signed-off-by: Kyungmin Park > > Signed-off-by: Marek Szyprowski > > --- > > arch/arm/mach-s5pv210/Kconfig | 2 ++ > > arch/arm/mach-s5pv210/mach-goni.c | 29 > > +++++++++++++++++++++++++++++ > > 2 files changed, 31 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach- > s5pv210/Kconfig > > index b46925b..b1f671d 100644 > > --- a/arch/arm/mach-s5pv210/Kconfig > > +++ b/arch/arm/mach-s5pv210/Kconfig > > @@ -83,9 +83,11 @@ config MACH_GONI > > select S3C_DEV_HSMMC > > select S3C_DEV_HSMMC1 > > select S3C_DEV_HSMMC2 > > + select S3C_DEV_I2C1 > > select S5P_DEV_ONENAND > > select SAMSUNG_DEV_KEYPAD > > select S5PV210_SETUP_FB_24BPP > > + select S5PV210_SETUP_I2C1 > > select S5PV210_SETUP_KEYPAD > > select S5PV210_SETUP_SDHCI > > help > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- > > goni.c > > index b263f3a..30da422 100644 > > --- a/arch/arm/mach-s5pv210/mach-goni.c > > +++ b/arch/arm/mach-s5pv210/mach-goni.c > > @@ -38,6 +38,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -200,6 +201,27 @@ static struct samsung_keypad_platdata keypad_data > > __initdata = { > > .cols = 3, > > }; > > > > +/* Radio */ > > +static struct i2c_board_info i2c1_devs[] __initdata = { > > + { > > + I2C_BOARD_INFO("si470x", 0x10), > > + }, > > +}; > > + > > +static void __init goni_radio_init(void) > > +{ > > + int gpio; > > + > > + gpio = S5PV210_GPJ2(4); /* XMSMDATA_4 */ > > + gpio_request(gpio, "FM_INT"); > > + s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf)); > > + i2c1_devs[0].irq = gpio_to_irq(gpio); > > + > > + gpio = S5PV210_GPJ2(5); /* XMSMDATA_5 */ > > + gpio_request(gpio, "FM_RST"); > > + gpio_direction_output(gpio, 1); > > +} > > + > > /* MAX8998 regulators */ > > #if defined(CONFIG_REGULATOR_MAX8998) || > > defined(CONFIG_REGULATOR_MAX8998_MODULE) > > > > @@ -567,6 +589,13 @@ static void __init goni_map_io(void) > > > > static void __init goni_machine_init(void) > > { > > + /* Radio: call before I2C 1 registeration */ > > + goni_radio_init(); > > + > > + /* I2C1 */ > > + s3c_i2c1_set_platdata(NULL); > > + i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); > > + > > /* PMIC */ > > goni_pmic_init(); > > i2c_register_board_info(AP_I2C_GPIO_PMIC_BUS_4, > > i2c_gpio_pmic_devs, > > -- > > Best regards -- Marek Szyprowski Samsung Poland R&D Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Tue, 14 Sep 2010 07:43:22 +0200 Subject: [PATCH 3/6] ARM: S5PC110: Add si470x radio device to the GONI board In-Reply-To: <000601cb50ce$b24f5620$16ee0260$%kim@samsung.com> References: <1284103403-10696-1-git-send-email-m.szyprowski@samsung.com> <1284103403-10696-4-git-send-email-m.szyprowski@samsung.com> <000601cb50ce$b24f5620$16ee0260$%kim@samsung.com> Message-ID: <003001cb53cf$c158a960$4409fc20$%szyprowski@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Friday, September 10, 2010 11:58 AM Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Add required platform definitions for si470x radio device on Samsung > > Goni board. > > > Is this the same with following? > http://marc.info/?l=linux-arm-kernel&m=128220793700997&w=2 Yes, but I rebased it onto latest kgene/for-next kernel tree together with other Goni patches. I did this to collect all Goni patches together for easier merging. > > Signed-off-by: Joonyoung Shim > > Signed-off-by: Kyungmin Park > > Signed-off-by: Marek Szyprowski > > --- > > arch/arm/mach-s5pv210/Kconfig | 2 ++ > > arch/arm/mach-s5pv210/mach-goni.c | 29 > > +++++++++++++++++++++++++++++ > > 2 files changed, 31 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach- > s5pv210/Kconfig > > index b46925b..b1f671d 100644 > > --- a/arch/arm/mach-s5pv210/Kconfig > > +++ b/arch/arm/mach-s5pv210/Kconfig > > @@ -83,9 +83,11 @@ config MACH_GONI > > select S3C_DEV_HSMMC > > select S3C_DEV_HSMMC1 > > select S3C_DEV_HSMMC2 > > + select S3C_DEV_I2C1 > > select S5P_DEV_ONENAND > > select SAMSUNG_DEV_KEYPAD > > select S5PV210_SETUP_FB_24BPP > > + select S5PV210_SETUP_I2C1 > > select S5PV210_SETUP_KEYPAD > > select S5PV210_SETUP_SDHCI > > help > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c > b/arch/arm/mach-s5pv210/mach- > > goni.c > > index b263f3a..30da422 100644 > > --- a/arch/arm/mach-s5pv210/mach-goni.c > > +++ b/arch/arm/mach-s5pv210/mach-goni.c > > @@ -38,6 +38,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -200,6 +201,27 @@ static struct samsung_keypad_platdata keypad_data > > __initdata = { > > .cols = 3, > > }; > > > > +/* Radio */ > > +static struct i2c_board_info i2c1_devs[] __initdata = { > > + { > > + I2C_BOARD_INFO("si470x", 0x10), > > + }, > > +}; > > + > > +static void __init goni_radio_init(void) > > +{ > > + int gpio; > > + > > + gpio = S5PV210_GPJ2(4); /* XMSMDATA_4 */ > > + gpio_request(gpio, "FM_INT"); > > + s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf)); > > + i2c1_devs[0].irq = gpio_to_irq(gpio); > > + > > + gpio = S5PV210_GPJ2(5); /* XMSMDATA_5 */ > > + gpio_request(gpio, "FM_RST"); > > + gpio_direction_output(gpio, 1); > > +} > > + > > /* MAX8998 regulators */ > > #if defined(CONFIG_REGULATOR_MAX8998) || > > defined(CONFIG_REGULATOR_MAX8998_MODULE) > > > > @@ -567,6 +589,13 @@ static void __init goni_map_io(void) > > > > static void __init goni_machine_init(void) > > { > > + /* Radio: call before I2C 1 registeration */ > > + goni_radio_init(); > > + > > + /* I2C1 */ > > + s3c_i2c1_set_platdata(NULL); > > + i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs)); > > + > > /* PMIC */ > > goni_pmic_init(); > > i2c_register_board_info(AP_I2C_GPIO_PMIC_BUS_4, > > i2c_gpio_pmic_devs, > > -- > > Best regards -- Marek Szyprowski Samsung Poland R&D Center