From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <alim.akhtar@samsung.com>,
<avri.altman@wdc.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <beanhuo@micron.com>,
<asutoshd@codeaurora.org>, <cang@codeaurora.org>,
"'Christoph Hellwig'" <hch@lst.de>
Subject: RE: [RFC PATCH v1 1/2] ufs: introduce callbacks to get command information
Date: Tue, 23 Jun 2020 11:28:06 +0900 [thread overview]
Message-ID: <003201d64905$ee05a5e0$ca10f1a0$@samsung.com> (raw)
In-Reply-To: <992d1812-98b9-99b5-acc0-69c7aba3d074@acm.org>
> On 2020-06-19 23:53, Kiwoong Kim wrote:
> > Some SoC specific might need command history for various reasons, such
> > as stacking command contexts in system memory to check for debugging
> > in the future or scaling some DVFS knobs to boost IO throughput.
> >
> > What you would do with the information could be variant per SoC
> > vendor.
>
> Isn't this something that should be done in an I/O scheduler instead of in
> a SCSI LLD? I don't like the idea behind this patch series at all.
>
> Bart.
If you could get the information, Many would exploit it for their respective purposes.
But, it's important for the information to contain accurate timestamps when the driver
hooks it, if you're trying to figure out something wrong.
As for scaling DVFS knobs to boost UFS throughput, locating in the ufs driver is more
Beneficial because SoC vendors have their own power domains and thus lead to make
different way of what to scale up to boost. If it's populated in block layer, there is
no way to introduce boosting per SoC.
next prev parent reply other threads:[~2020-06-23 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200620070044epcas2p269e3c266c86c65dd0e894d8188036a30@epcas2p2.samsung.com>
2020-06-20 6:53 ` [RFC PATCH v1 1/2] ufs: introduce callbacks to get command information Kiwoong Kim
[not found] ` <CGME20200620070047epcas2p37229d52d479df9f64ee4fc14f469acf9@epcas2p3.samsung.com>
2020-06-20 6:53 ` [RFC PATCH v1 2/2] exynos-ufs: support command history Kiwoong Kim
2020-06-20 15:26 ` kernel test robot
2020-06-20 19:08 ` kernel test robot
2020-06-24 3:10 ` Bart Van Assche
2020-06-29 8:49 ` Kiwoong Kim
2020-06-29 10:08 ` Kiwoong Kim
2020-06-20 16:33 ` [RFC PATCH v1 1/2] ufs: introduce callbacks to get command information Bart Van Assche
2020-06-23 2:28 ` Kiwoong Kim [this message]
2020-06-24 2:53 ` Bart Van Assche
2020-06-22 11:35 ` Dan Carpenter
2020-06-22 11:35 ` Dan Carpenter
2020-06-25 14:05 ` Stanley Chu
2020-06-26 11:42 ` Kiwoong Kim
2020-06-26 12:29 ` Stanley Chu
2020-06-29 7:01 ` Kiwoong Kim
2020-06-29 7:11 ` Kiwoong Kim
2020-06-20 19:48 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003201d64905$ee05a5e0$ca10f1a0$@samsung.com' \
--to=kwmad.kim@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.