From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D3FC433F5 for ; Wed, 29 Sep 2021 15:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF9AC61452 for ; Wed, 29 Sep 2021 15:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345235AbhI2P3M (ORCPT ); Wed, 29 Sep 2021 11:29:12 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:61726 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345157AbhI2P3L (ORCPT ); Wed, 29 Sep 2021 11:29:11 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18T5AOjm028432; Wed, 29 Sep 2021 10:27:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : references : in-reply-to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=PODMain02222019; bh=lufwfwvERELgO9NEGU6Lgf7W4wEUPOq32o36cIe4gcY=; b=UmMVhMfK+s+JPZQeYlgZAta/LvCs66h/oQDiYP/LmEDlEDWwhw+1Byw2Klmiy5vlfWRJ Q1drE8P+KZzS+mu8s994jCztAZ+7tjW1m98uW36i1rVYOUfP9KZVAkfLmemr0qwa8cZv DSroPcJ6QGuhOXa/2Ft64IaTRsCYDeLKCaSF1KvH8kh2RgURVqOVWebqODNGd7X7ETuQ nJ8HfVbSeMWot4EzFLpdFHQbIBWIk/RR4m0am905PY1Es+gUxxQtPan7V6n49aPnaAjw N3H52kx0JjmfokUBTaBTE3qWHFde3SsOFklGtOZK2r14FoE0/nuTJX0+TuuqCvOrVDz7 rw== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 3bc62dhg40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Sep 2021 10:27:22 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 16:27:20 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 16:27:20 +0100 Received: from LONN13613Z2 (unknown [198.90.238.180]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id BA7C3B13; Wed, 29 Sep 2021 15:27:19 +0000 (UTC) From: Simon Trimmer To: 'Mark Brown' CC: , , , , 'kernel test robot' References: <20210929145040.793252-1-simont@opensource.cirrus.com> <20210929145222.GR4199@sirena.org.uk> In-Reply-To: <20210929145222.GR4199@sirena.org.uk> Subject: RE: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled Date: Wed, 29 Sep 2021 16:27:19 +0100 Message-ID: <003301d7b546$7e33c860$7a9b5920$@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGXccUOEHhpH88acPEvIClxpmzepAEhxdJIrDKTD1A= Content-Language: en-us X-Proofpoint-GUID: 8gEi_8JgVpX4abUr5fYqsVxHug7M5HkR X-Proofpoint-ORIG-GUID: 8gEi_8JgVpX4abUr5fYqsVxHug7M5HkR X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wednesday, September 29, 2021 3:52 PM, Mark Brown wrote: > The more common pattern is to declare a static inline stub function > instead of the prototype if debugfs is disabled. Hi Mark, Yes there is one for the cs_dsp_init_debugfs function though the compilation failure the bot detected is with the parameter dereferencing the disappearing snd_soc_component member. I could make a utility inline for use in this function that would do the dereference or return NULL based on the state of the config option if you think that would be neater? (For the expense of a new function it would separate the call of the stub from the conditional access of the member based on IS_ENABLED) Thanks, Simon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460B1C433F5 for ; Wed, 29 Sep 2021 15:28:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4F6C614C8 for ; Wed, 29 Sep 2021 15:28:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B4F6C614C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72E1516D7; Wed, 29 Sep 2021 17:27:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72E1516D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632929300; bh=lufwfwvERELgO9NEGU6Lgf7W4wEUPOq32o36cIe4gcY=; h=From:To:References:In-Reply-To:Subject:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IkK+rrBBs0pnSbTXIwTd11WutV5xnvfiSFz60gsoLX2oalO59lKsEci8cPCuVDi6U jgijBR5Q+SdbUj1jC6Jx7Hru5cORySTXT0pmA1GZImU/Wpdk6EYVWApFDC+YRXc+Go 1Jvg3Oa1KwNfPUW42+EHNQlfKQHADgHhBfVp3/RA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E1DE9F801F7; Wed, 29 Sep 2021 17:27:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 164A7F80227; Wed, 29 Sep 2021 17:27:28 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 49FEDF80161 for ; Wed, 29 Sep 2021 17:27:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 49FEDF80161 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="UmMVhMfK" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18T5AOjm028432; Wed, 29 Sep 2021 10:27:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : references : in-reply-to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=PODMain02222019; bh=lufwfwvERELgO9NEGU6Lgf7W4wEUPOq32o36cIe4gcY=; b=UmMVhMfK+s+JPZQeYlgZAta/LvCs66h/oQDiYP/LmEDlEDWwhw+1Byw2Klmiy5vlfWRJ Q1drE8P+KZzS+mu8s994jCztAZ+7tjW1m98uW36i1rVYOUfP9KZVAkfLmemr0qwa8cZv DSroPcJ6QGuhOXa/2Ft64IaTRsCYDeLKCaSF1KvH8kh2RgURVqOVWebqODNGd7X7ETuQ nJ8HfVbSeMWot4EzFLpdFHQbIBWIk/RR4m0am905PY1Es+gUxxQtPan7V6n49aPnaAjw N3H52kx0JjmfokUBTaBTE3qWHFde3SsOFklGtOZK2r14FoE0/nuTJX0+TuuqCvOrVDz7 rw== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 3bc62dhg40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Sep 2021 10:27:22 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 16:27:20 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 16:27:20 +0100 Received: from LONN13613Z2 (unknown [198.90.238.180]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id BA7C3B13; Wed, 29 Sep 2021 15:27:19 +0000 (UTC) From: Simon Trimmer To: 'Mark Brown' References: <20210929145040.793252-1-simont@opensource.cirrus.com> <20210929145222.GR4199@sirena.org.uk> In-Reply-To: <20210929145222.GR4199@sirena.org.uk> Subject: RE: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled Date: Wed, 29 Sep 2021 16:27:19 +0100 Message-ID: <003301d7b546$7e33c860$7a9b5920$@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGXccUOEHhpH88acPEvIClxpmzepAEhxdJIrDKTD1A= Content-Language: en-us X-Proofpoint-GUID: 8gEi_8JgVpX4abUr5fYqsVxHug7M5HkR X-Proofpoint-ORIG-GUID: 8gEi_8JgVpX4abUr5fYqsVxHug7M5HkR X-Proofpoint-Spam-Reason: safe Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, 'kernel test robot' , lgirdwood@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > On Wednesday, September 29, 2021 3:52 PM, Mark Brown wrote: > The more common pattern is to declare a static inline stub function > instead of the prototype if debugfs is disabled. Hi Mark, Yes there is one for the cs_dsp_init_debugfs function though the compilation failure the bot detected is with the parameter dereferencing the disappearing snd_soc_component member. I could make a utility inline for use in this function that would do the dereference or return NULL based on the state of the config option if you think that would be neater? (For the expense of a new function it would separate the call of the stub from the conditional access of the member based on IS_ENABLED) Thanks, Simon