From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2DFCCA479 for ; Tue, 28 Jun 2022 09:57:11 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6913E40691; Tue, 28 Jun 2022 11:57:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 345B6400D7 for ; Tue, 28 Jun 2022 11:57:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656410228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNvuRaNMD2bJom22D+/xUDVgOXARGDD3mEIPXqL0LjY=; b=aT2GqHtyF/NUDfy/IFIi/+995WbvBtSCies1D7NeHCSIJgXSIS2TlRjNFNNzhXb0vLNoz8 cJFMIDWDcd2Oad4BMXvTtByp4MdcisJCvLbRNgDKTNAS1JFWzivQP+RREUYk2eByNJ5iW1 Jck7AgGmE/wjQYnAxd1VhIIDsq/Bt8c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-4tSGJ8VPOuOQO6JWBxnLjg-1; Tue, 28 Jun 2022 05:57:05 -0400 X-MC-Unique: 4tSGJ8VPOuOQO6JWBxnLjg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E22C918812CB; Tue, 28 Jun 2022 09:57:04 +0000 (UTC) Received: from [10.39.208.33] (unknown [10.39.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2269D492C3B; Tue, 28 Jun 2022 09:57:03 +0000 (UTC) Message-ID: <00357c27-25b1-a423-1a99-78de21ff519e@redhat.com> Date: Tue, 28 Jun 2022 11:57:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net/vhost: fix compliant offloading flag To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, weix.ling@intel.com References: <20220628094246.97223-1-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: <20220628094246.97223-1-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/28/22 11:42, xuan.ding@intel.com wrote: > From: Xuan Ding > > This patch fixes the check to set compliant offloading flag. > Compliant offloading flag should be set when the > 'legacy-ol-flags' is true. > > Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode") > > Signed-off-by: Xuan Ding > --- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index d75d256040..24049df58a 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) > goto out_free; > } > > - if (legacy_ol_flags == 0) > + if (legacy_ol_flags == 1) > flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS; > > if (dev->device.numa_node == SOCKET_ID_ANY) Nack, legacy OL flags is NOT compliant. So current implementation is good. Regards, Maxime