From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671Ab1B1K6Q (ORCPT ); Mon, 28 Feb 2011 05:58:16 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:53719 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740Ab1B1K6P (ORCPT ); Mon, 28 Feb 2011 05:58:15 -0500 Date: Mon, 28 Feb 2011 19:58:11 +0900 From: Kukjin Kim Subject: RE: [PATCH 06/09] ARM: s3c2440: gta02: Remove state_mem constraints for the pcf50633 regulators In-reply-to: <4D6B78CD.5090602@metafoo.de> To: "'Lars-Peter Clausen'" Cc: "'Ben Dooks'" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-id: <003601cbd736$65cbc510$31634f30$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: ko Content-transfer-encoding: 7BIT Thread-index: AcvXMgwC9vuGqSg9R5ib/89iG3xhnwABENeA References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-6-git-send-email-lars@metafoo.de> <000401cbd710$6035fab0$20a1f010$%kim@samsung.com> <4D6B78CD.5090602@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lars-Peter Clausen wrote: > > On 02/28/2011 07:26 AM, Kukjin Kim wrote: > > Lars-Peter Clausen wrote: > >> > >> The pcf50633 regulator driver does not use the state_mem constraints, so > >> there > >> is no use in setting them. > >> > >> Signed-off-by: Lars-Peter Clausen > >> --- > >> arch/arm/mach-s3c2440/mach-gta02.c | 15 --------------- > >> 1 files changed, 0 insertions(+), 15 deletions(-) > >> > >> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c > > b/arch/arm/mach-s3c2440/mach- > >> gta02.c > >> index e57c4d8..01e0930 100644 > >> --- a/arch/arm/mach-s3c2440/mach-gta02.c > >> +++ b/arch/arm/mach-s3c2440/mach-gta02.c > >> @@ -283,9 +283,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .always_on = 1, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_DOWN1] = { > >> @@ -304,9 +301,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .apply_uV = 1, > >> .always_on = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_HCLDO] = { > >> @@ -325,9 +319,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 0, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_LDO2] = { > >> @@ -362,9 +353,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_LDO6] = { > >> @@ -379,9 +367,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .min_uV = 1800000, > >> .max_uV = 1800000, > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> > >> -- > > > > Don't we need regulator_suspend_mem_state_show() on PCF50633? > > > > > No. The pcf50633 driver has no set_suspend_enable or set_suspend_disable ops. > So the 'suspend_mem_state' sysfs file does not get registered and that > function > is never called. > Ok, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Mon, 28 Feb 2011 19:58:11 +0900 Subject: [PATCH 06/09] ARM: s3c2440: gta02: Remove state_mem constraints for the pcf50633 regulators In-Reply-To: <4D6B78CD.5090602@metafoo.de> References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-6-git-send-email-lars@metafoo.de> <000401cbd710$6035fab0$20a1f010$%kim@samsung.com> <4D6B78CD.5090602@metafoo.de> Message-ID: <003601cbd736$65cbc510$31634f30$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Lars-Peter Clausen wrote: > > On 02/28/2011 07:26 AM, Kukjin Kim wrote: > > Lars-Peter Clausen wrote: > >> > >> The pcf50633 regulator driver does not use the state_mem constraints, so > >> there > >> is no use in setting them. > >> > >> Signed-off-by: Lars-Peter Clausen > >> --- > >> arch/arm/mach-s3c2440/mach-gta02.c | 15 --------------- > >> 1 files changed, 0 insertions(+), 15 deletions(-) > >> > >> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c > > b/arch/arm/mach-s3c2440/mach- > >> gta02.c > >> index e57c4d8..01e0930 100644 > >> --- a/arch/arm/mach-s3c2440/mach-gta02.c > >> +++ b/arch/arm/mach-s3c2440/mach-gta02.c > >> @@ -283,9 +283,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .always_on = 1, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_DOWN1] = { > >> @@ -304,9 +301,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .apply_uV = 1, > >> .always_on = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_HCLDO] = { > >> @@ -325,9 +319,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 0, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_LDO2] = { > >> @@ -362,9 +353,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, > >> .apply_uV = 1, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> [PCF50633_REGULATOR_LDO6] = { > >> @@ -379,9 +367,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { > >> .min_uV = 1800000, > >> .max_uV = 1800000, > >> .valid_modes_mask = REGULATOR_MODE_NORMAL, > >> - .state_mem = { > >> - .enabled = 1, > >> - }, > >> }, > >> }, > >> > >> -- > > > > Don't we need regulator_suspend_mem_state_show() on PCF50633? > > > > > No. The pcf50633 driver has no set_suspend_enable or set_suspend_disable ops. > So the 'suspend_mem_state' sysfs file does not get registered and that > function > is never called. > Ok, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.