From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758390AbcAKH0J (ORCPT ); Mon, 11 Jan 2016 02:26:09 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:33655 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbcAKH0H (ORCPT ); Mon, 11 Jan 2016 02:26:07 -0500 X-AuditID: cbfee61b-f793c6d00000236c-00-56935908edf8 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1452388201-26706-1-git-send-email-jaegeuk@kernel.org> In-reply-to: <1452388201-26706-1-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit Date: Mon, 11 Jan 2016 15:25:11 +0800 Message-id: <003601d14c41$4f884190$ee98c4b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQHzJGjpvgvfFYG4rZX0RIAWKMMCcZ6yN+cQ Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t9jAV2OyMlhBp1L+CyerJ/FbHFpkbvF nr0nWSwu75rD5sDisWlVJ5vH7gWfmTw+b5ILYI7isklJzcksSy3St0vgynjRMZu14DV/xZT3 y1kbGCfzdjFyckgImEg82X+eCcIWk7hwbz1bFyMXh5DAUkaJDS8/sEM4rxgl3rxazQZSxSag IrG84z9Yh4iAmkTvvilgNrNApsSE/hfsILaQgJPE9SUvWLoYOTg4BZwltk3kAQkLC0RIfP2w lQXEZhFQlbhzagojiM0rYCkx5f9edghbUOLH5HssECO1JNbvPA41Xl5i85q3zBCHKkjsOPua EWS8iICRxI+5bhAl4hIbj9ximcAoNAvJpFlIJs1CMmkWkpYFjCyrGCVSC5ILipPSc43yUsv1 ihNzi0vz0vWS83M3MYKD/5n0DsbDu9wPMQpwMCrx8M7YNSlMiDWxrLgy9xCjBAezkghvK8fk MCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8+y5FhgkJpCeWpGanphakFsFkmTg4pRoYGY7rLwk7 uFBO4M53L5Een5PFm+6EWt4x3/SacSen6RLxJ8oMbEXPrzUdEvx9av60vRwF31NlH528NyUz TGNqmOycMMMPTov6NvDsOhL2MuPerIKamLfX6rls9p61nu+7T7RlUd027elvb0wIr993JdFR mrXxx+J/zlqKnv/bL17ZaXjv3eQn3kosxRmJhlrMRcWJAMfDxzt6AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Sunday, January 10, 2016 9:10 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit > > If there is an error during commit, we should keep the flag in order to > abort it. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index dfaed51..db0b2cb 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp) > return ret; > > if (f2fs_is_atomic_file(inode)) { > - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for cgroup ") to avoid panic in kernel with writeback supported cgroup. We should keep it here. > ret = commit_inmem_pages(inode, false); > if (ret) > goto err_out; > + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); How about setting atomic flag if there occurs an error during committing. Thanks, > } > > ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0); > -- > 2.6.3 > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel