All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	lizhijian@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()
Date: Thu, 20 Oct 2016 10:12:41 +0800	[thread overview]
Message-ID: <00367569-b7b1-18bd-9dd4-5fad4215e879@redhat.com> (raw)
In-Reply-To: <1475208369-13756-1-git-send-email-zhang.zhanghailiang@huawei.com>



On 2016年09月30日 12:06, zhanghailiang wrote:
> find_and_check_chardev() uses 'opts' member of CharDriverState to
> check if the chardev is 'socket' chardev or not, which the opts
> will be NULL if We add the chardev by qmp 'chardev-add' command.
>
> All the related info can be found in 'filename' member of CharDriverState,
> For tcp socket device, it will be like 'disconnected:tcp:9.61.1.8:9004,server'
> or 'tcp:9.61.1.8:9001,server <-> 9.61.1.8:50256', we can simply check it to
> identify if it is a tcp socket char device.
>
> Besides, fix this helper function to return -1 while some errors happen.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

Do we have similar issue in net_vhost_chardev_opts() ?

  parent reply	other threads:[~2016-10-20  2:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30  4:06 [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev() zhanghailiang
2016-10-10  2:52 ` Zhang Chen
2016-10-10  3:13   ` Hailiang Zhang
2016-10-10  3:49     ` Zhang Chen
2016-10-10  6:06       ` Hailiang Zhang
2016-10-20  3:53       ` Jason Wang
2016-10-20  4:53         ` Hailiang Zhang
2016-10-21  2:13           ` Jason Wang
2016-10-20  2:12 ` Jason Wang [this message]
2016-10-20  4:52   ` Hailiang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00367569-b7b1-18bd-9dd4-5fad4215e879@redhat.com \
    --to=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.