All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Adrian Schmutzler" <mail@adrianschmutzler.de>
To: "'Pavel Machek'" <pavel@ucw.cz>, "'Marek Behun'" <marek.behun@nic.cz>
Cc: <linux-leds@vger.kernel.org>
Subject: RE: How to name multiple LEDs of the same type and color
Date: Mon, 21 Sep 2020 11:49:00 +0200	[thread overview]
Message-ID: <003e01d68ffc$6f36c800$4da45800$@adrianschmutzler.de> (raw)
In-Reply-To: <20200921083106.GA13539@ucw.cz>

[-- Attachment #1: Type: text/plain, Size: 2379 bytes --]

Hi,

> -----Original Message-----
> From: Pavel Machek [mailto:pavel@ucw.cz]
> Sent: Montag, 21. September 2020 10:31
> To: Marek Behun <marek.behun@nic.cz>
> Cc: Adrian Schmutzler <mail@adrianschmutzler.de>; linux-
> leds@vger.kernel.org
> Subject: Re: How to name multiple LEDs of the same type and color
> 
> Hi!
> 
> 
> > > My main interest here was/is that I started to evaluate how OpenWrt can
> migrate from LED labels to the "new" color/function syntax and to me the rssi
> leds are a dedicated type that should be supported.
> > > So I fear I won't be helpful for the implementation of RSSI leds in the
> kernel in general.
> 
> Yep, I guess staying with old "label" is the right solution for you for now.
> 
> > > For the three leds vs. set of leds discussion: Note that we are interested
> in (and already do) exposing each LED to the user individually (in user-space
> via sysfs), so the user can redefine the purpose of the LED freely based on
> his/her desire. Therefore, a total abstraction of the set of LEDs as a single
> entity would be detrimental for us here.
> > >
> >
> > This is interesting. How does this work? Better signal => faster
> > blinking?
> 
> I suspect it is "no signal" -> "all LEDs off". "weak signal" -> "one LED on",
> "medium signal" -> "two LEDs on", "string signal" -> "three LEDs on".

Indeed, it's just on/off, no blinking. We essentially mirror the behavior of OEM firmwares in this case.

The signal strength where one LED is active is defined in a config file by defining a range within 1 to 100.

E.g. rssilow (1 < signal < 100), rssimediumlow (25 < signal < 100), rssimediumhigh (50 < signal < 100), rssihigh (75 < signal < 100)

Therefore, the more LEDs you see, the better your RSSI is. Note that LEDs might have different (fixed) colors, i.e. low is red, mediumlow is amber, and the other two are green.

Some vendors do it differently of course and have one LED "position" where the color changes, or LEDs go off again for high RSSI or whatever, but my example should be the most abundant case.

FYI:

Device example: https://dl.ubnt.com/datasheets/picostationm/picom2hp_DS.pdf

OpenWrt rssileds code: https://github.com/openwrt/openwrt/blob/master/package/network/utils/rssileds/src/rssileds.c

Hope this helps.

Best

Adrian

> 
> Best regards,
> 								Pavel
> 

[-- Attachment #2: openpgp-digital-signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]

      reply	other threads:[~2020-09-21  9:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 21:21 How to name multiple LEDs of the same type and color Adrian Schmutzler
2020-09-20  1:17 ` Marek Behun
2020-09-20 11:08 ` Pavel Machek
2020-09-20 23:31   ` Adrian Schmutzler
2020-09-21  1:00     ` Marek Behun
2020-09-21  8:31       ` Pavel Machek
2020-09-21  9:49         ` Adrian Schmutzler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003e01d68ffc$6f36c800$4da45800$@adrianschmutzler.de' \
    --to=mail@adrianschmutzler.de \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.