From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA47C43334 for ; Thu, 2 Jun 2022 02:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233271AbiFBC0o (ORCPT ); Wed, 1 Jun 2022 22:26:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232838AbiFBC0n (ORCPT ); Wed, 1 Jun 2022 22:26:43 -0400 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB0982175 for ; Wed, 1 Jun 2022 19:26:41 -0700 (PDT) Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220602022639epoutp0170f96812e20bb0bb8d1cc5da983c9c71~0rKeuwCGe2856828568epoutp01d for ; Thu, 2 Jun 2022 02:26:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220602022639epoutp0170f96812e20bb0bb8d1cc5da983c9c71~0rKeuwCGe2856828568epoutp01d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654136799; bh=JmNflMHvC0gjq9eUUOznOuoK8xZI/6ykjtQ3IjZvnrE=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=nPo25aeMZ6bLN+NJUn3XKibfOD6+FXIgSASFN9dm2PLEFePiY8xvutIfi09qNpc/u mxgN7buhS5SIXrS6Ww0OGhp66/ulgWJsRxTOkp+DrsQvTpU8sH6YP10W1u64eu5hJQ BLHYbKIuKiR8RhkLhGPjL4bEw3FR0sodaMIMpXs0= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20220602022638epcas2p4329194d41573292952f082b58af8ed0a~0rKeHfIwx0360603606epcas2p4V; Thu, 2 Jun 2022 02:26:38 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.91]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LD8z15l3mz4x9Q9; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 03.A5.09694.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69~0rKdCmFpP1104911049epcas2p1J; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220602022637epsmtrp19edc6851557d51352f081b6201d52c5b~0rKdB0k0y0179701797epsmtrp1V; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) X-AuditID: b6c32a48-495ff700000025de-af-62981fdd793f Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 10.4B.11276.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epsmtip1e156e56ad5f1fd60d86c434b9a576e57~0rKc0OSmd0551205512epsmtip1L; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy Date: Thu, 2 Jun 2022 11:26:37 +0900 Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFkEPmYnHf0xjkGXTTWfn5L9kzmHgKG74n8AmlcE0cBsL5TUq3vJLyA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGJsWRmVeSWpSXmKPExsWy7bCmme5d+RlJBgtm6Fk8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxR2TYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QEcpKZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVUgtScgrMC/SKE3OL S/PS9fJSS6wMDQyMTIEKE7Iz7n39w16wj7Viz4VNjA2M61m6GDk5JARMJC4/XMPcxcjFISSw g1Hi261zTBDOJ0aJqZ8fsUI43xglnnV/ZYNp2f3tHVTLXkaJXR86WSCcF4wSF7Z1MoJUsQno S7zs2AbWLiIwn0niaedVJpAEs0C2xKvWRexdjBwcnAJ2Ek1r4kDCwgKuEk/vXQDrZRFQkZhz djEziM0rYCnxcMJbVghbUOLkzCcsEGO0JZYtfM0McZGCxM+ny8BqRATcJJYencEIUSMiMbuz DexSCYG1HBJPZ02DanCRWNd/mx3CFpZ4dXwLlC0l8bK/Dcoullg66xMTRHMDo8Tlbb+g/jeW mPWsnRHkAWYBTYn1u/RBTAkBZYkjt6Bu45PoOPyXHSLMK9HRJgTRqC5xYPt0aLjLSnTP+cw6 gVFpFpLPZiH5bBaSD2Yh7FrAyLKKUSy1oDg3PbXYqMAEHtvJ+bmbGMEJVstjB+Pstx/0DjEy cTAeYpTgYFYS4S3ZNTVJiDclsbIqtSg/vqg0J7X4EKMpMKwnMkuJJucDU3xeSbyhiaWBiZmZ obmRqYG5kjivV8qGRCGB9MSS1OzU1ILUIpg+Jg5OqQamA4uMBc8w2UXM/5deYS4T2PPvQJ0v 6/3TL/vfX9d4w+q6O+y4YLfPibVKZgc51LbVP8/ZV9rcVHnurDmr2z3+PTl5jt/e6eRsrNq1 ZfvhS9Hvk41jBEMzuWXYN1dlpFiuOHBASFh/AqeDxyGFF//WLUnddtpb+h5nt/u2c2vNHdQc tto3LluoeWnFLfUsO6sinQPSE75Z9tosE1DW2nHsTIrJQ59bT0SnFve/+f3a7TpzRhx78oUl /u+UV098L+e1XH3dZKdq1y8vO1vmsU2JCjxz+GS5k9QSjglGobYFwpVXv187E73Wb5+I9adI tyLllQlmdfWn2Jp2e9o8l81z2l01p6LTdpKFj/SnBbeUWIozEg21mIuKEwGoWHrkOQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWy7bCSnO5d+RlJBl8uSVg8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxRXDYpqTmZZalF+nYJXBkfFq1iL9jJWjF95TX2BsYVLF2MnBwS AiYSu7+9Y+5i5OIQEtjNKLHo9ytmiISsxLN3O9ghbGGJ+y1HWEFsIYFnjBKbD4qC2GwC+hIv O7axgjSLCCxmkug/cZYNJMEskCvx4+0XdoiGr4wSR1badDFycHAK2Ek0rYkDCQsLuEo8vXeB EcRmEVCRmHN2MdheXgFLiYcT3rJC2IISJ2c+YYEYqS3x9OZTOHvZwtdQdypI/Hy6DKxeRMBN YunRGYwQNSISszvbmCcwCs9CMmoWklGzkIyahaRlASPLKkbJ1ILi3PTcYsMCw7zUcr3ixNzi 0rx0veT83E2M4EjT0tzBuH3VB71DjEwcjIcYJTiYlUR4S3ZNTRLiTUmsrEotyo8vKs1JLT7E KM3BoiTOe6HrZLyQQHpiSWp2ampBahFMlomDU6qB6aTkUcm8ukt39vMU70juOTjXtnr2nymb nK59tD7CoR5eKXPweGOg0o+Kjin/JaWFDup/kP2bfEK9asOqnSlqeZlrumbHywSG6d+boCAk MvGJ11YR3YrEw1KmFtwWXzdPkCz19vGJjmvvfPs/6/XGyaF3cthbWvPu/H18nJ3l8rT68Msb Qpcueu3twSZ57Enu3wUB+UxzmU8tM+c7NvfDis9qc6w5u2Y3SngZH9wsfe+okPXBlb+2ddxo v6+9XXnlsf5vV5ad9N9w7rCB9C1Gxhm/5sp6Bs9xKudYvVA53YyXM7pFtPNYabL15IyTB/sD /+yaM2+JWvSVx51qzw1THU6d0J6UWXLj2Mb+pfmrZimxFGckGmoxFxUnAgAl1zZHIwMAAA== X-CMS-MailID: 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220531121922epcas2p3c37a39cd28f56326c4f3980ac76f3b5c References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-3-chanho61.park@samsung.com> <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > + u32 isol_offset; > > int err =3D 0; > > > > match =3D of_match_node(samsung_ufs_phy_match, dev->of_node); =40=40 > > -328,7 +329,11 =40=40 static int samsung_ufs_phy_probe(struct > platform_device *pdev) > > phy->dev =3D dev; > > phy->drvdata =3D drvdata; > > phy->cfg =3D (struct samsung_ufs_phy_cfg **)drvdata->cfg; > > - phy->isol =3D &drvdata->isol; > > + phy->isol =3D (struct pmu_isol *)&drvdata->isol; >=20 > No casts are needed for proper code. If you need it - code is not proper. To change a value of phy->isol, I need to allocate its own isol data and co= pying whole data from drvdata instead of using drvdata->isol pointer. Best Regards, Chanho Park From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67FDFC433EF for ; Thu, 2 Jun 2022 02:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2CQ/IvPa3kONlLSAqXG26h7GlUTIUOeeqGxhtHXfNSk=; b=ytIXPRnPqqcKXp hOAZYJR95bNZEVCn+mWyCUJPGecN3LlypEpXgIU1FnIu8ZhzKShoL6HRqEZUapeZC2UacS+T6YHBL UXJj/uHJcAHjUJzoBlCLoO6pIqagZjypOoFiZeBem7GHWbZSMusmjASzDeDwSAthB5js37oRNdw12 foXWufFV0NVMtJxPT2DNZq5eR5WLzAhNRmGTBEJJyEJ+cEue2JzrFVMWak4HFfgAH+zg1q0C21AtO 7CDKnYyhkncHa3GIMmBfnLZo693YiWcz98LjRz/PdTxiAxuTYUE1y44jprptxPEyTU9A6UZ2IdC4C oo6ppJSnMoV/9NrL0Zrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwaY6-0018DN-PH; Thu, 02 Jun 2022 02:26:58 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwaXu-0018A0-B5 for linux-phy@lists.infradead.org; Thu, 02 Jun 2022 02:26:48 +0000 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220602022639epoutp01d239e17eb735243f55a49b513d958fdc~0rKeu9p5K2916129161epoutp01M for ; Thu, 2 Jun 2022 02:26:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220602022639epoutp01d239e17eb735243f55a49b513d958fdc~0rKeu9p5K2916129161epoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654136799; bh=JmNflMHvC0gjq9eUUOznOuoK8xZI/6ykjtQ3IjZvnrE=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=nPo25aeMZ6bLN+NJUn3XKibfOD6+FXIgSASFN9dm2PLEFePiY8xvutIfi09qNpc/u mxgN7buhS5SIXrS6Ww0OGhp66/ulgWJsRxTOkp+DrsQvTpU8sH6YP10W1u64eu5hJQ BLHYbKIuKiR8RhkLhGPjL4bEw3FR0sodaMIMpXs0= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20220602022638epcas2p4329194d41573292952f082b58af8ed0a~0rKeHfIwx0360603606epcas2p4V; Thu, 2 Jun 2022 02:26:38 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.91]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LD8z15l3mz4x9Q9; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 03.A5.09694.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69~0rKdCmFpP1104911049epcas2p1J; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220602022637epsmtrp19edc6851557d51352f081b6201d52c5b~0rKdB0k0y0179701797epsmtrp1V; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) X-AuditID: b6c32a48-495ff700000025de-af-62981fdd793f Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 10.4B.11276.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epsmtip1e156e56ad5f1fd60d86c434b9a576e57~0rKc0OSmd0551205512epsmtip1L; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy Date: Thu, 2 Jun 2022 11:26:37 +0900 Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFkEPmYnHf0xjkGXTTWfn5L9kzmHgKG74n8AmlcE0cBsL5TUq3vJLyA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGJsWRmVeSWpSXmKPExsWy7bCmme5d+RlJBgtm6Fk8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxR2TYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QEcpKZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVUgtScgrMC/SKE3OL S/PS9fJSS6wMDQyMTIEKE7Iz7n39w16wj7Viz4VNjA2M61m6GDk5JARMJC4/XMPcxcjFISSw g1Hi261zTBDOJ0aJqZ8fsUI43xglnnV/ZYNp2f3tHVTLXkaJXR86WSCcF4wSF7Z1MoJUsQno S7zs2AbWLiIwn0niaedVJpAEs0C2xKvWRexdjBwcnAJ2Ek1r4kDCwgKuEk/vXQDrZRFQkZhz djEziM0rYCnxcMJbVghbUOLkzCcsEGO0JZYtfM0McZGCxM+ny8BqRATcJJYencEIUSMiMbuz DexSCYG1HBJPZ02DanCRWNd/mx3CFpZ4dXwLlC0l8bK/Dcoullg66xMTRHMDo8Tlbb+g/jeW mPWsnRHkAWYBTYn1u/RBTAkBZYkjt6Bu45PoOPyXHSLMK9HRJgTRqC5xYPt0aLjLSnTP+cw6 gVFpFpLPZiH5bBaSD2Yh7FrAyLKKUSy1oDg3PbXYqMAEHtvJ+bmbGMEJVstjB+Pstx/0DjEy cTAeYpTgYFYS4S3ZNTVJiDclsbIqtSg/vqg0J7X4EKMpMKwnMkuJJucDU3xeSbyhiaWBiZmZ obmRqYG5kjivV8qGRCGB9MSS1OzU1ILUIpg+Jg5OqQamA4uMBc8w2UXM/5deYS4T2PPvQJ0v 6/3TL/vfX9d4w+q6O+y4YLfPibVKZgc51LbVP8/ZV9rcVHnurDmr2z3+PTl5jt/e6eRsrNq1 ZfvhS9Hvk41jBEMzuWXYN1dlpFiuOHBASFh/AqeDxyGFF//WLUnddtpb+h5nt/u2c2vNHdQc tto3LluoeWnFLfUsO6sinQPSE75Z9tosE1DW2nHsTIrJQ59bT0SnFve/+f3a7TpzRhx78oUl /u+UV098L+e1XH3dZKdq1y8vO1vmsU2JCjxz+GS5k9QSjglGobYFwpVXv187E73Wb5+I9adI tyLllQlmdfWn2Jp2e9o8l81z2l01p6LTdpKFj/SnBbeUWIozEg21mIuKEwGoWHrkOQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWy7bCSnO5d+RlJBl8uSVg8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxRXDYpqTmZZalF+nYJXBkfFq1iL9jJWjF95TX2BsYVLF2MnBwS AiYSu7+9Y+5i5OIQEtjNKLHo9ytmiISsxLN3O9ghbGGJ+y1HWEFsIYFnjBKbD4qC2GwC+hIv O7axgjSLCCxmkug/cZYNJMEskCvx4+0XdoiGr4wSR1badDFycHAK2Ek0rYkDCQsLuEo8vXeB EcRmEVCRmHN2MdheXgFLiYcT3rJC2IISJ2c+YYEYqS3x9OZTOHvZwtdQdypI/Hy6DKxeRMBN YunRGYwQNSISszvbmCcwCs9CMmoWklGzkIyahaRlASPLKkbJ1ILi3PTcYsMCw7zUcr3ixNzi 0rx0veT83E2M4EjT0tzBuH3VB71DjEwcjIcYJTiYlUR4S3ZNTRLiTUmsrEotyo8vKs1JLT7E KM3BoiTOe6HrZLyQQHpiSWp2ampBahFMlomDU6qB6aTkUcm8ukt39vMU70juOTjXtnr2nymb nK59tD7CoR5eKXPweGOg0o+Kjin/JaWFDup/kP2bfEK9asOqnSlqeZlrumbHywSG6d+boCAk MvGJ11YR3YrEw1KmFtwWXzdPkCz19vGJjmvvfPs/6/XGyaF3cthbWvPu/H18nJ3l8rT68Msb Qpcueu3twSZ57Enu3wUB+UxzmU8tM+c7NvfDis9qc6w5u2Y3SngZH9wsfe+okPXBlb+2ddxo v6+9XXnlsf5vV5ad9N9w7rCB9C1Gxhm/5sp6Bs9xKudYvVA53YyXM7pFtPNYabL15IyTB/sD /+yaM2+JWvSVx51qzw1THU6d0J6UWXLj2Mb+pfmrZimxFGckGmoxFxUnAgAl1zZHIwMAAA== X-CMS-MailID: 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220531121922epcas2p3c37a39cd28f56326c4f3980ac76f3b5c References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-3-chanho61.park@samsung.com> <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_192646_809493_D16CC053 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > > + u32 isol_offset; > > int err = 0; > > > > match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@ > > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct > platform_device *pdev) > > phy->dev = dev; > > phy->drvdata = drvdata; > > phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg; > > - phy->isol = &drvdata->isol; > > + phy->isol = (struct pmu_isol *)&drvdata->isol; > > No casts are needed for proper code. If you need it - code is not proper. To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer. Best Regards, Chanho Park -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41662C43334 for ; Thu, 2 Jun 2022 02:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Im0kgd9SDK2zmJGhry2CzEzdDakQlPhxYY35nj8TAYU=; b=e6b/sZ6f5E7vJK Hs33N7PVA9qApplWh0O+Fu+OfqoH30UB5tXglZPNR/TNJ4wS1IJlYVnceLzIzPPR84zkg8tLGEyQs /yafDV8WcynOkK68x8/Ha743wI6pn5s5QBXnvL7MhyvOkJci/707A67gcVB5KDvQrA5cf6Lu3QQpD HKh4i/6kFHiOwNNKDOf+eWI8emExfk7OWSkxYwtPRsH10YNJiYW+6zuN19Yg2a3CTVNIDmpOtuPNj VYk7savWzeblJwFXK6bmmOlHnyqMIz5tm172BQ2qIZvzf9Uhz/klcpnn0S292JdxwzsAYGJrl1xQ1 qVbIOZt915ZbCY+BWBug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwaXy-0018BX-6N; Thu, 02 Jun 2022 02:26:50 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwaXt-00189X-Vm for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 02:26:47 +0000 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220602022639epoutp0264c45493aefc671b2a2512c4ba054bce~0rKekTDjQ1639116391epoutp024 for ; Thu, 2 Jun 2022 02:26:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220602022639epoutp0264c45493aefc671b2a2512c4ba054bce~0rKekTDjQ1639116391epoutp024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654136799; bh=JmNflMHvC0gjq9eUUOznOuoK8xZI/6ykjtQ3IjZvnrE=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=nPo25aeMZ6bLN+NJUn3XKibfOD6+FXIgSASFN9dm2PLEFePiY8xvutIfi09qNpc/u mxgN7buhS5SIXrS6Ww0OGhp66/ulgWJsRxTOkp+DrsQvTpU8sH6YP10W1u64eu5hJQ BLHYbKIuKiR8RhkLhGPjL4bEw3FR0sodaMIMpXs0= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20220602022638epcas2p4329194d41573292952f082b58af8ed0a~0rKeHfIwx0360603606epcas2p4V; Thu, 2 Jun 2022 02:26:38 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.91]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LD8z15l3mz4x9Q9; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 03.A5.09694.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69~0rKdCmFpP1104911049epcas2p1J; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220602022637epsmtrp19edc6851557d51352f081b6201d52c5b~0rKdB0k0y0179701797epsmtrp1V; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) X-AuditID: b6c32a48-495ff700000025de-af-62981fdd793f Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 10.4B.11276.DDF18926; Thu, 2 Jun 2022 11:26:37 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602022637epsmtip1e156e56ad5f1fd60d86c434b9a576e57~0rKc0OSmd0551205512epsmtip1L; Thu, 2 Jun 2022 02:26:37 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , In-Reply-To: <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> Subject: RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy Date: Thu, 2 Jun 2022 11:26:37 +0900 Message-ID: <004501d87628$2f65a6b0$8e30f410$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFkEPmYnHf0xjkGXTTWfn5L9kzmHgKG74n8AmlcE0cBsL5TUq3vJLyA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGJsWRmVeSWpSXmKPExsWy7bCmme5d+RlJBgtm6Fk8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxR2TYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QEcpKZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVUgtScgrMC/SKE3OL S/PS9fJSS6wMDQyMTIEKE7Iz7n39w16wj7Viz4VNjA2M61m6GDk5JARMJC4/XMPcxcjFISSw g1Hi261zTBDOJ0aJqZ8fsUI43xglnnV/ZYNp2f3tHVTLXkaJXR86WSCcF4wSF7Z1MoJUsQno S7zs2AbWLiIwn0niaedVJpAEs0C2xKvWRexdjBwcnAJ2Ek1r4kDCwgKuEk/vXQDrZRFQkZhz djEziM0rYCnxcMJbVghbUOLkzCcsEGO0JZYtfM0McZGCxM+ny8BqRATcJJYencEIUSMiMbuz DexSCYG1HBJPZ02DanCRWNd/mx3CFpZ4dXwLlC0l8bK/Dcoullg66xMTRHMDo8Tlbb+g/jeW mPWsnRHkAWYBTYn1u/RBTAkBZYkjt6Bu45PoOPyXHSLMK9HRJgTRqC5xYPt0aLjLSnTP+cw6 gVFpFpLPZiH5bBaSD2Yh7FrAyLKKUSy1oDg3PbXYqMAEHtvJ+bmbGMEJVstjB+Pstx/0DjEy cTAeYpTgYFYS4S3ZNTVJiDclsbIqtSg/vqg0J7X4EKMpMKwnMkuJJucDU3xeSbyhiaWBiZmZ obmRqYG5kjivV8qGRCGB9MSS1OzU1ILUIpg+Jg5OqQamA4uMBc8w2UXM/5deYS4T2PPvQJ0v 6/3TL/vfX9d4w+q6O+y4YLfPibVKZgc51LbVP8/ZV9rcVHnurDmr2z3+PTl5jt/e6eRsrNq1 ZfvhS9Hvk41jBEMzuWXYN1dlpFiuOHBASFh/AqeDxyGFF//WLUnddtpb+h5nt/u2c2vNHdQc tto3LluoeWnFLfUsO6sinQPSE75Z9tosE1DW2nHsTIrJQ59bT0SnFve/+f3a7TpzRhx78oUl /u+UV098L+e1XH3dZKdq1y8vO1vmsU2JCjxz+GS5k9QSjglGobYFwpVXv187E73Wb5+I9adI tyLllQlmdfWn2Jp2e9o8l81z2l01p6LTdpKFj/SnBbeUWIozEg21mIuKEwGoWHrkOQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWy7bCSnO5d+RlJBl8uSVg8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FonXvEXaLnXdOMDtwemxa1cnmcefaHjaPzUvq Pfq2rGL0OH5jO5PH501yAWxRXDYpqTmZZalF+nYJXBkfFq1iL9jJWjF95TX2BsYVLF2MnBwS AiYSu7+9Y+5i5OIQEtjNKLHo9ytmiISsxLN3O9ghbGGJ+y1HWEFsIYFnjBKbD4qC2GwC+hIv O7axgjSLCCxmkug/cZYNJMEskCvx4+0XdoiGr4wSR1badDFycHAK2Ek0rYkDCQsLuEo8vXeB EcRmEVCRmHN2MdheXgFLiYcT3rJC2IISJ2c+YYEYqS3x9OZTOHvZwtdQdypI/Hy6DKxeRMBN YunRGYwQNSISszvbmCcwCs9CMmoWklGzkIyahaRlASPLKkbJ1ILi3PTcYsMCw7zUcr3ixNzi 0rx0veT83E2M4EjT0tzBuH3VB71DjEwcjIcYJTiYlUR4S3ZNTRLiTUmsrEotyo8vKs1JLT7E KM3BoiTOe6HrZLyQQHpiSWp2ampBahFMlomDU6qB6aTkUcm8ukt39vMU70juOTjXtnr2nymb nK59tD7CoR5eKXPweGOg0o+Kjin/JaWFDup/kP2bfEK9asOqnSlqeZlrumbHywSG6d+boCAk MvGJ11YR3YrEw1KmFtwWXzdPkCz19vGJjmvvfPs/6/XGyaF3cthbWvPu/H18nJ3l8rT68Msb Qpcueu3twSZ57Enu3wUB+UxzmU8tM+c7NvfDis9qc6w5u2Y3SngZH9wsfe+okPXBlb+2ddxo v6+9XXnlsf5vV5ad9N9w7rCB9C1Gxhm/5sp6Bs9xKudYvVA53YyXM7pFtPNYabL15IyTB/sD /+yaM2+JWvSVx51qzw1THU6d0J6UWXLj2Mb+pfmrZimxFGckGmoxFxUnAgAl1zZHIwMAAA== X-CMS-MailID: 20220602022637epcas2p14b5e3f69156a217bea556ce44a78ae69 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220531121922epcas2p3c37a39cd28f56326c4f3980ac76f3b5c References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-3-chanho61.park@samsung.com> <45ef694a-472c-23d8-1514-f57efe5a35a1@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_192646_414125_50ABD919 X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > + u32 isol_offset; > > int err = 0; > > > > match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@ > > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct > platform_device *pdev) > > phy->dev = dev; > > phy->drvdata = drvdata; > > phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg; > > - phy->isol = &drvdata->isol; > > + phy->isol = (struct pmu_isol *)&drvdata->isol; > > No casts are needed for proper code. If you need it - code is not proper. To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer. Best Regards, Chanho Park _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel