From: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>
Cc: gareth.yu@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off
Date: Mon, 18 Mar 2024 15:58:31 +0800 [thread overview]
Message-ID: <004a0b4f-a619-4989-901f-251de3de4af1@huaqin.corp-partner.google.com> (raw)
In-Reply-To: <ZfQqyLJBAAuNLKZ2@intel.com>
this case have been there so many years, it's time to fix it if
possible. And user-space software may improved by themselves in we
didn't realize place.
even if not, for the proof user-space setting 0, it's better to change to
if (level < min || level == 0 )
level =max;
Intel default FSP will set the default min is 2% (6/255). if someone
missed the setting, it will be keep the default and level.min will be
larger than 0.
if someone changed the default min in VBT or coreboot, the user-space
lowest level set as 0, still can go though to this logic.
whatever, we think this one should correct back, otherwise it will keep
occurring in each new kernel release on all Intel device, this is not
very friendly to all developers.
and the only fix way is hack patch to remove "level=max".
On 3/15/24 19:02, Ville Syrjälä wrote:
> On Wed, Mar 06, 2024 at 12:19:42PM +0200, Jani Nikula wrote:
>> On Wed, 06 Mar 2024, gareth.yu@intel.com wrote:
>>> From: Gareth Yu <gareth.yu@intel.com>
>>>
>>> Turn on the panel from zero brightness of the last state, the panel was set
>>> a maximum PWM in the flow. Once the panel initialization is completed, the
>>> backlight is restored to zero brightness. There is a flckering generated.
>> Please be more precise in describing what exactly happens and
>> when. Driver probe? Modeset? What restores backlight to zero brightness?
>>
>> Better yet, please file a bug at fdo gitlab, attach full dmesg with
>> debugs, etc.
>>
>> Before we had the concept of minimum brightness, the minimum was always
>> 0. And the check was:
>>
>> if (level == 0)
>> level = max;
>>
>> Historically, the point was, if you're enabling the display and
>> backlight, you don't want it to be at 0 brightness, because for most
>> displays that means a black screen.
> I think that hack was originally added becaue some silly
> userspace thingy was setting the backlight level to 0 on
> suspend/etc. and then forgetting to restore it back to a
> sane value afterwards. Dunno if that nonsense behaviour
> still persists to this day.
>
next prev parent reply other threads:[~2024-03-18 12:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 3:13 [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-06 8:32 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-03-06 8:48 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-06 10:19 ` [PATCH] " Jani Nikula
2024-03-15 11:02 ` Ville Syrjälä
2024-03-18 2:20 ` Yu, Gareth
2024-03-18 7:58 ` Dolan Liu [this message]
2024-03-18 13:45 ` Jani Nikula
2024-03-19 2:04 ` Yu, Gareth
2024-03-12 3:17 ` gareth.yu
2024-03-12 4:14 ` ✗ Fi.CI.BAT: failure for drm/i915/display: Fixed a screen flickering when turning on display from off (rev2) Patchwork
2024-03-14 4:20 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev3) Patchwork
2024-03-14 14:47 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-15 10:01 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-15 12:34 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev4) Patchwork
2024-03-16 14:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-18 2:15 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-18 2:50 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev5) Patchwork
2024-03-18 4:37 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-20 16:27 ` ✓ Fi.CI.IGT: success " Patchwork
2024-03-20 16:56 ` Patchwork
2024-03-21 4:53 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-26 13:11 ` Jani Nikula
2024-03-21 5:30 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev6) Patchwork
2024-03-22 1:24 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=004a0b4f-a619-4989-901f-251de3de4af1@huaqin.corp-partner.google.com \
--to=liuyong5@huaqin.corp-partner.google.com \
--cc=gareth.yu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.