All of lore.kernel.org
 help / color / mirror / Atom feed
From: Devin Nakamura <devin122@gmail.com>
To: qemu-devel@nongnu.org
Cc: Devin Nakamura <devin122@gmail.com>
Subject: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug
Date: Mon, 11 Jul 2011 01:25:13 -0400	[thread overview]
Message-ID: <004f3f00feb28f2d8f9f7c837e06a8fd414dfd73.1310361865.git.devin122@gmail.com> (raw)
In-Reply-To: <d93a44de6e1bef9ecb98509ee7ab2bf3e06c8d44.1310361865.git.devin122@gmail.com>
In-Reply-To: <d93a44de6e1bef9ecb98509ee7ab2bf3e06c8d44.1310361865.git.devin122@gmail.com>

Fix a bug caused by lack of braces in if statement

Lack of braces means that if(count & 0x1ff) is never reached

Conflicts:

	qemu-io.c

Signed-off-by: Devin Nakamura <devin122@gmail.com>
---
 qemu-io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index e484f40..85cfe27 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -449,7 +449,7 @@ static int read_f(int argc, char **argv)
         return 0;
     }
 
-    if (!pflag)
+    if (!pflag) {
         if (offset & 0x1ff) {
             printf("offset %" PRId64 " is not sector aligned\n",
                    offset);
-- 
1.7.6.rc1

  reply	other threads:[~2011-07-11  5:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  5:25 [Qemu-devel] [PATCH 1/2] qemu-io: Fix formatting Devin Nakamura
2011-07-11  5:25 ` Devin Nakamura [this message]
2011-07-11  9:47   ` [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug Stefan Hajnoczi
2011-07-11 13:18     ` Kevin Wolf
2011-07-11 13:18       ` Stefan Hajnoczi
2011-07-11 15:20         ` [Qemu-devel] [PATCH v3 " Devin Nakamura
2011-07-12 12:59           ` Kevin Wolf
2011-07-11 13:21 ` [Qemu-devel] [PATCH 1/2] qemu-io: Fix formatting Kevin Wolf
2011-07-11 15:22   ` [Qemu-devel] [PATCH v3 " Devin Nakamura
  -- strict thread matches above, loose matches on Subject: below --
2011-06-11  3:29 [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug Devin Nakamura
2011-06-14  8:42 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=004f3f00feb28f2d8f9f7c837e06a8fd414dfd73.1310361865.git.devin122@gmail.com \
    --to=devin122@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.