From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB024C433FE for ; Tue, 1 Mar 2022 09:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233364AbiCAJCD (ORCPT ); Tue, 1 Mar 2022 04:02:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiCAJB7 (ORCPT ); Tue, 1 Mar 2022 04:01:59 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C25989CF8; Tue, 1 Mar 2022 01:01:18 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 17:01:15 +0800 Message-ID: <0054cf2f-f09d-5b01-d6ca-0dc877a757c3@amlogic.com> Date: Tue, 1 Mar 2022 17:01:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Jerome Brunet , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Neil Armstrong , Kevin Hilman , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <1j8rtvxnkv.fsf@starbuckisacylon.baylibre.com> <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerome, On 2022/3/1 16:36, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Tue 01 Mar 2022 at 13:54, Yu Tu wrote: > >> Hi Jerome, >> >> On 2022/2/28 18:59, Jerome Brunet wrote: >>> [ EXTERNAL EMAIL ] >>> >>> On Fri 25 Feb 2022 at 15:39, Yu Tu wrote: >>> >>>> Using the common Clock code to describe the UART baud rate >>>> clock makes it easier for the UART driver to be compatible >>>> with the baud rate requirements of the UART IP on different >>>> meson chips. Add Meson S4 SoC compatible. >>>> >>>> The test method: >>>> Start the console and run the following commands in turn: >>>> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >>>> >>>> Since most SoCs are too old, I was able to find all the platforms myself >>>> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >>>> G12A and S4. >>> GXL based board are still very common an easy to come by. >>> I'm quite surprised that you are unable to test on this SoC family >> The fact of the matter is that the S4 is our end-2020 chip, the G12A is >> five years old, and the GXL is seven years old. If you must ask for a >> test, I will report this problem to the leadership to coordinate resources. > > The age of the SoC is irrelevant. SoCs don't get deprecated based on age > in mainline. It is not just GXL, same goes for meson8. > > These SoCs are actively used. Boards with these SoCs are still sold and > easily available. See the VIM1 or the Libretech boards. > > Breaking things for the the users of these SoCs is not acceptable. > So yes, looking at your series, I strongly recommend you do more tests. > You have a point there. Let's go back to the root of the problem. I aim to increase S4. The S4 uses 12MHZ to calculate baud. That's all. Change it to CCF as you suggested. The changes are so large that you ask to test all the chips. I also mentioned last time that using CCF would lead to a longer drive probe time and affect the board startup time. If this problem is not solved, can we reject the way you suggest using CCF? >>> >>>> >>>> Yu Tu (6): >>>> tty: serial: meson: Move request the register region to probe >>>> tty: serial: meson: Use devm_ioremap_resource to get register mapped >>>> memory >>>> tty: serial: meson: Describes the calculation of the UART baud rate >>>> clock using a clock frame >>>> tty: serial: meson: Make some bit of the REG5 register writable >>>> tty: serial: meson: The system stuck when you run the stty command on >>>> the console to change the baud rate >>>> tty: serial: meson: Added S4 SOC compatibility >>>> >>>> V6 -> V7: To solve the system stuck when you run the stty command on >>>> the console to change the baud rate. >>>> V5 -> V6: Change error format as discussed in the email. >>>> V4 -> V5: Change error format. >>>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >>>> in the email. >>>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change >>>> the DTS before it can be deleted >>>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as >>>> discussed in the email >>>> >>>> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >>>> >>>> drivers/tty/serial/meson_uart.c | 221 ++++++++++++++++++++++---------- >>>> 1 file changed, 154 insertions(+), 67 deletions(-) >>>> >>>> >>>> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1B3BC433F5 for ; Tue, 1 Mar 2022 09:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ESWOP4vlQQD/54aQe0Tx5LBGX3XoAEOaI1fIDsnnAGY=; b=KWB7Coy/OjEGpk p1OREqGI6T0tIJODlEMsvf0ffyh3Zsg9v413pjmPcEmBPZbRc2SvTOsAoh5gH/8VEOn5S/B5gH2Og kSmUVN/Bqm4hi3holzizF5KZ0xzSvCNxsKCFPiSIJLYkwnmPXiyLKSOOXAYEKxu71m4HUaviCKZ/P A4/czpKwyVKC4XPJ1Ck9YUM9ci0ZWVOSXdL5npMOqO8ObXp+0hp184uT6jZ6uf8qkP6s/gQKgYc6X bXQiwu6dY4ilY0jtNAZxdKEPAuO0TbVReS49uo/4jqiwXNPxqQjP2LOvSof6IEqxnNXbmLgzLQ5t5 oMTByrIBi+YeFAeoHUNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyNz-00FkJY-01; Tue, 01 Mar 2022 09:01:35 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyNk-00FkFu-1z; Tue, 01 Mar 2022 09:01:21 +0000 Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 17:01:15 +0800 Message-ID: <0054cf2f-f09d-5b01-d6ca-0dc877a757c3@amlogic.com> Date: Tue, 1 Mar 2022 17:01:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Jerome Brunet , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Neil Armstrong , Kevin Hilman , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <1j8rtvxnkv.fsf@starbuckisacylon.baylibre.com> <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_010120_143084_3DBD90F3 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Jerome, On 2022/3/1 16:36, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Tue 01 Mar 2022 at 13:54, Yu Tu wrote: > >> Hi Jerome, >> >> On 2022/2/28 18:59, Jerome Brunet wrote: >>> [ EXTERNAL EMAIL ] >>> >>> On Fri 25 Feb 2022 at 15:39, Yu Tu wrote: >>> >>>> Using the common Clock code to describe the UART baud rate >>>> clock makes it easier for the UART driver to be compatible >>>> with the baud rate requirements of the UART IP on different >>>> meson chips. Add Meson S4 SoC compatible. >>>> >>>> The test method: >>>> Start the console and run the following commands in turn: >>>> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >>>> >>>> Since most SoCs are too old, I was able to find all the platforms myself >>>> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >>>> G12A and S4. >>> GXL based board are still very common an easy to come by. >>> I'm quite surprised that you are unable to test on this SoC family >> The fact of the matter is that the S4 is our end-2020 chip, the G12A is >> five years old, and the GXL is seven years old. If you must ask for a >> test, I will report this problem to the leadership to coordinate resources. > > The age of the SoC is irrelevant. SoCs don't get deprecated based on age > in mainline. It is not just GXL, same goes for meson8. > > These SoCs are actively used. Boards with these SoCs are still sold and > easily available. See the VIM1 or the Libretech boards. > > Breaking things for the the users of these SoCs is not acceptable. > So yes, looking at your series, I strongly recommend you do more tests. > You have a point there. Let's go back to the root of the problem. I aim to increase S4. The S4 uses 12MHZ to calculate baud. That's all. Change it to CCF as you suggested. The changes are so large that you ask to test all the chips. I also mentioned last time that using CCF would lead to a longer drive probe time and affect the board startup time. If this problem is not solved, can we reject the way you suggest using CCF? >>> >>>> >>>> Yu Tu (6): >>>> tty: serial: meson: Move request the register region to probe >>>> tty: serial: meson: Use devm_ioremap_resource to get register mapped >>>> memory >>>> tty: serial: meson: Describes the calculation of the UART baud rate >>>> clock using a clock frame >>>> tty: serial: meson: Make some bit of the REG5 register writable >>>> tty: serial: meson: The system stuck when you run the stty command on >>>> the console to change the baud rate >>>> tty: serial: meson: Added S4 SOC compatibility >>>> >>>> V6 -> V7: To solve the system stuck when you run the stty command on >>>> the console to change the baud rate. >>>> V5 -> V6: Change error format as discussed in the email. >>>> V4 -> V5: Change error format. >>>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >>>> in the email. >>>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change >>>> the DTS before it can be deleted >>>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as >>>> discussed in the email >>>> >>>> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >>>> >>>> drivers/tty/serial/meson_uart.c | 221 ++++++++++++++++++++++---------- >>>> 1 file changed, 154 insertions(+), 67 deletions(-) >>>> >>>> >>>> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 >>> > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AE17C433F5 for ; Tue, 1 Mar 2022 09:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mL+OMkgzCO/mjIC2bESeZSnKBjF8aBmg9kQe4fRtTtw=; b=fVSxb68bizEVQT ZKwWfuKOKWpaFZ4z36lTQ6Y8EgEUAhGkM/zgdaerw0Myb0hNjwq2eiEZ+ESj3d5iZ1dy9+AJcOKj8 8AFLA5D4DTgu4Ht74lExFcl2mbC/5GEaJcWYOAosnXXRrPLs+lX7BotX4H7EnTIUfGiwnEMsSqcRh 3brH+zYmYisLMrV8gezdbqRAZdiixg/QawvvJLmtZGXb4h26n3gG7yNlSgQsZ+7b+6qY7ssPBstr0 a+hOJr/prrRFlP3Iqw9iZlzGWbDo9pNOr/ZPAKIEWyTFYsrGuP+sgwb1KASEs2W2ypYmZIwvidYlR bDMlOuQ6DpQmlN6W2XGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyNo-00FkH6-Cy; Tue, 01 Mar 2022 09:01:24 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyNk-00FkFu-1z; Tue, 01 Mar 2022 09:01:21 +0000 Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 17:01:15 +0800 Message-ID: <0054cf2f-f09d-5b01-d6ca-0dc877a757c3@amlogic.com> Date: Tue, 1 Mar 2022 17:01:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Jerome Brunet , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Neil Armstrong , Kevin Hilman , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <1j8rtvxnkv.fsf@starbuckisacylon.baylibre.com> <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1jilsyvyz9.fsf@starbuckisacylon.baylibre.com> X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_010120_143084_3DBD90F3 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jerome, On 2022/3/1 16:36, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Tue 01 Mar 2022 at 13:54, Yu Tu wrote: > >> Hi Jerome, >> >> On 2022/2/28 18:59, Jerome Brunet wrote: >>> [ EXTERNAL EMAIL ] >>> >>> On Fri 25 Feb 2022 at 15:39, Yu Tu wrote: >>> >>>> Using the common Clock code to describe the UART baud rate >>>> clock makes it easier for the UART driver to be compatible >>>> with the baud rate requirements of the UART IP on different >>>> meson chips. Add Meson S4 SoC compatible. >>>> >>>> The test method: >>>> Start the console and run the following commands in turn: >>>> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >>>> >>>> Since most SoCs are too old, I was able to find all the platforms myself >>>> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >>>> G12A and S4. >>> GXL based board are still very common an easy to come by. >>> I'm quite surprised that you are unable to test on this SoC family >> The fact of the matter is that the S4 is our end-2020 chip, the G12A is >> five years old, and the GXL is seven years old. If you must ask for a >> test, I will report this problem to the leadership to coordinate resources. > > The age of the SoC is irrelevant. SoCs don't get deprecated based on age > in mainline. It is not just GXL, same goes for meson8. > > These SoCs are actively used. Boards with these SoCs are still sold and > easily available. See the VIM1 or the Libretech boards. > > Breaking things for the the users of these SoCs is not acceptable. > So yes, looking at your series, I strongly recommend you do more tests. > You have a point there. Let's go back to the root of the problem. I aim to increase S4. The S4 uses 12MHZ to calculate baud. That's all. Change it to CCF as you suggested. The changes are so large that you ask to test all the chips. I also mentioned last time that using CCF would lead to a longer drive probe time and affect the board startup time. If this problem is not solved, can we reject the way you suggest using CCF? >>> >>>> >>>> Yu Tu (6): >>>> tty: serial: meson: Move request the register region to probe >>>> tty: serial: meson: Use devm_ioremap_resource to get register mapped >>>> memory >>>> tty: serial: meson: Describes the calculation of the UART baud rate >>>> clock using a clock frame >>>> tty: serial: meson: Make some bit of the REG5 register writable >>>> tty: serial: meson: The system stuck when you run the stty command on >>>> the console to change the baud rate >>>> tty: serial: meson: Added S4 SOC compatibility >>>> >>>> V6 -> V7: To solve the system stuck when you run the stty command on >>>> the console to change the baud rate. >>>> V5 -> V6: Change error format as discussed in the email. >>>> V4 -> V5: Change error format. >>>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >>>> in the email. >>>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change >>>> the DTS before it can be deleted >>>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as >>>> discussed in the email >>>> >>>> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >>>> >>>> drivers/tty/serial/meson_uart.c | 221 ++++++++++++++++++++++---------- >>>> 1 file changed, 154 insertions(+), 67 deletions(-) >>>> >>>> >>>> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 >>> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel