All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Emmanuel Gil Peyrot <linkmauve@jabberfr.org>
Cc: linkmauve@linkmauve.fr, alsa-devel@alsa-project.org,
	patch@alsa-project.org
Subject: Re: [PATCH - hwmixvolume v2 3/7] hwmixvolume: switch to GTK+ 3.0 and GLib 2.0
Date: Wed, 19 Sep 2018 23:14:10 +0900	[thread overview]
Message-ID: <0055564e-5974-6fc1-a614-0e1140473c3f@sakamocchi.jp> (raw)
In-Reply-To: <20180919133627.GA8599@yun.org>

On Sep 19 2018 22:36, Emmanuel Gil Peyrot wrote:
> On Wed, Sep 19, 2018 at 10:22:48PM +0900, Takashi Sakamoto wrote:
>> On Sep 18 2018 22:42, Emmanuel Gil Peyrot wrote:
>>> From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> […]
>>> @@ -174,45 +174,48 @@ class MixerWindow(Gtk.Window):
>>>            self.connect('destroy', lambda w: Gtk.main_quit())
>>>            self.set_title("Hardware Mixer Volumes")
>>> -        vbox = Gtk.VBox()
>>> +        vbox = Gtk.Grid()
>>> +        vbox.set_orientation(Gtk.Orientation.VERTICAL)
>>
>> As long as I know, g-i of Gtk+3 has both of 'Gtk.VBox' and 'Gtk.HBox'.
>> I don't object to this patchset if they satisfy your demand, however
>> from my curiosity would I ask you the reason to use 'Gtk.Grid' instead
>> of them? This patch includes no lines to add rows/colums and to me no
>> requirement to use grid in this point.
> 
> The Gtk.VBox documentation[1] says:
> 
> “Deprecated since version 3.2: You can use Gtk.Box.new() with
> Gtk.Orientation.VERTICAL instead, which is a quick and easy change. But
> the recommendation is to switch to Gtk.Grid, since Gtk.Box is going to
> go away eventually. See Migrating from other containers to GtkGrid.”
> 
> Since no backwards incompatible change can be made in GTK+ 3.x, it is
> still present as of 3.24, but it has been removed in 4.0 and it’d be
> nice to support this one already when it’ll be released. :)

Thanks for your explanation. Indeed, gtk+ community obsoleted
gtk_vbox[1] and gtk_hbox[2] in their v3.89.1 release.

(g-i is a specification for metadata format for API of library.
PyGobject is a Python binding to handle the metadata and library. The
status of public API is decided by the library itself.)

Furthermore, gtk+ community published an instruction to use gtk_grid
instead of gtk_box[3].

Totally, your changes are good enough.

[1] Delete gtkvbox.{c,h} (fe24fcbc) · Commits · GNOME / gtk · GitLab
https://gitlab.gnome.org/GNOME/gtk/commit/fe24fcbc3e71bcf7e222a4106bf6e3f7ec114e28
[2] Remove GtkHBox (fb3d9022) · Commits · GNOME / gtk · GitLab
https://gitlab.gnome.org/GNOME/gtk/commit/fb3d9022ad98049c887cec5aeffd6b73deb043ba
[3] Migrating from other containers to GtkGrid: GTK+ 3 Reference Manual
https://developer.gnome.org/gtk3/stable/gtk-migrating-GtkGrid.html


Thanks

Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2018-09-19 14:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180918134237.8489-1-linkmauve@jabberfr.org>
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 1/7] hwmixvolume: use four spaces instead of one tab for indent Emmanuel Gil Peyrot
2018-09-19  0:54   ` James Cameron
2018-09-20  7:13     ` Takashi Iwai
2018-09-20  8:45       ` James Cameron
2018-09-20  9:20         ` Takashi Iwai
2018-09-20  7:13   ` Takashi Iwai
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 2/7] hwmixvolume: replace PyGTK with gobject-introspection Emmanuel Gil Peyrot
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 3/7] hwmixvolume: switch to GTK+ 3.0 and GLib 2.0 Emmanuel Gil Peyrot
2018-09-19 13:22   ` Takashi Sakamoto
2018-09-19 13:36     ` Emmanuel Gil Peyrot
2018-09-19 14:14       ` Takashi Sakamoto [this message]
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 4/7] hwmixvolume: use a with context to open files Emmanuel Gil Peyrot
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 5/7] hwmixvolume: switch the shebang to python Emmanuel Gil Peyrot
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 6/7] hwmixvolume: add my copyright Emmanuel Gil Peyrot
2018-09-18 13:42 ` [PATCH - hwmixvolume v2 7/7] hwmixvolume: mention the new dependencies in the README Emmanuel Gil Peyrot
2018-09-19 14:15 ` [PATCH - hwmixvolume v2 0/7] Migrate to GTK+ 3.0 and allow python3 Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0055564e-5974-6fc1-a614-0e1140473c3f@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=linkmauve@jabberfr.org \
    --cc=linkmauve@linkmauve.fr \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.