From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Pablo Greco <pgreco@centosproject.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
Date: Mon, 27 Jun 2022 20:43:50 +0000 [thread overview]
Message-ID: <00568db1-359d-338f-247e-f9e16d0cf9f3@nvidia.com> (raw)
In-Reply-To: <20220625121502.9092-1-pgreco@centosproject.org>
On 6/25/22 05:15, Pablo Greco wrote:
> ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
> be the same across drives in one system. Quirk them out so they are
> not marked as "non globally unique" duplicates.
>
Can be written with moving "not" to the 2nd line, if anyone cares :-
ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are not
marked as "non globally unique" duplicates.
> Before:
> [ 2.258919] nvme nvme1: pci function 0000:06:00.0
> [ 2.264898] nvme nvme2: pci function 0000:05:00.0
> [ 2.323235] nvme nvme1: failed to set APST feature (2)
> [ 2.326153] nvme nvme2: failed to set APST feature (2)
> [ 2.333935] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 2.336492] nvme nvme2: allocated 64 MiB host memory buffer.
> [ 2.339611] nvme nvme1: 7/0/0 default/read/poll queues
> [ 2.341805] nvme nvme2: 7/0/0 default/read/poll queues
> [ 2.346114] nvme1n1: p1
> [ 2.347197] nvme nvme2: globally duplicate IDs for nsid 1
> After:
> [ 2.427715] nvme nvme1: pci function 0000:06:00.0
> [ 2.427771] nvme nvme2: pci function 0000:05:00.0
> [ 2.488154] nvme nvme2: failed to set APST feature (2)
> [ 2.489895] nvme nvme1: failed to set APST feature (2)
> [ 2.498773] nvme nvme2: allocated 64 MiB host memory buffer.
> [ 2.500587] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 2.504113] nvme nvme2: 7/0/0 default/read/poll queues
> [ 2.507026] nvme nvme1: 7/0/0 default/read/poll queues
> [ 2.509467] nvme nvme2: Ignoring bogus Namespace Identifiers
> [ 2.512804] nvme nvme1: Ignoring bogus Namespace Identifiers
> [ 2.513698] nvme1n1: p1
>
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> Cc: <stable@vger.kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-06-27 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 12:15 [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G) Pablo Greco
2022-06-25 12:15 ` Pablo Greco
2022-06-27 20:14 ` Keith Busch
2022-06-27 20:43 ` Chaitanya Kulkarni [this message]
2022-06-29 14:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00568db1-359d-338f-247e-f9e16d0cf9f3@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pgreco@centosproject.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.