All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matt Renzelmann" <mjr@cs.wisc.edu>
To: "'Stephen Boyd'" <sboyd@codeaurora.org>
Cc: <davem@davemloft.net>, <ben@simtec.co.uk>,
	<netdev@vger.kernel.org>, "Matt Renzelmann" <mjr@cs.wisc.edu>
Subject: RE: [PATCH] ks8851: Cancel any pending IRQ work
Date: Thu, 12 Apr 2012 15:34:26 -0500	[thread overview]
Message-ID: <005701cd18eb$aaa0ab90$ffe202b0$@cs.wisc.edu> (raw)
In-Reply-To: <4F8738EB.2060806@codeaurora.org>

> 
> Is this actually solving anything? Presumably cancel_work_sync() could
> run and then another spurious interrupt could come in after that
> function returns and we would have the same problem again. We should
> probably free the irq before unregistering the netdev so that
> ks8851_net_stop() would run after the interrupt is no longer registered,
> and the flush_work() in there would finish the last work. But then we
> have a problem where we're enabling the irq in the irq_work callback
> after the irq has been freed. Ugh.
> 
> I also see a potential deadlock in ks8851_net_stop(). ks8851_net_stop()
> holds the ks->lock while calling flush_work() which could deadlock if an
> interrupt comes and schedules an irq_work between the time
> ks8851_net_stop() grabs the mutex and calls flush_work().
> 

I agree on all counts -- the patch is buggy, though it does at least "shrink"
the window of vulnerability.  Frankly, I don't believe I'm qualified to write an
appropriate patch for this driver, at least without spending considerably more
time on it.

FWIW, I found this problem with a new driver-testing tool we've developed called
SymDrive, and my goal is primarily to determine if the bug is real or not.  The
tool is imperfect and we are trying to validate its operation.

That said, if there is an issue here, and we can come up with an appropriate
fix, then I'd be happy to write a patch for it.

  reply	other threads:[~2012-04-12 20:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 16:44 [PATCH] ks8851: Cancel any pending IRQ work mjr
2012-04-12 20:19 ` Stephen Boyd
2012-04-12 20:34   ` Matt Renzelmann [this message]
2012-04-13 18:32     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005701cd18eb$aaa0ab90$ffe202b0$@cs.wisc.edu' \
    --to=mjr@cs.wisc.edu \
    --cc=ben@simtec.co.uk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.