From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Daniel Sangorrin" References: <1509438715-14039-1-git-send-email-daniel.sangorrin@toshiba.co.jp> <1509438715-14039-3-git-send-email-daniel.sangorrin@toshiba.co.jp> In-Reply-To: Date: Wed, 1 Nov 2017 09:28:41 +0900 Message-ID: <005701d352a8$5e4722e0$1ad568a0$@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ja Subject: Re: [Fuego] [PATCH 2/3] cyclictest: modify specs List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "'Bird, Timothy'" , fuego@lists.linuxfoundation.org > -----Original Message----- > From: Bird, Timothy [mailto:Tim.Bird@sony.com] > Sent: Wednesday, November 01, 2017 4:56 AM > To: Daniel Sangorrin; fuego@lists.linuxfoundation.org > Subject: RE: [Fuego] [PATCH 2/3] cyclictest: modify specs > > > > > -----Original Message----- > > From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego- > > bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin > > Sent: Tuesday, October 31, 2017 9:32 AM > > To: fuego@lists.linuxfoundation.org > > Subject: [Fuego] [PATCH 2/3] cyclictest: modify specs > > > > cyclictest params can be very flexible so instead of > > giving a fixed pattern we use a single variable PARAMS > > to hold them. > > > > TODO: make builds parameterizable so that users can > > modify the PARAMS from ftc without needing to create > > a new spec. > > > > Signed-off-by: Daniel Sangorrin > > --- > > engine/tests/Benchmark.cyclictest/fuego_test.sh | 3 +-- > > engine/tests/Benchmark.cyclictest/spec.json | 5 ++++- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/engine/tests/Benchmark.cyclictest/fuego_test.sh > > b/engine/tests/Benchmark.cyclictest/fuego_test.sh > > index efa892c..a32eb6e 100755 > > --- a/engine/tests/Benchmark.cyclictest/fuego_test.sh > > +++ b/engine/tests/Benchmark.cyclictest/fuego_test.sh > > @@ -10,8 +10,7 @@ function test_deploy { > > } > > > > function test_run { > > - assert_define BENCHMARK_CYCLICTEST_LOOPS > > - report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./cyclictest -t 2 -l > > $BENCHMARK_CYCLICTEST_LOOPS -q" > > + report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./cyclictest > > $BENCHMARK_CYCLICTEST_PARAMS" > > } > > > > > > diff --git a/engine/tests/Benchmark.cyclictest/spec.json > > b/engine/tests/Benchmark.cyclictest/spec.json > > index 774c742..a0a3a00 100644 > > --- a/engine/tests/Benchmark.cyclictest/spec.json > > +++ b/engine/tests/Benchmark.cyclictest/spec.json > > @@ -2,7 +2,10 @@ > > "testName": "Benchmark.cyclictest", > > "specs": { > > "default": { > > - "LOOPS":"10000" > > + "PARAMS": "-S -p 60 -m -D 20 -i 1000 -q" > > + }, > > + "twothreads": { > > + "PARAMS": "-t 2 -l 10000 -q" > > Here is my testlog for a beablebone black, running cyclictest > with spec 'twothreads'. That is, the result of running > job bbb.twothreads.Benchmark.cyclictest. > > # /dev/cpu_dma_latency set to 0us > T: 0 (27542) P: 0 I:1000 C: 10000 Min: 22 Act: -885 Avg:2147483647 Max: -126 > T: 1 (27543) P: 0 I:1500 C: 6690 Min: 23 Act: 3114 Avg:2147483647 Max: -413 > > This doesn't look right. Did it find a bug with the Beaglebone kernel, > or is something wrong with cyclictest, or are the params not right for this > board? This is a bug in cyclictest. It seems a patch was sent after that tarball was released: http://www.spinics.net/lists/linux-rt-users/msg15372.html So let's use the git repository as you mentioned. # Btw, I think there was a discussion about making a new cyclictest.. Maybe it would be good to influence in the outputformat? Thanks, Daniel > > Any ideas? > -- Tim