From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561Ab0IAFoR (ORCPT ); Wed, 1 Sep 2010 01:44:17 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:3681 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963Ab0IAFoO (ORCPT ); Wed, 1 Sep 2010 01:44:14 -0400 Message-ID: <005801cb4998$b526d9f0$66f8800a@maildom.okisemi.com> From: "Masayuki Ohtake" To: "Joe Perches" Cc: "Jean Delvare $PC drivers, core$" , "Ben Dooks $embedded platforms$" , "Crane Cai" , "Samuel Ortiz" , "Linus Walleij" , "Ralf Baechle" , "srinidhi kasagar" , , , "Wang Yong Y\"" , "Wang Qi\"" , "Andrew\"" , , "Tomoya MORINAGA" , "Arnd Bergmann" References: <4C7DB9CF.5000905@dsn.okisemi.com> <1283309032.1797.123.camel@Joe-Laptop> <001e01cb4993$bc0d75d0$66f8800a@maildom.okisemi.com> <1283318654.1797.140.camel@Joe-Laptop> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 Date: Wed, 1 Sep 2010 14:44:09 +0900 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, Thank you for your comments. Best Regards, Ohtake(OKISemi) ----- Original Message ----- From: "Joe Perches" To: "Masayuki Ohtake" Cc: "Jean Delvare (PC drivers, core)" ; "Ben Dooks (embedded platforms)" ; "Crane Cai" ; "Samuel Ortiz" ; "Linus Walleij" ; "Ralf Baechle" ; "srinidhi kasagar" ; ; ; "Wang Yong Y"" ; "Wang Qi"" ; "Andrew"" ; ; "Tomoya MORINAGA" ; "Arnd Bergmann" Sent: Wednesday, September 01, 2010 2:24 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 > On Wed, 2010-09-01 at 14:08 +0900, Masayuki Ohtake wrote: > > I have a question. > > Current our I2C driver has the following 2 patterns dev_err(). > > (1) dev_err(adap->pch_adapter.dev.parent, "..."); > > (2) dev_err(&pdev->dev, "..."); > > > #define pch_err(adap, fmt, arg...) \ > > > dev_err(adap->pch_adapter.dev.parent, fmt, ##arg) > > In case of using the above code, pattern (1) can apply, but (2) can't. > > As to (2), > > Should we use as dev_err or define another macro? > > Hello Ohtake. > > To me, it's a visual complexity vs std pattern trade-off. > > A 2 level dereference like dev_info(&dev->dev, ...) > isn't overly difficult to read. > 3 or more dereferences can be harder and a bit error prone. > So I would only use pch_ for (1) and dev_err for (2). > > There are also times when there are additional standard > arguments that you want to prefix to dev_ calls > and that can be simplified with a custom XXX_ > define for dev_ > > Look at the current uses in the tree and see what you like. > > $ grep -rP --include=*.[ch] "#define\s*.+\s+dev_[a-z]{3,7}\s*\(" * > > These aren't requirements, do what you think best. > > cheers, Joe > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Masayuki Ohtake" Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 Date: Wed, 1 Sep 2010 14:44:09 +0900 Message-ID: <005801cb4998$b526d9f0$66f8800a@maildom.okisemi.com> References: <4C7DB9CF.5000905@dsn.okisemi.com> <1283309032.1797.123.camel@Joe-Laptop> <001e01cb4993$bc0d75d0$66f8800a@maildom.okisemi.com> <1283318654.1797.140.camel@Joe-Laptop> Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joe Perches Cc: "Jean Delvare (PC drivers, core)" , "Ben Dooks (embedded platforms)" , Crane Cai , Samuel Ortiz , Linus Walleij , Ralf Baechle , srinidhi kasagar , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Wang Yong Y\"" , "Wang Qi\"" , "Andrew\"" , arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Tomoya MORINAGA , Arnd Bergmann List-Id: linux-i2c@vger.kernel.org Hi Joe, Thank you for your comments. Best Regards, Ohtake(OKISemi) ----- Original Message ----- From: "Joe Perches" To: "Masayuki Ohtake" Cc: "Jean Delvare (PC drivers, core)" ; "Ben Dooks (embedded platforms)" ; "Crane Cai" ; "Samuel Ortiz" ; "Linus Walleij" ; "Ralf Baechle" ; "srinidhi kasagar" ; ; ; "Wang Yong Y"" ; "Wang Qi"" ; "Andrew"" ; ; "Tomoya MORINAGA" ; "Arnd Bergmann" Sent: Wednesday, September 01, 2010 2:24 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 > On Wed, 2010-09-01 at 14:08 +0900, Masayuki Ohtake wrote: > > I have a question. > > Current our I2C driver has the following 2 patterns dev_err(). > > (1) dev_err(adap->pch_adapter.dev.parent, "..."); > > (2) dev_err(&pdev->dev, "..."); > > > #define pch_err(adap, fmt, arg...) \ > > > dev_err(adap->pch_adapter.dev.parent, fmt, ##arg) > > In case of using the above code, pattern (1) can apply, but (2) can't. > > As to (2), > > Should we use as dev_err or define another macro? > > Hello Ohtake. > > To me, it's a visual complexity vs std pattern trade-off. > > A 2 level dereference like dev_info(&dev->dev, ...) > isn't overly difficult to read. > 3 or more dereferences can be harder and a bit error prone. > So I would only use pch_ for (1) and dev_err for (2). > > There are also times when there are additional standard > arguments that you want to prefix to dev_ calls > and that can be simplified with a custom XXX_ > define for dev_ > > Look at the current uses in the tree and see what you like. > > $ grep -rP --include=*.[ch] "#define\s*.+\s+dev_[a-z]{3,7}\s*\(" * > > These aren't requirements, do what you think best. > > cheers, Joe >