All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matt Renzelmann" <mjr@cs.wisc.edu>
To: "'Stephen Boyd'" <sboyd@codeaurora.org>, <mjr@cs.wisc.edu>
Cc: <fbl@redhat.com>, <davem@davemloft.net>, <ben@simtec.co.uk>,
	<netdev@vger.kernel.org>
Subject: RE: [PATCH] ks8851: Fix missing mutex_lock/unlock
Date: Thu, 12 Apr 2012 15:56:25 -0500	[thread overview]
Message-ID: <005a01cd18ee$bcc45940$364d0bc0$@cs.wisc.edu> (raw)
In-Reply-To: <4F873C58.3000104@codeaurora.org>


> This register is already read in the probe function and the lock is not
> held there so you seem to have missed a couple. I would guess it doesn't
> really matter tha we don't grab the lock though because the device isn't
> actively sending/receiving packets. How about this instead?
> 

The reason I didn't go that way was the request_irq call is not made until near
the end of probe.  I believe only the ks8851_rdreg16 call in the netdev_info
statement actually needs the mutex protection.  That said, the approach you
posted looks reasonable as well and may be clearer.  I'm unsure as to which way
is best.

Thanks everyone for your help,
Matt

  reply	other threads:[~2012-04-12 20:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 20:06 [PATCH] ks8851: Fix missing mutex_lock/unlock mjr
2012-04-12 20:34 ` Stephen Boyd
2012-04-12 20:56   ` Matt Renzelmann [this message]
2012-04-12 20:59   ` Flavio Leitner
2012-04-12 21:19     ` Flavio Leitner
2012-04-12 20:40 ` Flavio Leitner
2012-04-12 21:28 mjr
2012-04-12 22:03 ` Ben Hutchings
2012-04-12 23:15 mjr
2012-04-13  0:22 ` Flavio Leitner
2012-04-13 17:46 ` Stephen Boyd
2012-04-13 17:59 mjr
2012-04-13 18:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005a01cd18ee$bcc45940$364d0bc0$@cs.wisc.edu' \
    --to=mjr@cs.wisc.edu \
    --cc=ben@simtec.co.uk \
    --cc=davem@davemloft.net \
    --cc=fbl@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.