From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B99AAC43381 for ; Fri, 15 Mar 2019 16:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 881E721871 for ; Fri, 15 Mar 2019 16:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ci7GPYxz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729442AbfCOQG3 (ORCPT ); Fri, 15 Mar 2019 12:06:29 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33833 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729378AbfCOQG3 (ORCPT ); Fri, 15 Mar 2019 12:06:29 -0400 Received: by mail-pg1-f195.google.com with SMTP id v12so6808892pgq.1 for ; Fri, 15 Mar 2019 09:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HnEJkIi0QPXxT9LeuePzW/D1R+dNIRnqqlKPr8o90R4=; b=ci7GPYxzDODugdVelYRX2wOeyZogWoLnpViT8v0mvkNMIF3KIlpoodWF7LdK/uNl3v Z67FTbw6sFxXosI6tXx5HaMkrYJ8HkiuKWQqL2jdQworBY9xuw7ZyxGYu+4Xdc/SekV3 /xtu5x+Rmwf4pGCqZr0c8+sC3RO6zG/bnmyFexs5h321Kl8T4ydiv/gaJTX8xSxvk9fN yz+jAyVwDSBP0TKCHXqU7+TojF6lI0MODts0Kelea/ygu569BPlc8iO+oLutoiGEPT6g PAMWwgDrwzY2kuWTJj+o+h2VC/x5OhHvi7uvvHSGI23eil8m8uadgqc4Wy+0gF8dXxl6 ppgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HnEJkIi0QPXxT9LeuePzW/D1R+dNIRnqqlKPr8o90R4=; b=dtTCPEeXgL9bV/RGbfLFb6EkA/DdLSM8YfixN1vwHZI0MPW00JjFYKY2kaPVcG+Die hOhXQFrZkrGtxXN3xRaGMYx+O9UMoIXOVAmgHh8C1lIVWDwSkPWIlT8JBelyBLADa9WI 38ELxDlFlZq4LqZ9PQHLcGdPoX5koEqvMZCDHxsM1cExmxhSwXpB/NImYdMxbaQpJynt 2tbLHChUMB4kSM8E/n30DIvPvOEvAJ3OrZyds/YPCFR5czg0UcwaeAQkcwfeJikKIVrt VAo/qgcsovB434SsZhanQ4PxusqXKd/4bZhS2haMNXUBopDhFSOJ2S/JNVpr0ewAQVvS eISQ== X-Gm-Message-State: APjAAAW5rha/Zbn1iXFsrwx28bEx9UbZIAjLoy9Yg3szcSL43hJdHR2w IVIQQkF0uBZdyTYssHP8+oDITtGt X-Google-Smtp-Source: APXvYqxB/DGrOxJEdUpe9N+mZG3menOi04AOV0J//58ideC+7yjlWAcYG76fRSI+n3L19bNNgQ7SEg== X-Received: by 2002:a17:902:5a5:: with SMTP id f34mr4983687plf.35.1552665988093; Fri, 15 Mar 2019 09:06:28 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id b138sm4740627pfb.48.2019.03.15.09.06.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 09:06:26 -0700 (PDT) Subject: Re: [PATCH v2] vxlan: remove the redundant gro_cells_destroy() calling. To: Stefano Brivio , Zhiqiang Liu Cc: davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com, sd@queasysnail.net, mousuanming@huawei.com, netdev@vger.kernel.org, Mingfangsen , "Zhoukang (A)" , "wangxiaogang (F)" , Eric Dumazet References: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com> <20190315162824.732b18ac@elisabeth> From: Eric Dumazet Message-ID: <005ad387-8d51-561e-a5b9-8e851e03d5e9@gmail.com> Date: Fri, 15 Mar 2019 09:06:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190315162824.732b18ac@elisabeth> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/15/2019 08:28 AM, Stefano Brivio wrote: > On Fri, 15 Mar 2019 23:18:52 +0800 > Zhiqiang Liu wrote: > >> In vxlan_destroy_tunnels func, unregister_netdevice_queue is called after >> gro_cells_destroy func. However, in unregister_netdevice_queue func, the >> gro_cells_destroy func will also call the gro_cells_destroy func as the >> following routine: >> unregister_netdevice_many() -> rollback_registered_many() >> -> ndo_uninit() -> gro_cells_destroy() >> >> Signed-off-by: Suanming.Mou >> Reviewed-by: Zhiqiang Liu >> Reviewed-by: Stefano Brivio > > NACK, please read my and Eric's comments to v1 -- giving me more than 23 > minutes to answer would have been a nice touch as well :) > Sorry for the confusion, I forgot to add the question marks to my sentences. In fact, this is a bug fix, that we missed in the previous fix. Technically the bug is older.