From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'J. Bruce Fields'" <bfields@fieldses.org>,
"'Aurélien Aptel'" <aaptel@suse.com>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<smfrench@gmail.com>, <senozhatsky@chromium.org>,
<hyc.lee@gmail.com>, <viro@zeniv.linux.org.uk>, <hch@lst.de>,
<hch@infradead.org>, <ronniesahlberg@gmail.com>,
<aurelien.aptel@gmail.com>, <sandeen@sandeen.net>,
<dan.carpenter@oracle.com>, <colin.king@canonical.com>,
<rdunlap@infradead.org>, <willy@infradead.org>
Subject: RE: [PATCH v2 00/10] cifsd: introduce new SMB3 kernel server
Date: Thu, 29 Apr 2021 09:18:28 +0900 [thread overview]
Message-ID: <005d01d73c8d$2dd5ca80$89815f80$@samsung.com> (raw)
In-Reply-To: <20210428235702.GE7400@fieldses.org>
> On Thu, Apr 29, 2021 at 12:24:17AM +0200, Aurélien Aptel wrote:
> > "J. Bruce Fields" <bfields@fieldses.org> writes:
> > > I'd rather see multiple patches that were actually functional at
> > > each
> > > stage: e.g., start with a server that responds to some sort of
> > > rpc-level ping but does nothing else, then add basic file IO, etc.
> > >
> > > I don't know if that's practical.
> >
> > Although it would certainly be nice I don't think it's realistic to
> > expect this kind of retro-logical-rewriting. AFAIK the other new
> > fs-related addition (ntfs patchset) is using the same trick of adding
> > the Makefile at the end after it was suggested on the mailing list. So
> > there's a precedent.
>
> OK, I wondered if that might be the case.
>
> I don't love it, but, fair enough, maybe that's the best compromise.
Thank you for your understanding. One big patch seems to be unable to review
because the code seem to be cut off in the mail. So it does not exceed 300KB
per patch. So we split patches out by layer and added Makefile, Kconfig
at the end.
Thanks!
>
> --b.
prev parent reply other threads:[~2021-04-29 0:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210422003835epcas1p246c40c6a6bbc0e9f5d4ccf9b69bef0d7@epcas1p2.samsung.com>
2021-04-22 0:28 ` [PATCH v2 00/10] cifsd: introduce new SMB3 kernel server Namjae Jeon
[not found] ` <CGME20210422003836epcas1p391ed30aed1cf7b010b93c32fc1aebe89@epcas1p3.samsung.com>
2021-04-22 0:28 ` [PATCH v2 01/10] cifsd: add document Namjae Jeon
2021-04-22 4:06 ` cifsd/nfsd interop Amir Goldstein
2021-04-22 8:11 ` Namjae Jeon
[not found] ` <CGME20210422003837epcas1p48d3a9bc060df8e8dca3fab76201000fc@epcas1p4.samsung.com>
2021-04-22 0:28 ` [PATCH v2 02/10] cifsd: add server handler Namjae Jeon
[not found] ` <CGME20210422003838epcas1p3c4529c7bc5a5a5e9e20187713d924033@epcas1p3.samsung.com>
2021-04-22 0:28 ` [PATCH v2 03/10] cifsd: add trasport layers Namjae Jeon
[not found] ` <CGME20210422003839epcas1p470ba6caba45731e45e84a296cf3880ad@epcas1p4.samsung.com>
2021-04-22 0:28 ` [PATCH v2 04/10] cifsd: add authentication Namjae Jeon
[not found] ` <CGME20210422003841epcas1p46060d68382b3e91046ade85cb9c1b6fe@epcas1p4.samsung.com>
2021-04-22 0:28 ` [PATCH v2 05/10] cifsd: add smb3 engine part 1 Namjae Jeon
[not found] ` <CGME20210422003842epcas1p1774510f2e4ccdb47dad4c1493842162d@epcas1p1.samsung.com>
2021-04-22 0:28 ` [PATCH v2 06/10] cifsd: add smb3 engine part 2 Namjae Jeon
[not found] ` <CGME20210422003843epcas1p374627e9b9bc86da8408892407a0b4428@epcas1p3.samsung.com>
2021-04-22 0:28 ` [PATCH v2 07/10] cifsd: add oplock/lease cache mechanism Namjae Jeon
2021-04-28 20:16 ` J. Bruce Fields
2021-04-29 0:36 ` Namjae Jeon
[not found] ` <CGME20210422003844epcas1p498d837c44d537534bc3b81da6ce302c3@epcas1p4.samsung.com>
2021-04-22 0:28 ` [PATCH v2 08/10] cifsd: add file operations Namjae Jeon
[not found] ` <CGME20210422003845epcas1p26e9145c0651b8ac8e3ad855df39163c7@epcas1p2.samsung.com>
2021-04-22 0:28 ` [PATCH v2 09/10] cifsd: add Kconfig and Makefile Namjae Jeon
[not found] ` <CGME20210422003846epcas1p1c8e4f9e46f77d2974e488785cd16d529@epcas1p1.samsung.com>
2021-04-22 0:28 ` [PATCH v2 10/10] MAINTAINERS: add cifsd kernel server Namjae Jeon
2021-04-27 20:53 ` [PATCH v2 00/10] cifsd: introduce new SMB3 " J. Bruce Fields
2021-04-27 21:38 ` Namjae Jeon
2021-04-28 19:13 ` J. Bruce Fields
2021-04-29 0:07 ` Namjae Jeon
2021-04-28 19:18 ` J. Bruce Fields
2021-04-28 20:19 ` Aurélien Aptel
2021-04-28 20:40 ` J. Bruce Fields
2021-04-28 22:24 ` Aurélien Aptel
2021-04-28 23:57 ` J. Bruce Fields
2021-04-29 0:18 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005d01d73c8d$2dd5ca80$89815f80$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=aaptel@suse.com \
--cc=aurelien.aptel@gmail.com \
--cc=bfields@fieldses.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hyc.lee@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ronniesahlberg@gmail.com \
--cc=sandeen@sandeen.net \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.