From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605Ab0I1H6l (ORCPT ); Tue, 28 Sep 2010 03:58:41 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34124 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab0I1H6i (ORCPT ); Tue, 28 Sep 2010 03:58:38 -0400 Date: Tue, 28 Sep 2010 16:58:49 +0900 From: Kukjin Kim Subject: RE: [PATCH v3] regulators: add support max8952 regulator In-reply-to: To: "'Kukjin Kim'" , kyungmin.park@samsung.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: lrg@slimlogic.co.uk, "'Changhwan Youn'" , "'MyungJoo Ham'" , "'Mark Brown'" Message-id: <006201cb5ee3$0100fc20$0302f460$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: ko Content-transfer-encoding: 7BIT Thread-index: ActO5kLH59RwdkyyRB6bO2YWhCCsKgAGvnQQABNFQRAD5RVEQA== References: <1283901976-32588-1-git-send-email-kgene.kim@samsung.com> <01a401cb4f01$73d60ac0$5b822040$%park@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kukjin Kim wrote: > > Kyungmin Park wrote: > > > > Do you check the DVS feature? > > It can support the DVS by GPIOs and platform can set the each voltages at > > each mode. > > > Ok...I agree about the feature's necessity that you said. > > However, we don't need separate driver which has same/similar functionality. > So...would be better that could implement it in max8649... > > Could you please do it based on this?...in fact, can't test it on SMDK. > Hmm... Kyungmin, if you have no time to do it, my team will do it. Is it ok? > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > As quick review of max8649. It can't support it. > > > > Thank you, > > Kyungmin Park > > > > -----Original Message----- > > From: Kukjin Kim [mailto:kgene.kim@samsung.com] > > Sent: Wednesday, September 08, 2010 8:26 AM > > To: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-samsung-soc@vger.kernel.org > > Cc: lrg@slimlogic.co.uk; Changhwan Youn; Kukjin Kim; MyungJoo Ham; > Kyungmin > > Park > > Subject: [PATCH v3] regulators: add support max8952 regulator > > > > From: Changhwan Youn > > > > The operation of max8952 is almost similar to max8649 except the output > > voltage range. This patch adds support the max8952 regulator using > > current max8649 implementation. And removes separate max8952.[ch] files > > since the functionality is now merged into this driver. > > > > Signed-off-by: Changhwan Youn > > Signed-off-by: Kukjin Kim > > Cc: MyungJoo Ham > > Cc: Kyungmin Park > > Acked-by: Mark Brown > > --- > > Following is as per Mark Brown's suggestion. > > Changes since v2: > > - Removed separate max8952.[ch] files > > > > Changes since v1: > > - Added returning fail when detected wrong ID > > - Added matching the ID from the chip in case the user got things wrong > > - Added enum chip ID instead of 0, 1 > > > (snip) From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 28 Sep 2010 16:58:49 +0900 Subject: [PATCH v3] regulators: add support max8952 regulator References: <1283901976-32588-1-git-send-email-kgene.kim@samsung.com> <01a401cb4f01$73d60ac0$5b822040$%park@samsung.com> Message-ID: <006201cb5ee3$0100fc20$0302f460$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Kukjin Kim wrote: > > Kyungmin Park wrote: > > > > Do you check the DVS feature? > > It can support the DVS by GPIOs and platform can set the each voltages at > > each mode. > > > Ok...I agree about the feature's necessity that you said. > > However, we don't need separate driver which has same/similar functionality. > So...would be better that could implement it in max8649... > > Could you please do it based on this?...in fact, can't test it on SMDK. > Hmm... Kyungmin, if you have no time to do it, my team will do it. Is it ok? > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > As quick review of max8649. It can't support it. > > > > Thank you, > > Kyungmin Park > > > > -----Original Message----- > > From: Kukjin Kim [mailto:kgene.kim at samsung.com] > > Sent: Wednesday, September 08, 2010 8:26 AM > > To: linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; > > linux-samsung-soc at vger.kernel.org > > Cc: lrg at slimlogic.co.uk; Changhwan Youn; Kukjin Kim; MyungJoo Ham; > Kyungmin > > Park > > Subject: [PATCH v3] regulators: add support max8952 regulator > > > > From: Changhwan Youn > > > > The operation of max8952 is almost similar to max8649 except the output > > voltage range. This patch adds support the max8952 regulator using > > current max8649 implementation. And removes separate max8952.[ch] files > > since the functionality is now merged into this driver. > > > > Signed-off-by: Changhwan Youn > > Signed-off-by: Kukjin Kim > > Cc: MyungJoo Ham > > Cc: Kyungmin Park > > Acked-by: Mark Brown > > --- > > Following is as per Mark Brown's suggestion. > > Changes since v2: > > - Removed separate max8952.[ch] files > > > > Changes since v1: > > - Added returning fail when detected wrong ID > > - Added matching the ID from the chip in case the user got things wrong > > - Added enum chip ID instead of 0, 1 > > > (snip)