From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger Date: Tue, 20 Sep 2016 18:40:06 +0100 Message-ID: <00697eef-0b36-1ff5-9c7a-43c1b53b52bc@nvidia.com> References: <20160828173246.32621-1-contact@paulk.fr> <20160828173246.32621-2-contact@paulk.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160828173246.32621-2-contact-W9ppeneeCTY@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Kocialkowski , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , Thierry Reding , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Courbot , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 28/08/16 18:32, Paul Kocialkowski wrote: > Nyan boards come with an embedded controller that controls when to > enable and disable the charge. Thus, it should not be left up to the > kernel to handle that. > > Using the ti,external-control property allows specifying this use-case. So the bq24735 is populated under the EC's 'i2c-tunnel' property which is there to specifically interface it's child devices to the host. So I am a bit confused why this is expose to the host if it should not be used? Again you may right and I did find the original series [0] for this which specifically references the Acer Chromebook that needs this. However, I am not sure why this was never populated? Is there any other history here? What is the actual problem you see without making this change? The original series states ... "On Acer Chromebook 13 (CB5-311) this module fails to load if the charger is not inserted, and will error when it is removed." Cheers Jon [0] http://marc.info/?l=linux-pm&m=145447948705686&w=2 -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755859AbcITRkX (ORCPT ); Tue, 20 Sep 2016 13:40:23 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:13929 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755827AbcITRkT (ORCPT ); Tue, 20 Sep 2016 13:40:19 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 20 Sep 2016 10:34:40 -0700 Subject: Re: [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger To: Paul Kocialkowski , References: <20160828173246.32621-1-contact@paulk.fr> <20160828173246.32621-2-contact@paulk.fr> CC: , Stephen Warren , Thierry Reding , , Alexandre Courbot , From: Jon Hunter Message-ID: <00697eef-0b36-1ff5-9c7a-43c1b53b52bc@nvidia.com> Date: Tue, 20 Sep 2016 18:40:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160828173246.32621-2-contact@paulk.fr> X-Originating-IP: [10.21.132.118] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/16 18:32, Paul Kocialkowski wrote: > Nyan boards come with an embedded controller that controls when to > enable and disable the charge. Thus, it should not be left up to the > kernel to handle that. > > Using the ti,external-control property allows specifying this use-case. So the bq24735 is populated under the EC's 'i2c-tunnel' property which is there to specifically interface it's child devices to the host. So I am a bit confused why this is expose to the host if it should not be used? Again you may right and I did find the original series [0] for this which specifically references the Acer Chromebook that needs this. However, I am not sure why this was never populated? Is there any other history here? What is the actual problem you see without making this change? The original series states ... "On Acer Chromebook 13 (CB5-311) this module fails to load if the charger is not inserted, and will error when it is removed." Cheers Jon [0] http://marc.info/?l=linux-pm&m=145447948705686&w=2 -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathanh@nvidia.com (Jon Hunter) Date: Tue, 20 Sep 2016 18:40:06 +0100 Subject: [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger In-Reply-To: <20160828173246.32621-2-contact@paulk.fr> References: <20160828173246.32621-1-contact@paulk.fr> <20160828173246.32621-2-contact@paulk.fr> Message-ID: <00697eef-0b36-1ff5-9c7a-43c1b53b52bc@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/08/16 18:32, Paul Kocialkowski wrote: > Nyan boards come with an embedded controller that controls when to > enable and disable the charge. Thus, it should not be left up to the > kernel to handle that. > > Using the ti,external-control property allows specifying this use-case. So the bq24735 is populated under the EC's 'i2c-tunnel' property which is there to specifically interface it's child devices to the host. So I am a bit confused why this is expose to the host if it should not be used? Again you may right and I did find the original series [0] for this which specifically references the Acer Chromebook that needs this. However, I am not sure why this was never populated? Is there any other history here? What is the actual problem you see without making this change? The original series states ... "On Acer Chromebook 13 (CB5-311) this module fails to load if the charger is not inserted, and will error when it is removed." Cheers Jon [0] http://marc.info/?l=linux-pm&m=145447948705686&w=2 -- nvpublic