From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAC0ECE58F for ; Wed, 16 Oct 2019 01:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D58C820873 for ; Wed, 16 Oct 2019 01:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfJPBep (ORCPT ); Tue, 15 Oct 2019 21:34:45 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3775 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726083AbfJPBep (ORCPT ); Tue, 15 Oct 2019 21:34:45 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 94D242E291AD95F441B4; Wed, 16 Oct 2019 09:34:43 +0800 (CST) Received: from [127.0.0.1] (10.57.77.109) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Wed, 16 Oct 2019 09:34:33 +0800 Subject: Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro To: Rikard Falkeborn References: <1569835209-44326-2-git-send-email-xuzaibo@huawei.com> <20191015201330.25973-1-rikard.falkeborn@gmail.com> CC: , , , , , , From: Xu Zaibo Message-ID: <006a5fca-3493-9b35-7621-aa9b2a9290d7@huawei.com> Date: Wed, 16 Oct 2019 09:34:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20191015201330.25973-1-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.77.109] X-CFilter-Loop: Reflected Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Agree with you, thanks! Zaibo . On 2019/10/16 4:13, Rikard Falkeborn wrote: > Arguments are supposed to be ordered high then low. > > Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator") > Signed-off-by: Rikard Falkeborn > --- > Spotted when trying to introduce compile time checking that the order > of the arguments to GENMASK are correct [0]. I have only compile tested > the patch. > > [0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/ > > drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c > index ca945b29632b..34e0424410bf 100644 > --- a/drivers/crypto/hisilicon/hpre/hpre_main.c > +++ b/drivers/crypto/hisilicon/hpre/hpre_main.c > @@ -116,8 +116,8 @@ static const struct hpre_hw_error hpre_hw_errors[] = { > { .int_msk = BIT(7), .msg = "hpre_cltr2_htbt_tm_out_err" }, > { .int_msk = BIT(8), .msg = "hpre_cltr3_htbt_tm_out_err" }, > { .int_msk = BIT(9), .msg = "hpre_cltr4_htbt_tm_out_err" }, > - { .int_msk = GENMASK(10, 15), .msg = "hpre_ooo_rdrsp_err" }, > - { .int_msk = GENMASK(16, 21), .msg = "hpre_ooo_wrrsp_err" }, > + { .int_msk = GENMASK(15, 10), .msg = "hpre_ooo_rdrsp_err" }, > + { .int_msk = GENMASK(21, 16), .msg = "hpre_ooo_wrrsp_err" }, > { /* sentinel */ } > }; >