From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8983C433EF for ; Thu, 21 Oct 2021 11:13:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFE5F6108E for ; Thu, 21 Oct 2021 11:13:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AFE5F6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07BCD6E42E; Thu, 21 Oct 2021 11:13:16 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3653189F4A; Thu, 21 Oct 2021 11:13:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="216173734" X-IronPort-AV: E=Sophos;i="5.87,169,1631602800"; d="scan'208";a="216173734" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 04:13:12 -0700 X-IronPort-AV: E=Sophos;i="5.87,169,1631602800"; d="scan'208";a="495089184" Received: from bgmccabx-mobl1.ger.corp.intel.com (HELO [10.213.228.24]) ([10.213.228.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 04:13:11 -0700 Subject: Re: [Intel-gfx] [PATCH 02/28] drm/i915: use new iterator in i915_gem_object_wait_reservation To: Maarten Lankhorst , =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Daniel Vetter References: <20211021103605.735002-1-maarten.lankhorst@linux.intel.com> <20211021103605.735002-2-maarten.lankhorst@linux.intel.com> <022f8ecb-37c0-3d67-563f-012f0a3651df@amd.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <007050d3-0207-5226-0cbe-7a3d8679811c@linux.intel.com> Date: Thu, 21 Oct 2021 12:13:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 21/10/2021 12:06, Maarten Lankhorst wrote: > Op 21-10-2021 om 12:38 schreef Christian König: >> Am 21.10.21 um 12:35 schrieb Maarten Lankhorst: >>> From: Christian König >>> >>> Simplifying the code a bit. >>> >>> Signed-off-by: Christian König >>> [mlankhorst: Handle timeout = 0 correctly, use new i915_request_wait_timeout.] >>> Signed-off-by: Maarten Lankhorst >> >> LGTM, do you want to push it or should I pick it up into drm-misc-next? > > I think it can be applied to drm-intel-gt-next, after a backmerge. It needs patch 1 too, which fixes > > i915_request_wait semantics when used in dma-fence. It exports a dma-fence compatible i915_request_wait_timeout function, used in this patch. I don't think my open has been resolved, at least I haven't seen a reply from Daniel on the topic of potential for infinite waits with untrusted clients after this change. +Daniel Regards, Tvrtko