All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Zhang Xiaoxu'" <zhangxiaoxu5@huawei.com>
Cc: <sfrench@samba.org>, <sergey.senozhatsky@gmail.com>,
	<hyc.lee@gmail.com>, <linux-cifs@vger.kernel.org>,
	<linux-cifsd-devel@lists.sourceforge.net>, <yukuai3@huawei.com>
Subject: RE: [PATCH] cifsd: Select SG_POOL for SMB_SERVER
Date: Wed, 7 Apr 2021 13:02:29 +0900	[thread overview]
Message-ID: <007901d72b62$d3d59be0$7b80d3a0$@samsung.com> (raw)
In-Reply-To: <20210407034546.2314958-1-zhangxiaoxu5@huawei.com>

> hulk-robot following build error:
>  fs/cifsd/transport_rdma.c: In function ‘read_write_done’:
>  fs/cifsd/transport_rdma.c:1297:2: error: implicit declaration of function ‘sg_free_table_chained’ [-
> Werror=implicit-function-declaration]
>   1297 |  sg_free_table_chained(&msg->sgt, SG_CHUNK_SIZE);
> 
> The reason is CONFIG_SG_POOL is not enabled in the config, to avoid such failure, select SG_POOL in
> Kconfig for SMB_SERVER.
> 
> Fixes: 75b8988dfe83 ("cifsd: add server handler for central processing and tranport layers")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
>  fs/cifsd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index d1ac53c83125..fb57672424be 100644
> --- a/fs/cifsd/Kconfig
> +++ b/fs/cifsd/Kconfig
> @@ -17,6 +17,7 @@ config SMB_SERVER
>  	select CRYPTO_AEAD2
>  	select CRYPTO_CCM
>  	select CRYPTO_GCM
> +	select SG_POOL
>  	default n
>  	help
>  	  Choose Y here if you want to allow SMB3 compliant clients
transport_rdma.c is built when SMB_SERVER_SMBDIRECT is set.
So we need to move it to config SMB_SERVER_SMBDIRECT.

diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig
index d1ac53c83125..b94cf1158182 100644
--- a/fs/cifsd/Kconfig
+++ b/fs/cifsd/Kconfig
@@ -43,6 +43,7 @@ config SMB_SERVER
 config SMB_SERVER_SMBDIRECT
        bool "Support for SMB Direct protocol"
        depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS || SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
+       select SG_POOL
        default n
 
        help

I will directly update your patch.
Thanks for your patch!
> --
> 2.25.4




      reply	other threads:[~2021-04-07  4:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210407034026epcas1p30694eae719a68b92f759dc4e5a92b542@epcas1p3.samsung.com>
2021-04-07  3:45 ` [PATCH] cifsd: Select SG_POOL for SMB_SERVER Zhang Xiaoxu
2021-04-07  4:02   ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007901d72b62$d3d59be0$7b80d3a0$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=hyc.lee@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-cifsd-devel@lists.sourceforge.net \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sfrench@samba.org \
    --cc=yukuai3@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.