* [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-07 14:11 ` Anil Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Anil Kumar @ 2013-02-07 14:11 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-omap, devicetree-discuss
Cc: linux, b-cousson, tony, grant.likely, anilk4.v, thomas
DevKit8000 is a beagle board clone from Timll, sold by
armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
JTAG interface.
This patch adds the basic DT support for devkit8000. At this time, Information
of twl4030, MMC1, I2C1, leds and there pim mux information are added.
Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
Tested-by: Thomas Weber <thomas@tomweber.eu>
---
-This patch is based on top of kernel 3.8-rc5.
-Tested on Devkit8000.
:100644 100644 5ebb44f... 22ebc76... M arch/arm/boot/dts/Makefile
:000000 100644 0000000... 9864fd7... A arch/arm/boot/dts/omap3-devkit8000.dts
:100644 100644 53cb380b.. 6e2cef6... M arch/arm/mach-omap2/board-generic.c
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/omap3-devkit8000.dts | 125 ++++++++++++++++++++++++++++++++
arch/arm/mach-omap2/board-generic.c | 1 +
3 files changed, 127 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5ebb44f..22ebc76 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-tx28.dtb
dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle.dtb \
+ omap3-devkit8000.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
new file mode 100644
index 0000000..9864fd7
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-devkit8000.dts
@@ -0,0 +1,125 @@
+/*
+ * Anil Kumar <anilk4.v@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ "omap3.dtsi"
+/ {
+ model = "TI OMAP3 Devkit8000";
+ compatible = "ti,omap3-devkit8000", "ti,omap3";
+
+ memory {
+ device_type = "memory";
+ reg = <0x80000000 0x10000000>; /* 256 MB */
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&leds_pins>;
+
+ heartbeat {
+ label = "devkit8000::led1";
+ gpios = <&gpio6 26 0>; /* 186 -> LED1 */
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ mmc {
+ label = "devkit8000::led2";
+ gpios = <&gpio6 3 0>; /* 163 -> LED2 */
+ default-state = "on";
+ linux,default-trigger = "none";
+ };
+
+ usr {
+ label = "devkit8000::led3";
+ gpios = <&gpio6 4 0>; /* 164 -> LED3 */
+ default-state = "on";
+ linux,default-trigger = "usr";
+ };
+
+ };
+};
+
+&omap3_pmx_core {
+ leds_pins: pinmux_led_pins {
+ pinctrl-single,pins = <
+ 0x168 0x4 /* GPIO_163 */
+ 0x16c 0x4 /* GPIO_164 */
+ 0x1b0 0x4 /* GPIO_186 */
+
+ >;
+ };
+
+ i2c1_pins: pinmux_i2c1_pins {
+ pinctrl-single,pins = <
+ 0x188 0x118 /* I2C1_SCL */
+ 0x18c 0x118 /* I2C1_SDA */
+ >;
+ };
+};
+
+&i2c1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c1_pins>;
+ clock-frequency = <2600000>;
+
+ twl: twl@48 {
+ reg = <0x48>;
+ interrupts = <7>; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = <&intc>;
+ };
+};
+
+&i2c2 {
+ status = "disabled";
+};
+
+&i2c3 {
+ status = "disabled";
+};
+
+/include/ "twl4030.dtsi"
+
+&mmc1 {
+ vmmc-supply = <&vmmc1>;
+ vmmc_aux-supply = <&vsim>;
+ bus-width = <8>;
+};
+
+&mmc2 {
+ status = "disabled";
+};
+
+&mmc3 {
+ status = "disabled";
+};
+
+&wdt2 {
+ status = "disabled";
+};
+
+&mcbsp1 {
+ status = "disabled";
+};
+
+&mcbsp2 {
+ status = "disabled";
+};
+
+&mcbsp3 {
+ status = "disabled";
+};
+
+&mcbsp4 {
+ status = "disabled";
+};
+
+&mcbsp5 {
+ status = "disabled";
+};
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index 53cb380..6e2cef6 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -110,6 +110,7 @@ MACHINE_END
static const char *omap3_gp_boards_compat[] __initdata = {
"ti,omap3-beagle",
+ "ti,omap3-devkit8000",
NULL,
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-07 14:11 ` Anil Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Anil Kumar @ 2013-02-07 14:11 UTC (permalink / raw)
To: linux-arm-kernel
DevKit8000 is a beagle board clone from Timll, sold by
armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
JTAG interface.
This patch adds the basic DT support for devkit8000. At this time, Information
of twl4030, MMC1, I2C1, leds and there pim mux information are added.
Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
Tested-by: Thomas Weber <thomas@tomweber.eu>
---
-This patch is based on top of kernel 3.8-rc5.
-Tested on Devkit8000.
:100644 100644 5ebb44f... 22ebc76... M arch/arm/boot/dts/Makefile
:000000 100644 0000000... 9864fd7... A arch/arm/boot/dts/omap3-devkit8000.dts
:100644 100644 53cb380b.. 6e2cef6... M arch/arm/mach-omap2/board-generic.c
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/omap3-devkit8000.dts | 125 ++++++++++++++++++++++++++++++++
arch/arm/mach-omap2/board-generic.c | 1 +
3 files changed, 127 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5ebb44f..22ebc76 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-tx28.dtb
dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-beagle.dtb \
+ omap3-devkit8000.dtb \
omap3-beagle-xm.dtb \
omap3-evm.dtb \
omap3-tobi.dtb \
diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
new file mode 100644
index 0000000..9864fd7
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-devkit8000.dts
@@ -0,0 +1,125 @@
+/*
+ * Anil Kumar <anilk4.v@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ "omap3.dtsi"
+/ {
+ model = "TI OMAP3 Devkit8000";
+ compatible = "ti,omap3-devkit8000", "ti,omap3";
+
+ memory {
+ device_type = "memory";
+ reg = <0x80000000 0x10000000>; /* 256 MB */
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&leds_pins>;
+
+ heartbeat {
+ label = "devkit8000::led1";
+ gpios = <&gpio6 26 0>; /* 186 -> LED1 */
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ mmc {
+ label = "devkit8000::led2";
+ gpios = <&gpio6 3 0>; /* 163 -> LED2 */
+ default-state = "on";
+ linux,default-trigger = "none";
+ };
+
+ usr {
+ label = "devkit8000::led3";
+ gpios = <&gpio6 4 0>; /* 164 -> LED3 */
+ default-state = "on";
+ linux,default-trigger = "usr";
+ };
+
+ };
+};
+
+&omap3_pmx_core {
+ leds_pins: pinmux_led_pins {
+ pinctrl-single,pins = <
+ 0x168 0x4 /* GPIO_163 */
+ 0x16c 0x4 /* GPIO_164 */
+ 0x1b0 0x4 /* GPIO_186 */
+
+ >;
+ };
+
+ i2c1_pins: pinmux_i2c1_pins {
+ pinctrl-single,pins = <
+ 0x188 0x118 /* I2C1_SCL */
+ 0x18c 0x118 /* I2C1_SDA */
+ >;
+ };
+};
+
+&i2c1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c1_pins>;
+ clock-frequency = <2600000>;
+
+ twl: twl at 48 {
+ reg = <0x48>;
+ interrupts = <7>; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = <&intc>;
+ };
+};
+
+&i2c2 {
+ status = "disabled";
+};
+
+&i2c3 {
+ status = "disabled";
+};
+
+/include/ "twl4030.dtsi"
+
+&mmc1 {
+ vmmc-supply = <&vmmc1>;
+ vmmc_aux-supply = <&vsim>;
+ bus-width = <8>;
+};
+
+&mmc2 {
+ status = "disabled";
+};
+
+&mmc3 {
+ status = "disabled";
+};
+
+&wdt2 {
+ status = "disabled";
+};
+
+&mcbsp1 {
+ status = "disabled";
+};
+
+&mcbsp2 {
+ status = "disabled";
+};
+
+&mcbsp3 {
+ status = "disabled";
+};
+
+&mcbsp4 {
+ status = "disabled";
+};
+
+&mcbsp5 {
+ status = "disabled";
+};
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index 53cb380..6e2cef6 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -110,6 +110,7 @@ MACHINE_END
static const char *omap3_gp_boards_compat[] __initdata = {
"ti,omap3-beagle",
+ "ti,omap3-devkit8000",
NULL,
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000
2013-02-07 14:11 ` Anil Kumar
(?)
@ 2013-02-07 17:39 ` Mark Rutland
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Rutland @ 2013-02-07 17:39 UTC (permalink / raw)
To: Anil Kumar
Cc: linux-arm-kernel, linux-kernel, linux-omap, devicetree-discuss,
linux, b-cousson, tony, grant.likely, thomas
Hello,
I have a couple of minor comments.
On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> DevKit8000 is a beagle board clone from Timll, sold by
> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> JTAG interface.
>
> This patch adds the basic DT support for devkit8000. At this time, Information
> of twl4030, MMC1, I2C1, leds and there pim mux information are added.
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> Tested-by: Thomas Weber <thomas@tomweber.eu>
> ---
>
> -This patch is based on top of kernel 3.8-rc5.
>
> -Tested on Devkit8000.
>
[...]
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> new file mode 100644
> index 0000000..9864fd7
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -0,0 +1,125 @@
> +/*
> + * Anil Kumar <anilk4.v@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +/dts-v1/;
> +
> +/include/ "omap3.dtsi"
> +/ {
> + model = "TI OMAP3 Devkit8000";
Should this not be "TimLL Devkit8000" ?
> + compatible = "ti,omap3-devkit8000", "ti,omap3";
"timll,devkit8000" ?
[...]
Thanks,
Mark.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-07 17:39 ` Mark Rutland
0 siblings, 0 replies; 8+ messages in thread
From: Mark Rutland @ 2013-02-07 17:39 UTC (permalink / raw)
To: Anil Kumar
Cc: linux-arm-kernel, linux-kernel, linux-omap, devicetree-discuss,
linux, b-cousson, tony, grant.likely, thomas
Hello,
I have a couple of minor comments.
On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> DevKit8000 is a beagle board clone from Timll, sold by
> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> JTAG interface.
>
> This patch adds the basic DT support for devkit8000. At this time, Information
> of twl4030, MMC1, I2C1, leds and there pim mux information are added.
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> Tested-by: Thomas Weber <thomas@tomweber.eu>
> ---
>
> -This patch is based on top of kernel 3.8-rc5.
>
> -Tested on Devkit8000.
>
[...]
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> new file mode 100644
> index 0000000..9864fd7
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -0,0 +1,125 @@
> +/*
> + * Anil Kumar <anilk4.v@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +/dts-v1/;
> +
> +/include/ "omap3.dtsi"
> +/ {
> + model = "TI OMAP3 Devkit8000";
Should this not be "TimLL Devkit8000" ?
> + compatible = "ti,omap3-devkit8000", "ti,omap3";
"timll,devkit8000" ?
[...]
Thanks,
Mark.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-07 17:39 ` Mark Rutland
0 siblings, 0 replies; 8+ messages in thread
From: Mark Rutland @ 2013-02-07 17:39 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
I have a couple of minor comments.
On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> DevKit8000 is a beagle board clone from Timll, sold by
> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> JTAG interface.
>
> This patch adds the basic DT support for devkit8000. At this time, Information
> of twl4030, MMC1, I2C1, leds and there pim mux information are added.
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> Tested-by: Thomas Weber <thomas@tomweber.eu>
> ---
>
> -This patch is based on top of kernel 3.8-rc5.
>
> -Tested on Devkit8000.
>
[...]
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> new file mode 100644
> index 0000000..9864fd7
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -0,0 +1,125 @@
> +/*
> + * Anil Kumar <anilk4.v@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +/dts-v1/;
> +
> +/include/ "omap3.dtsi"
> +/ {
> + model = "TI OMAP3 Devkit8000";
Should this not be "TimLL Devkit8000" ?
> + compatible = "ti,omap3-devkit8000", "ti,omap3";
"timll,devkit8000" ?
[...]
Thanks,
Mark.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: dts: add minimal DT support for DevKit8000
2013-02-07 17:39 ` Mark Rutland
(?)
@ 2013-02-08 13:35 ` AnilKumar
-1 siblings, 0 replies; 8+ messages in thread
From: AnilKumar @ 2013-02-08 13:35 UTC (permalink / raw)
To: 'Mark Rutland'
Cc: linux-arm-kernel, linux-kernel, linux-omap, devicetree-discuss,
linux, b-cousson, tony, grant.likely, thomas
Hi Mark,
Thanks for the review comments. Please find my comments inline.
On Thu, Feb 07, 2013 at 23:09:49, Mark Rutland wrote:
> Hello,
>
> I have a couple of minor comments.
>
> On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> > DevKit8000 is a beagle board clone from Timll, sold by armkits.com.
> > The DevKit8000 has RS232 serial port, LCD, DVI-D, S-Video, Ethernet,
> > SD/MMC, keyboard, camera, SPI, I2C, USB and JTAG interface.
> >
> > This patch adds the basic DT support for devkit8000. At this time,
> > Information of twl4030, MMC1, I2C1, leds and there pim mux
> > information are
> added.
> >
> > Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> > Tested-by: Thomas Weber <thomas@tomweber.eu>
> > ---
> >
> > -This patch is based on top of kernel 3.8-rc5.
> >
> > -Tested on Devkit8000.
> >
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts
> > b/arch/arm/boot/dts/omap3-devkit8000.dts
> > new file mode 100644
> > index 0000000..9864fd7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> > @@ -0,0 +1,125 @@
> > +/*
> > + * Anil Kumar <anilk4.v@gmail.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License version 2
> > +as
> > + * published by the Free Software Foundation.
> > + */
> > +/dts-v1/;
> > +
> > +/include/ "omap3.dtsi"
> > +/ {
> > + model = "TI OMAP3 Devkit8000";
>
> Should this not be "TimLL Devkit8000" ?
Hmm.. I think it will be better as "TimLL OMAP3 Devkit8000" as this board
is omap3 based.
>
> > + compatible = "ti,omap3-devkit8000", "ti,omap3";
>
> "timll,devkit8000" ?
I think it will be better as "timll,omap3-devkit8000" as this board is
omap3 based.
Thanks,
Anil
[...]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-08 13:35 ` AnilKumar
0 siblings, 0 replies; 8+ messages in thread
From: AnilKumar @ 2013-02-08 13:35 UTC (permalink / raw)
To: 'Mark Rutland'
Cc: linux-arm-kernel, linux-kernel, linux-omap, devicetree-discuss,
linux, b-cousson, tony, grant.likely, thomas
Hi Mark,
Thanks for the review comments. Please find my comments inline.
On Thu, Feb 07, 2013 at 23:09:49, Mark Rutland wrote:
> Hello,
>
> I have a couple of minor comments.
>
> On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> > DevKit8000 is a beagle board clone from Timll, sold by armkits.com.
> > The DevKit8000 has RS232 serial port, LCD, DVI-D, S-Video, Ethernet,
> > SD/MMC, keyboard, camera, SPI, I2C, USB and JTAG interface.
> >
> > This patch adds the basic DT support for devkit8000. At this time,
> > Information of twl4030, MMC1, I2C1, leds and there pim mux
> > information are
> added.
> >
> > Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> > Tested-by: Thomas Weber <thomas@tomweber.eu>
> > ---
> >
> > -This patch is based on top of kernel 3.8-rc5.
> >
> > -Tested on Devkit8000.
> >
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts
> > b/arch/arm/boot/dts/omap3-devkit8000.dts
> > new file mode 100644
> > index 0000000..9864fd7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> > @@ -0,0 +1,125 @@
> > +/*
> > + * Anil Kumar <anilk4.v@gmail.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License version 2
> > +as
> > + * published by the Free Software Foundation.
> > + */
> > +/dts-v1/;
> > +
> > +/include/ "omap3.dtsi"
> > +/ {
> > + model = "TI OMAP3 Devkit8000";
>
> Should this not be "TimLL Devkit8000" ?
Hmm.. I think it will be better as "TimLL OMAP3 Devkit8000" as this board
is omap3 based.
>
> > + compatible = "ti,omap3-devkit8000", "ti,omap3";
>
> "timll,devkit8000" ?
I think it will be better as "timll,omap3-devkit8000" as this board is
omap3 based.
Thanks,
Anil
[...]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: add minimal DT support for DevKit8000
@ 2013-02-08 13:35 ` AnilKumar
0 siblings, 0 replies; 8+ messages in thread
From: AnilKumar @ 2013-02-08 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
Thanks for the review comments. Please find my comments inline.
On Thu, Feb 07, 2013 at 23:09:49, Mark Rutland wrote:
> Hello,
>
> I have a couple of minor comments.
>
> On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> > DevKit8000 is a beagle board clone from Timll, sold by armkits.com.
> > The DevKit8000 has RS232 serial port, LCD, DVI-D, S-Video, Ethernet,
> > SD/MMC, keyboard, camera, SPI, I2C, USB and JTAG interface.
> >
> > This patch adds the basic DT support for devkit8000. At this time,
> > Information of twl4030, MMC1, I2C1, leds and there pim mux
> > information are
> added.
> >
> > Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> > Tested-by: Thomas Weber <thomas@tomweber.eu>
> > ---
> >
> > -This patch is based on top of kernel 3.8-rc5.
> >
> > -Tested on Devkit8000.
> >
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts
> > b/arch/arm/boot/dts/omap3-devkit8000.dts
> > new file mode 100644
> > index 0000000..9864fd7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> > @@ -0,0 +1,125 @@
> > +/*
> > + * Anil Kumar <anilk4.v@gmail.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > + * it under the terms of the GNU General Public License version 2
> > +as
> > + * published by the Free Software Foundation.
> > + */
> > +/dts-v1/;
> > +
> > +/include/ "omap3.dtsi"
> > +/ {
> > + model = "TI OMAP3 Devkit8000";
>
> Should this not be "TimLL Devkit8000" ?
Hmm.. I think it will be better as "TimLL OMAP3 Devkit8000" as this board
is omap3 based.
>
> > + compatible = "ti,omap3-devkit8000", "ti,omap3";
>
> "timll,devkit8000" ?
I think it will be better as "timll,omap3-devkit8000" as this board is
omap3 based.
Thanks,
Anil
[...]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-08 13:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 14:11 [PATCH] ARM: dts: add minimal DT support for DevKit8000 Anil Kumar
2013-02-07 14:11 ` Anil Kumar
2013-02-07 17:39 ` Mark Rutland
2013-02-07 17:39 ` Mark Rutland
2013-02-07 17:39 ` Mark Rutland
2013-02-08 13:35 ` AnilKumar
2013-02-08 13:35 ` AnilKumar
2013-02-08 13:35 ` AnilKumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.