From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33ADDC433F5 for ; Fri, 3 Sep 2021 20:43:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B03C610CF for ; Fri, 3 Sep 2021 20:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350931AbhICUoZ (ORCPT ); Fri, 3 Sep 2021 16:44:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350995AbhICUoT (ORCPT ); Fri, 3 Sep 2021 16:44:19 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE80C061575 for ; Fri, 3 Sep 2021 13:43:18 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id g138so104037wmg.4 for ; Fri, 03 Sep 2021 13:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=sz9KbnkkagCr/GFF3OMVQhtS6VhgzaCiOfnUEvPJVL2O8jwbbscHft/H9IJkpP0NsU TGizEk76lcvi8mLRugPLNXDpebTnYO3vqlZQK48MJI9TPSqJFF4fhUuswhN7CqY2Ghwk 3vqpHJ2pzTxkD4Alw5fP1VVDaMLadtQr5cqiT1MBE/uvf9J116rMMc6TMrhbx3UMJdIj /DMhuBGeqgleldVui5C3jsYuqvxxkrLkQtp2u6KAbqe0LNNwZJBYdNlmGqmCrDRJX6/D H9oo/QoelvlvKhE6ZH5vxKSx6LJafL8LYNlCMQZjRXX4mct49OSCXeOxBiNBVInXZevi wD3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=cCW2g7IukL3Bry6hYkdPnO54oMjuT4p8DLmraASeROlNT+/qGX9osUFNCCMEco1r7m YZOQP6bIKJfgzvrBrcOaHZeqty7YHh6cQaM0e/oqEdzfnNenKcbHpG5qnrMvfzDfcf+3 hpx0hVtTdqzKnHM4YlYn4hdvGnNMg9QTw1ZKXBx4+sXstbO5moSqN7H8ujkXqaoXfdBY 0gBs+6YE0OEaHT2YVKVi2486SfRBJtRvFfl4fpMllR7LQ098+j7eD6CbZMkHi5Rd3cpc 7ixcAEczquB9XODoxdpC1AI+Q49gew1kz+aPcQdSxHmNnh1/A2Tdodp7/jQd/59s0dNb evlg== X-Gm-Message-State: AOAM532hoLaB92/RX5YZUFViDPJrI4puBnWdwYqlwrYMGstEZxfAknDp Ek2AmGpTyY73sjK2ZgcDqV39IPADWJgYZeQA/uw= X-Google-Smtp-Source: ABdhPJyTwcg40ZXBf0kRQeFkHvEtxWVastgigZVfDdU3EBMLa1vjXC+xX2MEzRyEH8NNNNiGPWLbnA== X-Received: by 2002:a1c:1c2:: with SMTP id 185mr479522wmb.11.1630701796724; Fri, 03 Sep 2021 13:43:16 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id w9sm294701wrs.7.2021.09.03.13.43.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:43:16 -0700 (PDT) Subject: Re: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-23-f4bug@amsat.org> From: Richard Henderson Message-ID: <007f0874-b82f-5853-0c08-00528fb22bcb@linaro.org> Date: Fri, 3 Sep 2021 22:43:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-23-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > The common ppc_cpu_has_work() handler already checks for cs->halted, > so we can simplify all callees. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/cpu_init.c | 294 ++++++++++++++++++++---------------------- > 1 file changed, 138 insertions(+), 156 deletions(-) Well, I'm not actually a fan of this; I'd rather the outer function merely dispatch here, or preferably arrange to arrive here to begin. r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96238C4332F for ; Fri, 3 Sep 2021 20:56:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6099160E76 for ; Fri, 3 Sep 2021 20:56:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6099160E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMGEX-0001YX-Hs for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 16:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMG1z-0000vw-RQ for qemu-devel@nongnu.org; Fri, 03 Sep 2021 16:43:23 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:46854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMG1u-0002ck-4c for qemu-devel@nongnu.org; Fri, 03 Sep 2021 16:43:20 -0400 Received: by mail-wm1-x330.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso316602wmi.5 for ; Fri, 03 Sep 2021 13:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=sz9KbnkkagCr/GFF3OMVQhtS6VhgzaCiOfnUEvPJVL2O8jwbbscHft/H9IJkpP0NsU TGizEk76lcvi8mLRugPLNXDpebTnYO3vqlZQK48MJI9TPSqJFF4fhUuswhN7CqY2Ghwk 3vqpHJ2pzTxkD4Alw5fP1VVDaMLadtQr5cqiT1MBE/uvf9J116rMMc6TMrhbx3UMJdIj /DMhuBGeqgleldVui5C3jsYuqvxxkrLkQtp2u6KAbqe0LNNwZJBYdNlmGqmCrDRJX6/D H9oo/QoelvlvKhE6ZH5vxKSx6LJafL8LYNlCMQZjRXX4mct49OSCXeOxBiNBVInXZevi wD3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=ZSpUYFWRZzknwfV2AyWy38C4VLEfCbRxB3IXpUMc+idqzcCIdPlbmC1s1lwHVEJX+W vz30OPrdKnFtHQpbmqKe2Elgp38zX6ZlrrJKziCPtUlrTa5d2rQwpYsIYazQEKLX0w2Z GzoF+B1d8OvhkSHp6sRMaqh/gMS1aPg8a2Q2v3pBVr8a3CrShwbW2m1N4+2NXL/KIJhp uIHHC9qyFSZ26FJ9wzAlaBegf08G1OeImCponuC9E2DfBWWK0xsHj7otm8BEzGMAjdyo f+ghKT9AjVJ8uw//HPeLCBoBDt9l67EZlqlDj3dcetdZDhVXC+pKW1wAuIjslgiE5li/ fPPA== X-Gm-Message-State: AOAM532PTV6Y88c0FTrNDrfet5zcSczgYbvGnYHC4lr/eQ1YEJ918Rv8 ZaYWQVdkTv/YAnU+75ccjntfdA== X-Google-Smtp-Source: ABdhPJyTwcg40ZXBf0kRQeFkHvEtxWVastgigZVfDdU3EBMLa1vjXC+xX2MEzRyEH8NNNNiGPWLbnA== X-Received: by 2002:a1c:1c2:: with SMTP id 185mr479522wmb.11.1630701796724; Fri, 03 Sep 2021 13:43:16 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id w9sm294701wrs.7.2021.09.03.13.43.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:43:16 -0700 (PDT) Subject: Re: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-23-f4bug@amsat.org> From: Richard Henderson Message-ID: <007f0874-b82f-5853-0c08-00528fb22bcb@linaro.org> Date: Fri, 3 Sep 2021 22:43:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-23-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.888, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Bin Meng , Mark Cave-Ayland , Aleksandar Rikalo , Laurent Vivier , Max Filippov , Taylor Simpson , haxm-team@intel.com, Colin Xu , "Edgar E. Iglesias" , Stafford Horne , Marek Vasut , Stefano Stabellini , Yoshinori Sato , Paul Durrant , Kamil Rytarowski , Reinoud Zandijk , Claudio Fontana , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Sunil Muthuswamy , Palmer Dabbelt , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang , Alistair Francis , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > The common ppc_cpu_has_work() handler already checks for cs->halted, > so we can simplify all callees. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/cpu_init.c | 294 ++++++++++++++++++++---------------------- > 1 file changed, 138 insertions(+), 156 deletions(-) Well, I'm not actually a fan of this; I'd rather the outer function merely dispatch here, or preferably arrange to arrive here to begin. r~