From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB811C19F29 for ; Mon, 1 Aug 2022 12:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234764AbiHAMYp (ORCPT ); Mon, 1 Aug 2022 08:24:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234665AbiHAMY1 (ORCPT ); Mon, 1 Aug 2022 08:24:27 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8D478C74E; Mon, 1 Aug 2022 05:05:05 -0700 (PDT) X-UUID: d58cc39d9f234f5cacf6c1f8360cd81f-20220801 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:889e7572-6204-4a66-b48d-5d9ad7953887,OB:0,LO B:10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,AC TION:release,TS:45 X-CID-INFO: VERSION:1.1.8,REQID:889e7572-6204-4a66-b48d-5d9ad7953887,OB:0,LOB: 10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:45 X-CID-META: VersionHash:0f94e32,CLOUDID:e6cff7cf-a6cf-4fb6-be1b-c60094821ca2,C OID:5b89d6c2bdc6,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: d58cc39d9f234f5cacf6c1f8360cd81f-20220801 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1827340360; Mon, 01 Aug 2022 20:04:24 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 1 Aug 2022 20:04:22 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 1 Aug 2022 20:04:21 +0800 Message-ID: <0085fdd057687637ebd5a7688897a279e72e03f6.camel@mediatek.com> Subject: Re: [PATCH v4 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number From: Yong Wu To: Tinghan Shen , Joerg Roedel , Will Deacon , Robin Murphy , "Rob Herring" , Krzysztof Kozlowski , Lee Jones , "Matthias Brugger" , AngeloGioacchino Del Regno , MandyJH Liu CC: , , , , , , Date: Mon, 1 Aug 2022 20:04:21 +0800 In-Reply-To: <20220729063208.16799-2-tinghan.shen@mediatek.com> References: <20220729063208.16799-1-tinghan.shen@mediatek.com> <20220729063208.16799-2-tinghan.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-07-29 at 14:31 +0800, Tinghan Shen wrote: > mt8195 infra iommu uses 5 interrupts. > > Signed-off-by: Tinghan Shen > Reviewed-by: Krzysztof Kozlowski > --- > .../bindings/iommu/mediatek,iommu.yaml | 18 > +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > index fee0241b50988..5afe2a0045330 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > @@ -91,7 +91,8 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 5 > > clocks: > items: > @@ -191,9 +192,24 @@ allOf: > const: mediatek,mt8195-iommu-infra > > then: > + properties: > + interrupts: > + maxItems: 1 > + > required: > - mediatek,larbs > > + else: > + properties: > + interrupts: > + description: The IOMMU has 5 banks. Each bank has its own > interrupt. > + items: > + - description: The interrupt for IOMMU bank0 > + - description: The interrupt for IOMMU bank1 > + - description: The interrupt for IOMMU bank2 > + - description: The interrupt for IOMMU bank3 > + - description: The interrupt for IOMMU bank4 > + Thanks for improving this. Before the meaning for this segment is that it require "mediatek,larbs" if it is NOT infra iommu. Here we add a new block for infra iommu. then we'd better to remove the "not". this should be more readable. Something like below: if: /* Remove the not here. */ properties: compatible: contains: const: mediatek,mt8195-iommu-infra then: xxx else: xx > additionalProperties: false > > examples: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B105C00144 for ; Mon, 1 Aug 2022 12:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y6ZMt5imTvfUsN2jaOtQ+5h/aHL3nnYhRvjfsS2lNSM=; b=G8+Tvv4/82JQYz tBsEjDPJAlP4kx7IV+qOyF3a07MekFxtmfh1vo680TEV4VJBDX2xNCOPpYkIyknI1FPdA0rFZdmWI +HeU9Bix/LEoFoclgiD4nIJF1RfYHOQkD59Ug8kF2Rr1rMJKIkUZlBepTSH2wOF4AynPEK9h9mTk6 62uZLhmuZFEBMBTTA2ru0Hdf5DI1AOTY+UYF5+Hske1dBOxiQDqjNd+Tm2LTV31nsXq9Hcjhk9ZQO p+v/EOe9hXq4TNKBzHtUOd3YJQBiDlsfgjUF7w6nIiod4ropBVu8Xijr4cG/OHu5msbbUSCSRH6R2 KMQ6dUKbldb8CM/HYQ5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIUyJ-006RZB-LA; Mon, 01 Aug 2022 12:56:36 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIUwL-006QNp-Ky; Mon, 01 Aug 2022 12:54:38 +0000 X-UUID: 5749ccd285cc4b048a1c8c5cdd641e97-20220801 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:08f893ee-f2ad-4558-ad86-ea0ed2ebee59,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:0f94e32,CLOUDID:582ef224-a982-4824-82d2-9da3b6056c2a,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 5749ccd285cc4b048a1c8c5cdd641e97-20220801 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1701894477; Mon, 01 Aug 2022 05:54:27 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 1 Aug 2022 20:04:22 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 1 Aug 2022 20:04:21 +0800 Message-ID: <0085fdd057687637ebd5a7688897a279e72e03f6.camel@mediatek.com> Subject: Re: [PATCH v4 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number From: Yong Wu To: Tinghan Shen , Joerg Roedel , Will Deacon , Robin Murphy , "Rob Herring" , Krzysztof Kozlowski , Lee Jones , "Matthias Brugger" , AngeloGioacchino Del Regno , MandyJH Liu CC: , , , , , , Date: Mon, 1 Aug 2022 20:04:21 +0800 In-Reply-To: <20220729063208.16799-2-tinghan.shen@mediatek.com> References: <20220729063208.16799-1-tinghan.shen@mediatek.com> <20220729063208.16799-2-tinghan.shen@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_055433_826465_02D6E394 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-07-29 at 14:31 +0800, Tinghan Shen wrote: > mt8195 infra iommu uses 5 interrupts. > > Signed-off-by: Tinghan Shen > Reviewed-by: Krzysztof Kozlowski > --- > .../bindings/iommu/mediatek,iommu.yaml | 18 > +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > index fee0241b50988..5afe2a0045330 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > @@ -91,7 +91,8 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 5 > > clocks: > items: > @@ -191,9 +192,24 @@ allOf: > const: mediatek,mt8195-iommu-infra > > then: > + properties: > + interrupts: > + maxItems: 1 > + > required: > - mediatek,larbs > > + else: > + properties: > + interrupts: > + description: The IOMMU has 5 banks. Each bank has its own > interrupt. > + items: > + - description: The interrupt for IOMMU bank0 > + - description: The interrupt for IOMMU bank1 > + - description: The interrupt for IOMMU bank2 > + - description: The interrupt for IOMMU bank3 > + - description: The interrupt for IOMMU bank4 > + Thanks for improving this. Before the meaning for this segment is that it require "mediatek,larbs" if it is NOT infra iommu. Here we add a new block for infra iommu. then we'd better to remove the "not". this should be more readable. Something like below: if: /* Remove the not here. */ properties: compatible: contains: const: mediatek,mt8195-iommu-infra then: xxx else: xx > additionalProperties: false > > examples: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel