From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Kuehling Subject: Re: [PATCH 2/3] drm/amdgpu: Fix Vega10 VM initialization Date: Tue, 28 Mar 2017 21:48:04 -0400 Message-ID: <0091f779-a045-7009-3746-6957ccacd62f@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-3-git-send-email-Felix.Kuehling@amd.com> <58DB1061.7000403@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58DB1061.7000403-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zhang, Jerry (Junwei)" , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Christian.Koenig-5C7GfCeVMHo@public.gmane.org, David1.Zhou-5C7GfCeVMHo@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, Kent.Russell-5C7GfCeVMHo@public.gmane.org T24gMTctMDMtMjggMDk6MzkgUE0sIFpoYW5nLCBKZXJyeSAoSnVud2VpKSB3cm90ZToKPiBPbiAw My8yOS8yMDE3IDA5OjAwIEFNLCBGZWxpeCBLdWVobGluZyB3cm90ZToKPj4gYWRldi0+ZmFtaWx5 IGlzIG5vdCBpbml0aWFsaXplZCB5ZXQgd2hlbiBhbWRncHVfZ2V0X2Jsb2NrX3NpemUgaXMKPj4g Y2FsbGVkLiBVc2UgYWRldi0+YXNpY190eXBlIGluc3RlYWQuCj4+Cj4+IE1pbmltdW0gVk0gc2l6 ZSBpcyA1MTJHQiwgbm90IDI1NkdCLCBmb3IgYSBzaW5nbGUgcGFnZSB0YWJsZSBlbnRyeQo+PiBp biB0aGUgcm9vdCBwYWdlIHRhYmxlLgo+Pgo+PiBnbWNfdjlfMF92bV9pbml0IGlzIGNhbGxlZCBh ZnRlciBhZGV2LT52bV9tYW5hZ2VyLm1heF9wZm4gaXMKPj4gaW5pdGlhbGl6ZWQuIE1vdmUgdGhl IG1pbmltdW0gVk0tc2l6ZSBlbmZvcmNlbWVudCBhaGVhZCBvZiBtYXhfcGZuCj4+IGluaXRpYWxp enRpb24uIENhc3QgdG8gNjQtYml0IGJlZm9yZSB0aGUgbGVmdC1zaGlmdC4KPj4KPj4gU2lnbmVk LW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5jb20+Cj4gUmV2aWV3 ZWQtYnk6IEp1bndlaSBaaGFuZyA8SmVycnkuWmhhbmdAYW1kLmNvbT4KPgo+IEp1c3Qgbm90ZToK PiBGb3Igbm93LCBpdCdzIE9LIHRvIHNldCB0aGUgbWluaW11bSB2bSBzaXplIDI1NkcsCj4gSW4g dGhpcyBjYXNlLCB0aGVyZSBpcyBubyBQRCBiaXQgYW55d2F5LgoKV2l0aCBWTSBzaXplIG9mIDI1 NkdCLCB0aGUgYW1kZ3B1X3ZtX2JvX3NpemUoYWRldiwgMCkgY2FsY3VsYXRlcyAwLCBhbmQKdGhl IHBhZ2UgZGlyZWN0b3J5IGFsbG9jYXRpb24gd2l0aCBhbWRncHVfYm9fY3JlYXRlIGZhaWxzIGlu IGFtZGdwdV92bV9pbml0LgoKSW4gb3RoZXIgd29yZHMsIGFtZGdwdV92bV9udW1fZW50cmllcyhh ZGV2LCAwKSBuZWVkcyB0byByZXR1cm4gYXQgbGVhc3QKMS4gVGhhdCBtZWFucyB2bV9zaXplIG5l ZWRzIHRvIGJlIGF0IGxlYXN0IDUxMkdCLgoKUmVnYXJkcywKICBGZWxpeAoKPgo+IENocmlzdGlh biBhbHNvIG1lbnRpb25lZCB0aGF0IFBEIHNob3VsZCBiZSA0ayBzaXplLCB0aGVuIDI1NlQgd2Fz Cj4gcmVxdWlyZWQuCj4gV2hlbiByZWFjaCBhbiBhZ3JlZW1lbnQsIHdlIG1heSB1cGRhdGUgdGhl bSBhbGwuCj4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rl dmljZS5jIHwgIDYgKysrLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5 XzAuYyAgICAgIHwgMTcgKysrKysrKy0tLS0tLS0tLS0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDEw IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+IGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4+IGluZGV4IDM1MDBkYTMuLjU3Y2NhYzQgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPj4gQEAg LTEwNDIsMTAgKzEwNDIsMTAgQEAgc3RhdGljIGJvb2wgYW1kZ3B1X2NoZWNrX3BvdF9hcmd1bWVu dChpbnQgYXJnKQo+PiAgIHN0YXRpYyB2b2lkIGFtZGdwdV9nZXRfYmxvY2tfc2l6ZShzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldikKPj4gICB7Cj4+ICAgICAgIC8qIGZyb20gQUksIGFzaWMgc3Rh cnRzIHRvIHN1cHBvcnQgbXVsdGlwbGUgbGV2ZWwgVk1QVCAqLwo+PiAtICAgIGlmIChhZGV2LT5m YW1pbHkgPj0gQU1ER1BVX0ZBTUlMWV9BSSkgewo+PiArICAgIGlmIChhZGV2LT5hc2ljX3R5cGUg Pj0gQ0hJUF9WRUdBMTApIHsKPj4gICAgICAgICAgIGlmIChhbWRncHVfdm1fYmxvY2tfc2l6ZSAh PSA5KQo+PiAtICAgICAgICAgICAgZGV2X3dhcm4oYWRldi0+ZGV2LCAiTXVsdGktVk1QVCBsaW1p dHMgYmxvY2sgc2l6ZSB0byIKPj4gLSAgICAgICAgICAgICAgICAgIm9uZSBwYWdlIVxuIik7Cj4+ ICsgICAgICAgICAgICBkZXZfd2FybihhZGV2LT5kZXYsCj4+ICsgICAgICAgICAgICAgICAgICJN dWx0aS1WTVBUIGxpbWl0cyBibG9jayBzaXplIHRvIG9uZSBwYWdlIVxuIik7Cj4+ICAgICAgICAg ICBhbWRncHVfdm1fYmxvY2tfc2l6ZSA9IDk7Cj4+ICAgICAgICAgICByZXR1cm47Cj4+ICAgICAg IH0KPgo+IE5pY2UgY2F0Y2guCj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dtY192OV8wLmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlf MC5jCj4+IGluZGV4IDFlNDczNGQuLmRmNjlhYWUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2dtY192OV8wLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvZ21jX3Y5XzAuYwo+PiBAQCAtNTExLDEyICs1MTEsNiBAQCBzdGF0aWMgaW50IGdtY192 OV8wX3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UKPj4gKmFkZXYpCj4+ICAgICAgICAqIGFt ZGtmZCB3aWxsIHVzZSBWTUlEcyA4LTE1Cj4+ICAgICAgICAqLwo+PiAgICAgICBhZGV2LT52bV9t YW5hZ2VyLm51bV9pZHMgPSBBTURHUFVfTlVNX09GX1ZNSURTOwo+PiAtICAgIC8qIEJlY2F1c2Ug b2YgZm91ciBsZXZlbCBWTVBUcywgdm0gc2l6ZSBhdCBsZWFzdCBpcyAyNTZHQi4KPj4gLSAgICAy NTZUQiBpcyBPSyBhcyB3ZWxsICovCj4+IC0gICAgaWYgKGFtZGdwdV92bV9zaXplIDwgMjU2KSB7 Cj4+IC0gICAgICAgIERSTV9XQVJOKCJ2bSBzaXplIGF0IGxlYXN0IGlzIDI1NkdCIVxuIik7Cj4+ IC0gICAgICAgIGFtZGdwdV92bV9zaXplID0gMjU2Owo+PiAtICAgIH0KPgo+IERhdmlkIGhhZCBh IHBhdGNoIHRvIGZpeCBpdCB5ZXN0ZXJkYXkuCj4gQnV0IHlvdXIgcGF0Y2ggaW52b2x2ZXMgYnkg dm0gc2l6ZSBjaGVja2luZy4gOikKPgo+PiAgICAgICBhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZl bCA9IDM7Cj4+ICAgICAgIGFtZGdwdV92bV9tYW5hZ2VyX2luaXQoYWRldik7Cj4+Cj4+IEBAIC01 NjMsMTEgKzU1NywxNCBAQCBzdGF0aWMgaW50IGdtY192OV8wX3N3X2luaXQodm9pZCAqaGFuZGxl KQo+PiAgICAgICBpZiAocikKPj4gICAgICAgICAgIHJldHVybiByOwo+Pgo+PiAtICAgIC8qIEFk anVzdCBWTSBzaXplIGhlcmUuCj4+IC0gICAgICogQ3VycmVudGx5IGRlZmF1bHQgdG8gNjRHQiAo KDE2IDw8IDIwKSA0ayBwYWdlcykuCj4+IC0gICAgICogTWF4IEdQVVZNIHNpemUgaXMgNDggYml0 cy4KPj4gKyAgICAvKiBCZWNhdXNlIG9mIGZvdXIgbGV2ZWwgVk1QVHMsIHZtIHNpemUgaXMgYXQg bGVhc3QgNTEyR0IuCj4+ICsgICAgICogVGhlIG1heGltdW0gc2l6ZSBpcyAyNTZUQiAoNDhiaXQp Lgo+PiAgICAgICAgKi8KPj4gLSAgICBhZGV2LT52bV9tYW5hZ2VyLm1heF9wZm4gPSBhbWRncHVf dm1fc2l6ZSA8PCAxODsKPj4gKyAgICBpZiAoYW1kZ3B1X3ZtX3NpemUgPCA1MTIpIHsKPj4gKyAg ICAgICAgRFJNX1dBUk4oIlZNIHNpemUgaXMgYXQgbGVhc3QgNTEyR0IhXG4iKTsKPj4gKyAgICAg ICAgYW1kZ3B1X3ZtX3NpemUgPSA1MTI7Cj4+ICsgICAgfQo+PiArICAgIGFkZXYtPnZtX21hbmFn ZXIubWF4X3BmbiA9ICh1aW50NjRfdClhbWRncHVfdm1fc2l6ZSA8PCAxODsKPj4KPj4gICAgICAg LyogU2V0IHRoZSBpbnRlcm5hbCBNQyBhZGRyZXNzIG1hc2sKPj4gICAgICAgICogVGhpcyBpcyB0 aGUgbWF4IGFkZHJlc3Mgb2YgdGhlIEdQVSdzCj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK