From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139C7C4724C for ; Fri, 1 May 2020 08:49:11 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BBCA22076D for ; Fri, 1 May 2020 08:49:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBCA22076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7CAF1D9D9; Fri, 1 May 2020 10:49:09 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5D3331D9CF for ; Fri, 1 May 2020 10:49:08 +0200 (CEST) IronPort-SDR: jvQmr8LdXti6g6S3w8Li5LSblK6koNNAwScgIhGLAS7GAjr8lsQH6cE5Y1103PlA8CHLGWT0jn TNiI3fNlUf7A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 01:49:07 -0700 IronPort-SDR: v3cJOwPGCTf28ike5JpvfpJG9zIrQRPXp0aZiSclQx3e+QXedmMY6xAEJI93J6DDpyJ0uVn3yp P767Nz57QChg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,339,1583222400"; d="scan'208";a="459861907" Received: from unknown (HELO [10.213.228.47]) ([10.213.228.47]) by fmsmga005.fm.intel.com with ESMTP; 01 May 2020 01:49:06 -0700 To: David Christensen , dev@dpdk.org References: <20200429232931.87233-1-drc@linux.vnet.ibm.com> <20200429232931.87233-2-drc@linux.vnet.ibm.com> <5c626659-7d00-c527-bb07-cdf29eaa5ce1@linux.vnet.ibm.com> <2e86c130-6c69-8525-b130-3d784a30b234@intel.com> From: "Burakov, Anatoly" Message-ID: <0092059c-8eb7-9023-0c7b-ba9a8ff180e2@intel.com> Date: Fri, 1 May 2020 09:49:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30-Apr-20 6:38 PM, David Christensen wrote: >>>> Why is this needed? >>> >>> It's hardware specific to the PPC64 platform.  I don't know of a >>> situation where the IOMMU would be present on other hardware.  Even >>> running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 >>> IOMMU which isn't supported in DPDK. >>> >>> Dave >> >> Yes, but generally #ifdef's are there for detecting compile-time >> conditions. Is there anything specific to that code that would cause >> trouble when compiled on other platforms? > > No, I can't say that's the case, it's been operating this way for a while. > > Dave So no #ifdef's necessary then :) -- Thanks, Anatoly