All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tianyu Lan <ltykernel@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
	hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, davem@davemloft.net, kuba@kernel.org,
	gregkh@linuxfoundation.org, arnd@arndb.de, brijesh.singh@amd.com,
	jroedel@suse.de, Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com, rientjes@google.com, pgonda@google.com,
	akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
	rppt@kernel.org, saravanand@fb.com, aneesh.kumar@linux.ibm.com,
	hannes@cmpxchg.org, tj@kernel.org,
	michael.h.kelley@microsoft.com, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, vkuznets@redhat.com,
	konrad.wilk@oracle.com, hch@lst.de, robin.murphy@arm.com,
	joro@8bytes.org, parri.andrea@gmail.com, dave.hansen@intel.com
Subject: Re: [PATCH V8 5/9] x86/sev-es: Expose sev_es_ghcb_hv_call() to call ghcb hv call out of sev code
Date: Fri, 22 Oct 2021 21:39:48 +0800	[thread overview]
Message-ID: <00946764-7fe0-675f-7b3e-9fb3b8e3eb89@gmail.com> (raw)
In-Reply-To: <YXGTwppQ8syUyJ72@zn.tnic>

On 10/22/2021 12:22 AM, Borislav Petkov wrote:
> On Thu, Oct 21, 2021 at 11:41:05AM -0400, Tianyu Lan wrote:
>> diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c
>> index ea9abd69237e..368ed36971e3 100644
>> --- a/arch/x86/kernel/sev-shared.c
>> +++ b/arch/x86/kernel/sev-shared.c
>> @@ -124,10 +124,9 @@ static enum es_result verify_exception_info(struct ghcb *ghcb, struct es_em_ctxt
>>   	return ES_VMM_ERROR;
>>   }
>>   
>> -static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
>> -					  struct es_em_ctxt *ctxt,
>> -					  u64 exit_code, u64 exit_info_1,
>> -					  u64 exit_info_2)
>> +enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb, bool set_ghcb_msr,
>> +				   struct es_em_ctxt *ctxt, u64 exit_code,
>> +				   u64 exit_info_1, u64 exit_info_2)
>>   {
>>   	/* Fill in protocol and format specifiers */
>>   	ghcb->protocol_version = GHCB_PROTOCOL_MAX;
>> @@ -137,7 +136,15 @@ static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
>>   	ghcb_set_sw_exit_info_1(ghcb, exit_info_1);
>>   	ghcb_set_sw_exit_info_2(ghcb, exit_info_2);
>>   
>> -	sev_es_wr_ghcb_msr(__pa(ghcb));
>> +	/*
>> +	 * Hyper-V unenlightened guests use a paravisor for communicating and
>> +	 * GHCB pages are being allocated and set up by that paravisor. Linux
>> +	 * should not change ghcb page pa in such case and so add set_ghcb_msr
> 
> "... not change the GHCB page's physical address."
> 
> Remove the "so add... " rest.
> 
> Otherwise, LGTM.
> 
> Do you want me to take it through the tip tree?

Yes, please and this patch is based on the your clean up patch which is 
already in the tip sev branch.

  reply	other threads:[~2021-10-22 13:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 15:41 [PATCH V8 0/9] x86/Hyper-V: Add Hyper-V Isolation VM support(First part) Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 1/9] x86/hyperv: Initialize GHCB page in Isolation VM Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 2/9] x86/hyperv: Initialize shared memory boundary in the " Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 3/9] x86/hyperv: Add new hvcall guest address host visibility support Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 4/9] Drivers: hv: vmbus: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 5/9] x86/sev-es: Expose sev_es_ghcb_hv_call() to call ghcb hv call out of sev code Tianyu Lan
2021-10-21 16:22   ` Borislav Petkov
2021-10-22 13:39     ` Tianyu Lan [this message]
2021-10-25 11:20       ` Wei Liu
2021-10-25 11:24         ` Borislav Petkov
2021-10-25 12:27           ` Tianyu Lan
2021-10-25 16:37             ` Borislav Petkov
2021-10-25 20:54               ` Wei Liu
2021-10-22 13:37   ` [PATCH V8.1 " Tianyu Lan
2021-10-22 20:58     ` Michael Kelley
2021-10-23 17:29       ` Borislav Petkov
2021-10-21 15:41 ` [PATCH V8 6/9] x86/hyperv: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 7/9] x86/hyperv: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 8/9] Drivers: hv: vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-10-21 15:41 ` [PATCH V8 9/9] Drivers: hv : vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-10-22 13:47 ` [PATCH V8.1 6/9] x86/hyperv: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-10-22 21:25 ` [PATCH V8 0/9] x86/Hyper-V: Add Hyper-V Isolation VM support(First part) Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00946764-7fe0-675f-7b3e-9fb3b8e3eb89@gmail.com \
    --to=ltykernel@gmail.com \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=michael.h.kelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pgonda@google.com \
    --cc=rientjes@google.com \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=saravanand@fb.com \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tj@kernel.org \
    --cc=vkuznets@redhat.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.