From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbbBBDAf (ORCPT ); Sun, 1 Feb 2015 22:00:35 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:60934 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754601AbbBBDAe (ORCPT ); Sun, 1 Feb 2015 22:00:34 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-93-54cee84f13f0 From: Chao Yu To: "'Jaegeuk Kim'" , "'Changman Lee'" Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <006201d0392c$43741650$ca5c42f0$@samsung.com> In-reply-to: <006201d0392c$43741650$ca5c42f0$@samsung.com> Subject: RE: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache Date: Mon, 02 Feb 2015 10:59:28 +0800 Message-id: <009c01d03e94$685cab90$391602b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQHeC3VVwRvXuQkOdHm1Sw+I2UhnIJzBEEsQ Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t9jAV3/F+dCDC6+trS4tq+RyeLJ+lnM FpcWuVtc3jWHzYHFY9OqTjaP3Qs+M3n0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxotTV1gL LnNVXFsr2MB4naOLkZNDQsBE4seGnewQtpjEhXvr2boYuTiEBBYxSqxpmsAK4fxglHix6jQz SBWbgIrE8o7/TCC2iICfxPT7X4E6ODiYBTwkdh0rBQkLCVhKTPreCVbCKWAlMXHBVDBbWCBG Yu2812wgNouAqsS8VU0sIDYvUP2sCdvZIWxBiR+T74HFmQW0JNbvPM4EYctLbF7zlhniUAWJ HWdfM0KcYCTR9fkUG0SNuMTGI7dYJjAKzUIyahaSUbOQjJqFpGUBI8sqRtHUguSC4qT0XCO9 4sTc4tK8dL3k/NxNjOAIeCa9g3FVg8UhRgEORiUe3gWXz4YIsSaWFVfmHmKU4GBWEuHdXHcu RIg3JbGyKrUoP76oNCe1+BCjNAeLkjivkn1biJBAemJJanZqakFqEUyWiYNTqoGxaK37bZ/q N3GKT97bLw9aueh+oLmFo8W9czvXXvih7NOwYNZtR6tZZfrSU64Y/n9zwG7HGg3L0tcxi7cI 7pmmN5/xgPWtdf9uJzBJ3/y5Z5JTp9fPq1Zvjl76cb2s9H7J7N3n/3wsSTlY+d1xUZOF6W71 oL5jdie2f1NMNzvu7bZngeE14ZibqUosxRmJhlrMRcWJAFF0/tB8AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, > -----Original Message----- > From: Chao Yu [mailto:chao2.yu@samsung.com] > Sent: Monday, January 26, 2015 1:52 PM > To: Jaegeuk Kim; Changman Lee > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache > > This patch adds core functions including slab cache init function and > init/lookup/update/shrink/destroy function for rb-tree based extent cache. > > Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail > design and implementation of extent cache. > > Todo: > * add a cached_ei into struct extent_tree for a quick recent cache. > * register rb-based extent cache shrink with mm shrink interface. > * disable dir inode's extent cache. > > v2: > o move set_extent_info and __is_{extent,back,front}_mergeable into f2fs.h. > o introduce __{attach,detach}_extent_node for code readability. > o use f2fs_kmem_cache_alloc/f2fs_radix_tree_insert for code readability. > o fix some coding style and typo issues. > o get rid of node/tree count stat in f2fs_{shrink,destroy}_extent_tree. > There is an obviously bug in this patch, with it we will encounter an oops easily, My mistaken, Please ignore this patch set, sorry for the noise. :( I will send a v3 later. Thanks,