From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D2DC32771 for ; Thu, 9 Jan 2020 09:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB3B2206ED for ; Thu, 9 Jan 2020 09:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="tljAdzLx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbgAIJIJ (ORCPT ); Thu, 9 Jan 2020 04:08:09 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:23198 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728782AbgAIJIJ (ORCPT ); Thu, 9 Jan 2020 04:08:09 -0500 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 009943ki002842; Thu, 9 Jan 2020 10:07:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=is6x6Xsavc4DrmaKIz9Vu39SoGM1pxSmkBDyOwyjfa0=; b=tljAdzLxNcuZNYbois3hdLfVjFYmM+a7XJR2qA4cbheXmLFBmwcvO4Tyd2PSUhPfrtUP dGkXZNfXXiMRik0oqLpd8MMkk8w2vph+qXFWX5RpZTzayz/MwKQUvtzaBUn9oB6DT/Xm fVEv5X/L+HfQinfv8d96XpjqpEwy/iu0DE07SVJbdbPA87ilcpoRnzVpAXrYHE5Ni44y DJi6tT4FeDBqo7qcL13pXZdGwr4mzsDAarBKJ4WnFg3E+4MH/wyWFxBwMPYr+oBUvd4n G3fWAxEmEzxBt2tq0Ajwg2Ez0Tt/KIWcBff3mLkHMpLMYIQAOsvVE1LNdaplPElsnl3P 1Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2xakm5rk43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2020 10:07:35 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A573A10003B; Thu, 9 Jan 2020 10:07:32 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node3.st.com [10.75.127.9]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 84DD02A4D87; Thu, 9 Jan 2020 10:07:32 +0100 (CET) Received: from SFHDAG5NODE3.st.com (10.75.127.15) by SFHDAG3NODE3.st.com (10.75.127.9) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Jan 2020 10:07:32 +0100 Received: from SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47]) by SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47%20]) with mapi id 15.00.1473.003; Thu, 9 Jan 2020 10:07:32 +0100 From: Christophe ROULLIER To: Maxime Ripard CC: "davem@davemloft.net" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "martin.blumenstingl@googlemail.com" , "alexandru.ardelean@analog.com" , "narmstrong@baylibre.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties Thread-Topic: [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties Thread-Index: AQHVljS9qESSyYnraEKgryyZ/0O5A6eL1WwAgFaFz4A= Date: Thu, 9 Jan 2020 09:07:32 +0000 Message-ID: <009e8c0e-6a72-7e14-699e-8a897199ae16@st.com> References: <20191108103526.22254-1-christophe.roullier@st.com> <20191108103526.22254-2-christophe.roullier@st.com> <20191108104231.GE4345@gilmour.lan> <20191115075008.GY4345@gilmour.lan> In-Reply-To: <20191115075008.GY4345@gilmour.lan> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.51] Content-Type: text/plain; charset="Windows-1252" Content-ID: <23EE773BFEB22B40A7851F2EFDD3C50A@st.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-01-09_02:2020-01-08,2020-01-09 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/2019 08:50, Maxime Ripard wrote: > On Fri, Nov 08, 2019 at 01:02:14PM +0000, Christophe ROULLIER wrote: >> On 11/8/19 11:42 AM, Maxime Ripard wrote: >>> Hi, >>> >>> On Fri, Nov 08, 2019 at 11:35:25AM +0100, Christophe Roullier wrote: >>>> This change is needed for some soc based on snps,dwmac, which have >>>> more than 3 clocks. >>>> >>>> Signed-off-by: Christophe Roullier >>>> --- >>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/D= ocumentation/devicetree/bindings/net/snps,dwmac.yaml >>>> index 4845e29411e4..376a531062c2 100644 >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> @@ -27,6 +27,7 @@ select: >>>> - snps,dwmac-3.710 >>>> - snps,dwmac-4.00 >>>> - snps,dwmac-4.10a >>>> + - snps,dwmac-4.20a >>>> - snps,dwxgmac >>>> - snps,dwxgmac-2.10 >>>> >>>> @@ -62,6 +63,7 @@ properties: >>>> - snps,dwmac-3.710 >>>> - snps,dwmac-4.00 >>>> - snps,dwmac-4.10a >>>> + - snps,dwmac-4.20a >>>> - snps,dwxgmac >>>> - snps,dwxgmac-2.10 >>>> >>>> @@ -87,7 +89,8 @@ properties: >>>> >>>> clocks: >>>> minItems: 1 >>>> - maxItems: 3 >>>> + maxItems: 5 >>>> + additionalItems: true >>> Those additional clocks should be documented >>> >>> Maxime >> Hi Maxime, >> >> The problem it is specific to our soc, so is it possible to >> >> propose "optional clock" for 2 extras clocks in snps,dwmac.yaml >> >> and "official" description in soc yaml file (stm32-dwmac.yaml) ? >> >> =A0 clocks: >> =A0=A0=A0 minItems: 1 >> =A0=A0=A0 maxItems: 5 >> =A0=A0=A0 additionalItems: true >> =A0=A0=A0 items: >> =A0=A0=A0=A0=A0 - description: GMAC main clock >> =A0=A0=A0=A0=A0 - description: Peripheral registers interface clock >> =A0=A0=A0=A0=A0 - description: >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 PTP reference clock. This clock is used fo= r programming the >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 Timestamp Addend Register. If not passed t= hen the system >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 clock will be used and this is fine on som= e platforms. >> >> +=A0=A0=A0=A0=A0 - description: optional clock >> >> +=A0=A0=A0=A0=A0 - description: optional clock > I guess we'd really need to figure out what those clocks are doing, > they are probably helpful (and used, under a different name) by > others. > > Hopefully the questions Rob asked will clear that out Rob, do you have any ideas, suggestions ? Thanks > Maxime= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A97C32771 for ; Thu, 9 Jan 2020 09:08:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35FD120673 for ; Thu, 9 Jan 2020 09:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LP4XDq1v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="tljAdzLx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35FD120673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nf4/K8a8hOc2eUx/P7jJosRe5T9M+g4Qfw1IJt52QoA=; b=LP4XDq1vz6iPZb rF7b4Qltv3vR8JgL4DVyORqhxn8hLfKSSQWkkQhKp/f5P6zwltuzdgtodDiWnTu2j3nNvPxYU56Tw wQCPgXQDUKqF41qMgUy1HHRG/WyW5dlEQKlR/45E12Gkkbbobsyo14J6c6YtTn5BQuakittQ1vg/x /CShEBUILO21D/FlqSOrfQI+pFORSJ261mQ3fz8dekJns1YdtjxPffpOZxYRL8bLZjN/SUtjsY27a sm4lNsuxKNfrKRWYHOeKRvEDf2GLqzsp/ZuFhzE+C+ncMJrPbsjWfbXxuB/+iSUiu2ux/qXVZHy67 8r60dV0OSoVtixwjGj7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipTnQ-00042O-Ut; Thu, 09 Jan 2020 09:08:04 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipTnM-0003wO-Ie for linux-arm-kernel@lists.infradead.org; Thu, 09 Jan 2020 09:08:02 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 009943ki002842; Thu, 9 Jan 2020 10:07:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=is6x6Xsavc4DrmaKIz9Vu39SoGM1pxSmkBDyOwyjfa0=; b=tljAdzLxNcuZNYbois3hdLfVjFYmM+a7XJR2qA4cbheXmLFBmwcvO4Tyd2PSUhPfrtUP dGkXZNfXXiMRik0oqLpd8MMkk8w2vph+qXFWX5RpZTzayz/MwKQUvtzaBUn9oB6DT/Xm fVEv5X/L+HfQinfv8d96XpjqpEwy/iu0DE07SVJbdbPA87ilcpoRnzVpAXrYHE5Ni44y DJi6tT4FeDBqo7qcL13pXZdGwr4mzsDAarBKJ4WnFg3E+4MH/wyWFxBwMPYr+oBUvd4n G3fWAxEmEzxBt2tq0Ajwg2Ez0Tt/KIWcBff3mLkHMpLMYIQAOsvVE1LNdaplPElsnl3P 1Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2xakm5rk43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2020 10:07:35 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A573A10003B; Thu, 9 Jan 2020 10:07:32 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node3.st.com [10.75.127.9]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 84DD02A4D87; Thu, 9 Jan 2020 10:07:32 +0100 (CET) Received: from SFHDAG5NODE3.st.com (10.75.127.15) by SFHDAG3NODE3.st.com (10.75.127.9) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Jan 2020 10:07:32 +0100 Received: from SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47]) by SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47%20]) with mapi id 15.00.1473.003; Thu, 9 Jan 2020 10:07:32 +0100 From: Christophe ROULLIER To: Maxime Ripard Subject: Re: [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties Thread-Topic: [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties Thread-Index: AQHVljS9qESSyYnraEKgryyZ/0O5A6eL1WwAgFaFz4A= Date: Thu, 9 Jan 2020 09:07:32 +0000 Message-ID: <009e8c0e-6a72-7e14-699e-8a897199ae16@st.com> References: <20191108103526.22254-1-christophe.roullier@st.com> <20191108103526.22254-2-christophe.roullier@st.com> <20191108104231.GE4345@gilmour.lan> <20191115075008.GY4345@gilmour.lan> In-Reply-To: <20191115075008.GY4345@gilmour.lan> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.51] Content-ID: <23EE773BFEB22B40A7851F2EFDD3C50A@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-09_02:2020-01-08, 2020-01-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_010801_082370_BA4D414A X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Alexandre TORGUE , "narmstrong@baylibre.com" , "martin.blumenstingl@googlemail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "robh+dt@kernel.org" , "mcoquelin.stm32@gmail.com" , "alexandru.ardelean@analog.com" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/11/2019 08:50, Maxime Ripard wrote: > On Fri, Nov 08, 2019 at 01:02:14PM +0000, Christophe ROULLIER wrote: >> On 11/8/19 11:42 AM, Maxime Ripard wrote: >>> Hi, >>> >>> On Fri, Nov 08, 2019 at 11:35:25AM +0100, Christophe Roullier wrote: >>>> This change is needed for some soc based on snps,dwmac, which have >>>> more than 3 clocks. >>>> >>>> Signed-off-by: Christophe Roullier >>>> --- >>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/D= ocumentation/devicetree/bindings/net/snps,dwmac.yaml >>>> index 4845e29411e4..376a531062c2 100644 >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> @@ -27,6 +27,7 @@ select: >>>> - snps,dwmac-3.710 >>>> - snps,dwmac-4.00 >>>> - snps,dwmac-4.10a >>>> + - snps,dwmac-4.20a >>>> - snps,dwxgmac >>>> - snps,dwxgmac-2.10 >>>> >>>> @@ -62,6 +63,7 @@ properties: >>>> - snps,dwmac-3.710 >>>> - snps,dwmac-4.00 >>>> - snps,dwmac-4.10a >>>> + - snps,dwmac-4.20a >>>> - snps,dwxgmac >>>> - snps,dwxgmac-2.10 >>>> >>>> @@ -87,7 +89,8 @@ properties: >>>> >>>> clocks: >>>> minItems: 1 >>>> - maxItems: 3 >>>> + maxItems: 5 >>>> + additionalItems: true >>> Those additional clocks should be documented >>> >>> Maxime >> Hi Maxime, >> >> The problem it is specific to our soc, so is it possible to >> >> propose "optional clock" for 2 extras clocks in snps,dwmac.yaml >> >> and "official" description in soc yaml file (stm32-dwmac.yaml) ? >> >> =A0 clocks: >> =A0=A0=A0 minItems: 1 >> =A0=A0=A0 maxItems: 5 >> =A0=A0=A0 additionalItems: true >> =A0=A0=A0 items: >> =A0=A0=A0=A0=A0 - description: GMAC main clock >> =A0=A0=A0=A0=A0 - description: Peripheral registers interface clock >> =A0=A0=A0=A0=A0 - description: >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 PTP reference clock. This clock is used fo= r programming the >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 Timestamp Addend Register. If not passed t= hen the system >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 clock will be used and this is fine on som= e platforms. >> >> +=A0=A0=A0=A0=A0 - description: optional clock >> >> +=A0=A0=A0=A0=A0 - description: optional clock > I guess we'd really need to figure out what those clocks are doing, > they are probably helpful (and used, under a different name) by > others. > > Hopefully the questions Rob asked will clear that out Rob, do you have any ideas, suggestions ? Thanks > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel