From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FCBBC433F5 for ; Tue, 10 May 2022 10:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KxFMourciLPauFtvgGuIh5N6N+2EhGK2a7812h8HIjw=; b=fdcQRefAAnlDEl CXzj5uR5yFSirPLrdalo0xbFXZdRZWeByShEOqfwnnh7s3bT/iPMk3n1BcMucLhH+SHr6AOhq1zbk aCBelTZ9zlA1x1ExpqCoLpiQvCVb4N+hUuVU/mAdG3xJNGYFMydwzPLknuu5Ket1/rvqd8Ofk4tdP 4TeYeqQnz4goFAZYJtFpxlqz9AlQR/4CEHDBymn47b4Ba1udGtkDAF41qRdkA05IVZX6PkSi0nZEL /n6CBJo1t+RkVGE+JuPxfzJQdRCZyJtrxzBUXbEKI1pcwr3fQvEKzN/tqOcYNqsNcgf4IYjtWwrh6 SJ0l+F2yv0OxsQoKmCeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNHA-001Gzh-SX; Tue, 10 May 2022 10:39:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNH7-001GwM-OG for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 10:39:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4172B11FB; Tue, 10 May 2022 03:39:23 -0700 (PDT) Received: from [10.57.4.233] (unknown [10.57.4.233]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79EA63F66F; Tue, 10 May 2022 03:39:21 -0700 (PDT) Message-ID: <00abb0c5-6360-0004-353f-e7a88b3bd22c@arm.com> Date: Tue, 10 May 2022 11:39:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 1/4] arm64: vdso: put ELF related sections in the linker script Content-Language: en-US To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: nd@arm.com, catalin.marinas@arm.com, keescook@chromium.org, masahiroy@kernel.org, will@kernel.org References: <20220510095834.32394-1-joey.gouly@arm.com> <20220510095834.32394-2-joey.gouly@arm.com> From: Vincenzo Frascino In-Reply-To: <20220510095834.32394-2-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_033929_888535_347CF13F X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joey, On 5/10/22 10:58, Joey Gouly wrote: > Use macros from vmlinux.lds.h to explicitly name sections that are included > in the VDSO output. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Masahiro Yamada > Cc: Vincenzo Frascino > Cc: Kees Cook > Reviewed-by: Kees Cook > Reviewed-by: Vincenzo Frascino As a general rule, when you make a consistent change to a patch that was previously reviewed you should drop the "Reviewed-by:" tag as an indication that the patch needs to be reviewed again. > --- > arch/arm64/kernel/vdso/vdso.lds.S | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S > index a5e61e09ea92..1cd85258c079 100644 > --- a/arch/arm64/kernel/vdso/vdso.lds.S > +++ b/arch/arm64/kernel/vdso/vdso.lds.S > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > OUTPUT_FORMAT("elf64-littleaarch64", "elf64-bigaarch64", "elf64-littleaarch64") > OUTPUT_ARCH(aarch64) > @@ -49,11 +50,26 @@ SECTIONS > > .dynamic : { *(.dynamic) } :text :dynamic > > + .rela.dyn : ALIGN(8) { *(.rela .rela*) } > + > + .plt : { > + *(.plt) > + *(.plt.*) > + *(.iplt) > + *(.igot .igot.plt) > + } > + > + .got : { *(.got) } > + .got.plt : { *(.got.plt) } > + The vDSO library does not contain absolute relocations. Is there any specific reason why these sections are not part of ".rodata"? Please refer to: lib/vdso/Makefile Note: A similar comment applies to vdso32. > .rodata : { *(.rodata*) } :text > > _end = .; > PROVIDE(end = .); > > + DWARF_DEBUG > + ELF_DETAILS > + > /DISCARD/ : { > *(.data .data.* .gnu.linkonce.d.* .sdata*) > *(.bss .sbss .dynbss .dynsbss) -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel