From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH v9 2/2] config: enable vhost numa awareness by default Date: Thu, 29 Jun 2017 11:01:18 +0530 Message-ID: <00ad83eb-ba59-2e99-2508-4d6fc819f535@nxp.com> References: <1498553186-24541-1-git-send-email-i.maximets@samsung.com> <1498559080-27331-1-git-send-email-i.maximets@samsung.com> <1498559080-27331-3-git-send-email-i.maximets@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei , Bruce Richardson , Jerin Jacob To: Ilya Maximets , , David Marchand , Sergio Gonzalez Monroy , Thomas Monjalon Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0048.outbound.protection.outlook.com [104.47.36.48]) by dpdk.org (Postfix) with ESMTP id CDF3929CA for ; Thu, 29 Jun 2017 07:31:32 +0200 (CEST) In-Reply-To: <1498559080-27331-3-git-send-email-i.maximets@samsung.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/27/2017 3:54 PM, Ilya Maximets wrote: > It is safe to enable LIBRTE_VHOST_NUMA by default for all > configurations where libnuma is already a default dependency. > > DPDK_DEP_NUMA not needed anymore. > > Signed-off-by: Ilya Maximets > --- > config/common_linuxapp | 1 + > config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 + > devtools/test-build.sh | 4 ---- > 4 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 64bef87..74c7d64 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -42,6 +42,7 @@ CONFIG_RTE_KNI_KMOD=y > CONFIG_RTE_LIBRTE_KNI=y > CONFIG_RTE_LIBRTE_PMD_KNI=y > CONFIG_RTE_LIBRTE_VHOST=y > +CONFIG_RTE_LIBRTE_VHOST_NUMA=y > CONFIG_RTE_LIBRTE_PMD_VHOST=y > CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y > CONFIG_RTE_LIBRTE_PMD_TAP=y > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc > index e06b1d4..00bc2ab 100644 > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > @@ -49,6 +49,7 @@ CONFIG_RTE_TOOLCHAIN_GCC=y > > # NUMA is not supported on ARM > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n > +CONFIG_RTE_LIBRTE_VHOST_NUMA=n > > # ARM doesn't have support for vmware TSC map > CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n > diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc > index f78449d..b061fb0 100644 > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > @@ -47,6 +47,7 @@ CONFIG_RTE_PKTMBUF_HEADROOM=256 > > # Doesn't support NUMA > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > +CONFIG_RTE_LIBRTE_VHOST_NUMA=n > > # > # Compile Support Libraries for DPAA2 > diff --git a/devtools/test-build.sh b/devtools/test-build.sh > index 61bdce7..0dbc04a 100755 > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -41,7 +41,6 @@ default_path=$PATH > # - DPDK_DEP_ISAL_CRYPTO (y/[n]) > # - DPDK_DEP_LDFLAGS > # - DPDK_DEP_MOFED (y/[n]) > -# - DPDK_DEP_NUMA (y/[n]) > # - DPDK_DEP_PCAP (y/[n]) > # - DPDK_DEP_SSL (y/[n]) > # - DPDK_DEP_SZE (y/[n]) > @@ -124,7 +123,6 @@ reset_env () > unset DPDK_DEP_ISAL_CRYPTO > unset DPDK_DEP_LDFLAGS > unset DPDK_DEP_MOFED > - unset DPDK_DEP_NUMA > unset DPDK_DEP_PCAP > unset DPDK_DEP_SSL > unset DPDK_DEP_SZE > @@ -163,8 +161,6 @@ config () # > sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config ) > > # Automatic configuration > - test "$DPDK_DEP_NUMA" != y || \ > - sed -ri 's,(NUMA=)n,\1y,' $1/.config > sed -ri 's,(LIBRTE_IEEE1588=)n,\1y,' $1/.config > sed -ri 's,(BYPASS=)n,\1y,' $1/.config > test "$DPDK_DEP_ARCHIVE" != y || \ > Acked-by: Hemant Agrawal