From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBBFC433E0 for ; Fri, 29 May 2020 03:34:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 628D820723 for ; Fri, 29 May 2020 03:34:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marek-ca.20150623.gappssmtp.com header.i=@marek-ca.20150623.gappssmtp.com header.b="chanZ80S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436607AbgE2DeI (ORCPT ); Thu, 28 May 2020 23:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436594AbgE2DeH (ORCPT ); Thu, 28 May 2020 23:34:07 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CCFAC08C5C7 for ; Thu, 28 May 2020 20:34:06 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id s1so1024338qkf.9 for ; Thu, 28 May 2020 20:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tyQ6R9zPHdER38OPNGcXMf3Y34VIQ+4iMgNDMwi1+Qw=; b=chanZ80SvsBSV9iu/NMRLWDs1dH98echwP5mSuqC77tdDqO6ptpp8qxA8IbcsnnpLu 3oWFPxTPCQ5Mvwlnq2b9gBoH0VNKPTMlL7cVEqawqpZyg4Om8gHVSQNsKqjk0ZiAZHsk qhsp4yfD1QM3KHvEZpRY6BvKR44u55vFVDOLAPbj6Tk/I3ExEijsOJVEgJ+wp6wzUo4J HNnWA0UDqaQi+Bo58fvxGRADorC1VX71HGnmqTKO0D7Qo3TIYB/M29Ns8+ErYoVWP9U4 enwrn62aA5MDh77UQEi5SP12CiFhvD9OPpMiBn7uBUO01ViJUM8NbuxManbqTI7RhGPo Zejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tyQ6R9zPHdER38OPNGcXMf3Y34VIQ+4iMgNDMwi1+Qw=; b=BYSUam2CHFmAPo+XChso1V86CMgIMETDZ7bt9NPA113Ne3egALpyj6iW6H7qxsqk4H wH5hzkIztDSS9Ssxgez2JQt00+fm3jz081rUivqNcjfJreaVZf7yxfj1/NtshcIM4cS/ MW1YgqgnYnvvOZD+qt4KRDDWhdR+Badb+2cTLmWh9HuHrjwRZfZv4oRWNJqydcGCc24y taZxTdL/jIsQMei7kQVy067OtaoFFDTnUwQrmmWz6elUlMGRhOGO+0ZPstQcrbITaiUv 82rdHlPzIbGId2xlDarMLmbIyMPhZ4ncIHvHwvTktwjiNQS49KquvsdzbRYc8A1FagBQ jEuA== X-Gm-Message-State: AOAM5311KCgrLXIDdgptNuOZH/eTfxKVoJ2rL0NCp+/ghNU12oMdk85R VCbhU6R/zZJpz3FEuyh9F7x2Lw== X-Google-Smtp-Source: ABdhPJyNBvf7yQNlqfR7BUIySX4hvebQsf08XCpr8wNvefEY+MuD3uSVtBJuRPWV2ryJcH/paqdzAg== X-Received: by 2002:a37:af02:: with SMTP id y2mr6149497qke.389.1590723245397; Thu, 28 May 2020 20:34:05 -0700 (PDT) Received: from [192.168.0.189] ([147.253.86.153]) by smtp.gmail.com with ESMTPSA id e16sm7305168qtc.71.2020.05.28.20.34.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 20:34:05 -0700 (PDT) Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20200524023815.21789-1-jonathan@marek.ca> <20200524023815.21789-2-jonathan@marek.ca> <20200529025246.GV279327@builder.lan> <20200529031520.GA1799770@builder.lan> From: Jonathan Marek Message-ID: <00b8f010-1ae1-45b2-8dd0-a1b582861a2e@marek.ca> Date: Thu, 28 May 2020 23:34:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200529031520.GA1799770@builder.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/28/20 11:15 PM, Bjorn Andersson wrote: > On Thu 28 May 20:02 PDT 2020, Jonathan Marek wrote: > >> >> >> On 5/28/20 10:52 PM, Bjorn Andersson wrote: >>> On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: >>> >>>> Add the apps_smmu node for sm8150. Note that adding the iommus field for >>>> UFS is required because initializing the iommu removes the bypass mapping >>>> that created by the bootloader. >>>> >>> >>> Unrelated to the patch itself; how do you disable the splash screen on >>> 8150? "fastboot oem select-display-panel none" doesn't seem to work for >>> me on the MTP - and hence this would prevent my device from booting. >>> >>> Thanks, >>> Bjorn >>> >> >> I don't have a MTP, but on HDK855, "fastboot oem select-display-panel none" >> combined with setting the physical switch to HDMI mode (which switches off >> the 1440x2560 panel) gets it to not setup the display at all (just the >> fastboot command isn't enough). >> > > Okay, I don't think we have anything equivalent on the MTP, but good to > know. > >> With HDK865 though that doesn't work and I have a hack to work around it >> (writing 0 to INTF_TIMING_ENGINE_EN early on in boot will stop video mode >> scanout and it won't crash). >> > > Then we need to sort this out in the arm-smmu driver before we can > enable the apps_smmu node on 8250. I did receive some guidance from Will > on the subject and have started looking into this. > That's annoying because a lot depends on apps_mmu. GPU is an exception with its own MMU but pretty much everything else uses apps_smmu (does it make sense to add USB nodes if it won't work without apps_smmu?) Is this something that will get resolved soon? FWIW, I have another sm8250 board which does not need the workaround (its bootloader does not set up the display). AFAIK modifying the bootloader to not set up any display is a trivial modification (assuming that's an option). > Thanks, > Bjorn > >>>> Signed-off-by: Jonathan Marek >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 91 ++++++++++++++++++++++++++++ >>>> 1 file changed, 91 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi >>>> index a36512d1f6a1..acb839427b12 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi >>>> @@ -442,6 +442,8 @@ ufs_mem_hc: ufshc@1d84000 { >>>> resets = <&gcc GCC_UFS_PHY_BCR>; >>>> reset-names = "rst"; >>>> + iommus = <&apps_smmu 0x300 0>; >>>> + >>>> clock-names = >>>> "core_clk", >>>> "bus_aggr_clk", >>>> @@ -706,6 +708,7 @@ usb_1_dwc3: dwc3@a600000 { >>>> compatible = "snps,dwc3"; >>>> reg = <0 0x0a600000 0 0xcd00>; >>>> interrupts = ; >>>> + iommus = <&apps_smmu 0x140 0>; >>>> snps,dis_u2_susphy_quirk; >>>> snps,dis_enblslpm_quirk; >>>> phys = <&usb_1_hsphy>, <&usb_1_ssphy>; >>>> @@ -742,6 +745,94 @@ spmi_bus: spmi@c440000 { >>>> cell-index = <0>; >>>> }; >>>> + apps_smmu: iommu@15000000 { >>>> + compatible = "qcom,sdm845-smmu-500", "arm,mmu-500"; >>>> + reg = <0 0x15000000 0 0x100000>; >>>> + #iommu-cells = <2>; >>>> + #global-interrupts = <1>; >>>> + interrupts = , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + , >>>> + ; >>>> + }; >>>> + >>>> remoteproc_adsp: remoteproc@17300000 { >>>> compatible = "qcom,sm8150-adsp-pas"; >>>> reg = <0x0 0x17300000 0x0 0x4040>; >>>> -- >>>> 2.26.1 >>>>