All of lore.kernel.org
 help / color / mirror / Atom feed
From: 김승철 <sc377.kim@samsung.com>
To: <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sc377.kim@samsung.com>
Subject: [PATCH] media: v4l2-fh: define v4l2_fh struct regardless of condition
Date: Fri, 20 Mar 2020 18:55:58 +0900	[thread overview]
Message-ID: <00c001d5fe9d$c19bee40$44d3cac0$@samsung.com> (raw)
In-Reply-To: CGME20200320095559epcas2p2732ccb391573ba99e2dd08d6c50a18f2@epcas2p2.samsung.com

v4l2_fh struct define differently by CONFIG_V4L2_MEM2MEM_DEV.
If some vendors use CONFIG_V4L2_MEM2MEM_DEV by module,
it can make the mismatch of v4l2_fh sturct.

By the mismatch, the following error occurs.
===============================
[    7.533506] v4l2_mem2mem: disagrees about version of symbol video_devdata
[    7.533594] v4l2_mem2mem: Unknown symbol video_devdata (err -22)
[    7.535319] v4l2_mem2mem: disagrees about version of symbol
v4l2_event_pending
[    7.542532] v4l2_mem2mem: Unknown symbol v4l2_event_pending (err -22)
===============================

So v4l2_fh struct is modified to does not have dependency
for CONFIG_V4L2_MEM2MEM_DEV.

Signed-off-by: Seungchul Kim <sc377.kim@samsung.com>
---
 include/media/v4l2-fh.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h
index 53b4dbb..b5b3e00 100644
--- a/include/media/v4l2-fh.h
+++ b/include/media/v4l2-fh.h
@@ -53,9 +53,7 @@ struct v4l2_fh {
 	unsigned int		navailable;
 	u32			sequence;
 
-#if IS_ENABLED(CONFIG_V4L2_MEM2MEM_DEV)
 	struct v4l2_m2m_ctx	*m2m_ctx;
-#endif
 };
 
 /**
-- 
2.7.4


       reply	other threads:[~2020-03-20  9:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200320095559epcas2p2732ccb391573ba99e2dd08d6c50a18f2@epcas2p2.samsung.com>
2020-03-20  9:55 ` 김승철 [this message]
     [not found] <CGME20200326091732epcas2p2be24b70dca0039b10b828e8b9102f6bf@epcas2p2.samsung.com>
2020-03-26  9:09 ` [PATCH] media: v4l2-fh: define v4l2_fh struct regardless of condition Seungchul Kim
     [not found] <CGME20200323023045epcas2p12007502edd2a65efcccb00eb899d5532@epcas2p1.samsung.com>
2020-03-23  2:30 ` Seungchul Kim
2020-03-25  8:59   ` Greg KH
2020-03-25 16:54   ` Hans Verkuil
2020-03-26  2:30     ` Seungchul Kim
2020-03-26  8:16       ` Hans Verkuil
2020-03-26  9:13         ` Seungchul Kim
     [not found] <CGME20200323020602epcas2p2ea3273f48a5df7c8c17b3db0618c83e1@epcas2p2.samsung.com>
2020-03-23  2:06 ` Seungchul Kim
     [not found] <CGME20200320022445epcas2p40ea2f166aff45e67825b3e1a4e2308dd@epcas2p4.samsung.com>
2020-03-20  2:16 ` Seungchul Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00c001d5fe9d$c19bee40$44d3cac0$@samsung.com' \
    --to=sc377.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.