From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755974AbcJTMNj (ORCPT ); Thu, 20 Oct 2016 08:13:39 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33480 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcJTMNi (ORCPT ); Thu, 20 Oct 2016 08:13:38 -0400 Subject: Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call To: Andy Shevchenko , Greg Kroah-Hartman , Bhaktipriya Shridhar , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-2-git-send-email-insafonov@gmail.com> <1476896024.11323.506.camel@linux.intel.com> <1476896391.11323.509.camel@linux.intel.com> From: Ivan Safonov Message-ID: <00cca626-0444-1ee9-f906-ffd3ae38e79a@gmail.com> Date: Thu, 20 Oct 2016 19:16:20 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476896391.11323.509.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy, thank you for reviewing patches and tips. On 10/19/2016 11:59 PM, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: >> On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: >>> >>> netdev_alloc_skb function >>> already set dev member of pkt_copy. >> >> It might be one line. >> >> Some special references: >> functions: function() >> structs: struct my_struct >> >> P.S. Entire series lacks of cover letter. > > And couple more things: > - Use min percentage when run git format-patch to avoid inclusion non- > maintainers / non-active developers > - Adjust your commit messages to be a bit more verbose and put > explanation "why you create the patch" before "what is done in the > patch". > >> >>> >>> >>> Signed-off-by: Ivan Safonov >>> --- >>> drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c >>> b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c >>> index 34198fe..f19b203 100644 >>> --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c >>> +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c >>> @@ -123,7 +123,6 @@ static int recvbuf2recvframe(struct adapter >>> *adapt, struct sk_buff *pskb) >>> >>> pkt_copy = netdev_alloc_skb(adapt->pnetdev, >>> alloc_sz); >>> if (pkt_copy) { >>> - pkt_copy->dev = adapt->pnetdev; >>> precvframe->pkt = pkt_copy; >>> precvframe->rx_head = pkt_copy->data; >>> precvframe->rx_end = pkt_copy->data + >>> alloc_sz; >> >