From: "Dolev Raviv" <draviv@codeaurora.org>
To: 'Christoph Hellwig' <hch@infradead.org>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org,
sthumma@codeaurora.org, linux-arm-msm@vger.kernel.org,
santoshsy@gmail.com
Subject: RE: [PATCH 3/3] scsi: ufs: retry if the link-startup fails
Date: Tue, 8 Jul 2014 13:18:27 +0300 [thread overview]
Message-ID: <00d701cf9a95$f7f3ac20$e7db0460$@codeaurora.org> (raw)
In-Reply-To: <20140707103719.GA7810@infradead.org>
> Did you plan to change the arguments to ufshcd_is_device_present in a later patch?
I guess I overlooked it, thanks for bringing it to my attention.
I will resend the series without this patch.
Thanks,
Dolev
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Monday, July 07, 2014 1:37 PM
To: Dolev Raviv
Cc: James.Bottomley@HansenPartnership.com; linux-scsi@vger.kernel.org; linux-scsi-owner@vger.kernel.org; sthumma@codeaurora.org; linux-arm-msm@vger.kernel.org; santoshsy@gmail.com
Subject: Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails
This produces a compiler warning for me that looks serious:
../drivers/scsi/ufs/ufshcd.c: In function ‘ufshcd_link_startup’:
../drivers/scsi/ufs/ufshcd.c:1938:3: warning: passing argument 1 of ‘ufshcd_is_device_present’ makes integer from pointer without a cast [enabled by default]
../drivers/scsi/ufs/ufshcd.c:185:19: note: expected ‘u32’ but argument is of type ‘struct ufs_hba *’
Did you plan to change the arguments to ufshcd_is_device_present in a later patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-08 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 9:22 [PATCH 0/3] ufs driver fixes and updates Dolev Raviv
2014-07-01 9:22 ` [PATCH 1/3] scsi: ufs: read door bell register after clearing interrupt aggregation Dolev Raviv
2014-07-01 9:22 ` [PATCH 2/3] scsi: ufs: Fix sending unsupported SCSI command Dolev Raviv
2014-07-01 9:22 ` [PATCH 3/3] scsi: ufs: retry if the link-startup fails Dolev Raviv
2014-07-07 10:37 ` Christoph Hellwig
2014-07-08 10:18 ` Dolev Raviv [this message]
2014-07-08 10:35 ` 'Christoph Hellwig'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00d701cf9a95$f7f3ac20$e7db0460$@codeaurora.org' \
--to=draviv@codeaurora.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.