From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EF9C433EF for ; Wed, 8 Dec 2021 02:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237545AbhLHCEg (ORCPT ); Tue, 7 Dec 2021 21:04:36 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:35466 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232311AbhLHCEf (ORCPT ); Tue, 7 Dec 2021 21:04:35 -0500 X-UUID: f05e892a241e430e88faada1e0e9d722-20211208 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DZaORBOtJY/yncuKK0ASrYmOnUqpv3wP5VjwQJkPl2o=; b=b+UDQlVg4XGmaR/qFBZQ2UnrcsS4U9u3hEOst0+evmQLKEDBQc5+YTeybF9YdI2le6UgfGcwjLYs7HK33Fld6u8aYRUCOFNIFgZSmhdtnE7TPNSKvz15SVskae9YpUMy4K36oR8VctY7reduWByuNECn+GyfqSdZtz1YUxpIpus=; X-UUID: f05e892a241e430e88faada1e0e9d722-20211208 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 89225687; Wed, 08 Dec 2021 10:01:00 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Dec 2021 10:00:59 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 8 Dec 2021 10:00:58 +0800 Message-ID: <00e62ae7e7764296023b34395e4d109139c10325.camel@mediatek.com> Subject: Re: [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components From: Yong Wu To: houlong wei , Ezequiel Garcia , Eizan Miyamoto , "Hans Verkuil" CC: Linux Kernel Mailing List , "chunkuang.hu@kernel.org" , "wenst@chromium.org" , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , Enric Balletbo i Serra , Yongqiang Niu =?UTF-8?Q?=28=E7=89=9B=E6=B0=B8=E5=BC=BA=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , linux-arm-kernel , linux-media , "moderated list:ARM/Mediatek SoC support" Date: Wed, 8 Dec 2021 10:00:54 +0800 In-Reply-To: References: <20210825063323.3607738-1-eizan@chromium.org> <20210825163247.v7.2.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIxLTA5LTA2IGF0IDAwOjIzICswODAwLCBob3Vsb25nIHdlaSB3cm90ZToNCj4g SGkgRXplcXVpZWwsDQo+IA0KPiBUaGFuayB5b3UgZm9yIHlvdXIgYXR0ZW50aW9uIHRvIHRoaXMg c2VyaWVzIG9mIHBhdGNoZXMuIEkgYW5zd2VyDQo+IHBhcnRpYWwgb2YgeW91ciBxdWVzdGlvbnMg YmVsb3cuDQo+IFJlZ2FyZHMsDQo+IEhvdWxvbmcNCj4gDQo+IE9uIFNhdCwgMjAyMS0wOS0wNCBh dCAyMDozNCArMDgwMCwgRXplcXVpZWwgR2FyY2lhIHdyb3RlOg0KPiA+IEhpIEVpemFuLA0KPiA+ IA0KPiA+IFNvcnJ5IGZvciBzZWVpbmcgdGhpcyBzZXJpZXMgc28gbGF0ZS4NCj4gPiANCj4gPiBP biBXZWQsIDI1IEF1ZyAyMDIxIGF0IDAzOjM1LCBFaXphbiBNaXlhbW90byA8ZWl6YW5AY2hyb21p dW0ub3JnPg0KPiA+IHdyb3RlOg0KPiA+ID4gDQo+ID4gPiBCcm9hZGx5LCB0aGlzIHBhdGNoICgx KSBhZGRzIGEgZHJpdmVyIGZvciB2YXJpb3VzIE1USyBNRFANCj4gPiA+IGNvbXBvbmVudHMgdG8N Cj4gPiA+IGdvIGFsb25nc2lkZSB0aGUgbWFpbiBNVEsgTURQIGRyaXZlciwgYW5kICgyKSBob29r cyB0aGVtIGFsbA0KPiA+ID4gdG9nZXRoZXINCj4gPiA+IHVzaW5nIHRoZSBjb21wb25lbnQgZnJh bWV3b3JrLg0KPiA+ID4gDQo+ID4gPiAoMSkgVXAgdW50aWwgbm93LCB0aGUgTVRLIE1EUCBkcml2 ZXIgY29udHJvbHMgOCBkZXZpY2VzIGluIHRoZQ0KPiA+ID4gZGV2aWNlDQo+ID4gPiB0cmVlIG9u IGl0cyBvd24uIFdoZW4gcnVubmluZyB0ZXN0cyBmb3IgdGhlIGhhcmR3YXJlIHZpZGVvDQo+ID4g PiBkZWNvZGVyLA0KPiA+ID4gd2UNCj4gPiA+IGZvdW5kIHRoYXQgdGhlIGlvbW11cyBhbmQgTEFS QnMgd2VyZSBub3QgYmVpbmcgcHJvcGVybHkNCj4gPiA+IGNvbmZpZ3VyZWQuDQo+ID4gDQo+ID4g V2h5IHdlcmUgbm90IGJlaW5nIHByb3Blcmx5IGNvbmZpZ3VyZWQ/IFdoYXQgd2FzIHRoZSBwcm9i bGVtPw0KPiA+IFdoeSBub3QgZml4aW5nIHRoYXQgaW5zdGVhZD8NCj4gPiANCj4gPiBEb2VzIHRo aXMgbWVhbiB0aGUgZHJpdmVyIGlzIGN1cnJlbnRseSBicm9rZW4gYW5kIHVudXNhYmxlPw0KPiAN Cj4gVGhpcyBzZXJpZXMgb2YgcGF0Y2hlcyBhcmUgc3VwcGxlbWVudHMgdG8gYW5vdGhlciBzZXJp ZXMsIHBsZWFzZQ0KPiByZWZlcg0KPiB0byAgDQo+IA0KaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVs Lm9yZy9wcm9qZWN0L2xpbnV4LW1lZGlhdGVrL2xpc3QvP3Nlcmllcz01MTUxMjljDQo+ICwgd2hp Y2ggYWRkIGRldmljZSBsaW5rIGJldHdlZW4gdGhlIG10ay1pb21tdSBjb25zdW1lciBhbmQgdGhl IG10ay0NCj4gbGFyYiANCj4gZGV2aWNlcy4gV2l0aG91dCB0aGF0IHNlcmllcyBvZiBwYXRjaGVz LCB0aGUgbXRrLW1kcCBkcml2ZXIgY2FuIHdvcmsNCj4gd2VsbCBzbyBmYXIuDQo+IEJ1dCB3aXRo IHRoYXQgc2VyaWVzLCBpdCBzZWVtcyB0aGUgZGV2aWNlIGxpbmsgb25seSBjYW4gYmUNCj4gZXN0 YWJsaXNoZWQNCj4gZm9yIHRoZSBkZXZpY2Ugd2hpY2ggaXMgcmVnaXN0ZXJlZCBhcyBhIHBsYXRm b3JtIGRyaXZlci4gVGhhdCdzIHdoeQ0KPiBFaXphbiBhZGRzIHRoaXMgc2VyaWVzIG9mIHBhdGNo ZXMgdG8gbWFrZSBhbGwgbWRwIGNvbXBvbmVudHMgdG8gYmUNCj4gcmVnaXN0ZXJlZCBhcyBwbGF0 Zm9ybSBkcml2ZXJzLg0KDQpUaGUgbXQ4MTczIG1kcCBoYXMgc2V2ZXJhbCBkZXZpY2VzOg0KICAg bWVkaWF0ZWssbXQ4MTczLW1kcC1yZG1hLCBtZWRpYXRlayxtdDgxNzMtbWRwICANCiAgIG1lZGlh dGVrLG10ODE3My1tZHAtcnN6DQogICBtZWRpYXRlayxtdDgxNzMtbWRwLXdkbWENCiAgIG1lZGlh dGVrLG10ODE3My1tZHAtd3JvdA0KDQpFeGNlcHQgdGhlIGZpcnN0IG9uZSwgdGhlIGxhc3QgdGhy ZWUgZGV2aWNlcyBhcmUgbm90IHRoZSBzdGFuZGFyZA0KcGxhdGZvcm0gZGV2aWNlcy4gVGh1cywg dGhleSBzaG91bGQgbm90IGJlIHRoZSBpb21tdSBjb25zdW1lciBkZXZpY2VzLg0KDQpRdWVzdGlv biAxOiBUaGUgbGFzdCB0aHJlZSBkZXZpY2UgZG9uJ3Qgd29yayBhY3R1YWxseSBpbiBtdDgxNzMg Y2hyb21lLA0KcmlnaHQ/IG9yIHRoZXkgYWNjZXNzIGNvbnRpbnVvdXMgYnVmZmVycz8NCg0KUXVl c3Rpb24gMjogVGhlIElPTU1VIGRldmljZS1saW5rIHBhdGNoc2V0IGp1c3QgcmVwbGFjZXMgdGhl IHBtIHJ1bnRpbWUNCmludGVyZmFjZXMuIEl0IGRvbid0IGltcHJvdmUgdGhlIG1kcCBmbG93LCBh bHNvIHNob3VsZCBub3QgaW50cm9kdWNlDQpyZWdyZXNzaW9uLiB0aHVzLCBteSB2OCBkb24ndCBy ZWJhc2UgdGhpcyBtZHAgcGF0Y2hlcy4gRG9lcyB0aGUgaW9tbXUNCnBhdGNoc2V0IGludHJvZHVj ZSByZWdyZXNzaW9uIGZvciBtZHA/DQoNCkBFaXphbiwgQGhvdWxvbmcsIENvdWxkIHlvdSBoZWxw IGNvbmZpcm0gdGhpcz8NClRoYW5rcy4NCg0KPiANCj4gPiANCj4gPiA+IFRvDQo+ID4gPiBjb25m aWd1cmUgdGhlbSwgYSBkcml2ZXIgZm9yIGVhY2ggYmUgYWRkZWQgdG8gbXRrX21kcF9jb21wIHNv DQo+ID4gPiB0aGF0DQo+ID4gPiBtdGtfaW9tbXVfYWRkX2RldmljZSgpIGNhbiAoZXZlbnR1YWxs eSkgYmUgY2FsbGVkIGZyb20NCj4gPiA+IGRtYV9jb25maWd1cmUoKQ0KPiA+ID4gaW5zaWRlIHJl YWxseV9wcm9iZSgpLg0KPiA+ID4gDQo+ID4gPiAoMikgVGhlIGludGVncmF0aW9uIGludG8gdGhl IGNvbXBvbmVudCBmcmFtZXdvcmsgYWxsb3dzIHVzIHRvDQo+ID4gPiBkZWZlcg0KPiA+ID4gdGhl DQo+ID4gPiByZWdpc3RyYXRpb24gd2l0aCB0aGUgdjRsMiBzdWJzeXN0ZW0gdW50aWwgYWxsIHRo ZSBNRFAtcmVsYXRlZA0KPiA+ID4gZGV2aWNlcw0KPiA+ID4gaGF2ZSBiZWVuIHByb2JlZCwgc28g dGhhdCB0aGUgcmVsZXZhbnQgZGV2aWNlIG5vZGUgZG9lcyBub3QNCj4gPiA+IGJlY29tZQ0KPiA+ ID4gYXZhaWxhYmxlIHVudGlsIGluaXRpYWxpemF0aW9uIG9mIGFsbCB0aGUgY29tcG9uZW50cyBp cyBjb21wbGV0ZS4NCj4gPiA+IA0KPiA+ID4gU29tZSBub3RlcyBhYm91dCBob3cgdGhlIGNvbXBv bmVudCBmcmFtZXdvcmsgaGFzIGJlZW4gaW50ZWdyYXRlZDoNCj4gPiA+IA0KPiA+ID4gLSBUaGUg ZHJpdmVyIGZvciB0aGUgcmRtYTAgY29tcG9uZW50IHNlcnZlcyBkb3VibGUgZHV0eSBhcyB0aGUN Cj4gPiA+ICJtYXN0ZXIiDQo+ID4gPiAgIChhZ2dyZWdhdGUpIGRyaXZlciBhcyB3ZWxsIGFzIGEg Y29tcG9uZW50IGRyaXZlci4gVGhpcyBpcyBhDQo+ID4gPiBub24tDQo+ID4gPiBpZGVhbA0KPiA+ ID4gICBjb21wcm9taXNlIHVudGlsIGEgYmV0dGVyIHNvbHV0aW9uIGlzIGRldmVsb3BlZC4gVGhp cyBkZXZpY2UgaXMNCj4gPiA+ICAgZGlmZmVyZW50aWF0ZWQgZnJvbSB0aGUgcmVzdCBieSBjaGVj a2luZyBmb3IgYSAibWVkaWF0ZWssdnB1Ig0KPiA+ID4gcHJvcGVydHkNCj4gPiA+ICAgaW4gdGhl IGRldmljZSBub2RlLg0KPiA+ID4gDQo+ID4gDQo+ID4gQXMgSSBoYXZlIHN0YXRlZCBpbiBZdW5m ZWksIEkgYW0gbm90IGNvbnZpbmNlZCB5b3UgbmVlZCBhbiBhc3luYw0KPiA+IGZyYW1ld29yaw0K PiA+IGF0IGFsbC4gSXQgc2VlbXMgYWxsIHRoZXNlIGRldmljZXMgY291bGQgaGF2ZSBiZWVuIGxp bmtlZCB0b2dldGhlcg0KPiA+IGluIHRoZSBkZXZpY2UgdHJlZSwgYW5kIHRoZW4gaGF2ZSBhIG1h c3RlciBkZXZpY2UgdG8gdGllIHRoZW0uDQo+ID4gDQo+ID4gSS5lLiBzb21ldGhpbmcgbGlrZQ0K PiA+IA0KPiA+IG1kcCB7DQo+ID4gICBtZHBfcmRtYTAgew0KPiA+ICAgfQ0KPiA+ICAgbWRwX3Jz ejAgew0KPiA+ICAgfQ0KPiA+ICAgbWRwX3JzejEgew0KPiA+ICAgfQ0KPiA+IH0NCj4gPiANCj4g DQo+IFRoZSBjb21taXQgbWVzc2FnZSBvZiB0aGUgcGF0Y2ggYmVsb3cgZXhwbGFpbnMgdGhhdCAi IElmIHRoZSBtZHBfKg0KPiBub2RlcyBhcmUgdW5kZXIgYW4gbWRwIHN1Yi1ub2RlLCB0aGVpciBj b3JyZXNwb25kaW5nIHBsYXRmb3JtIGRldmljZQ0KPiBkb2VzIG5vdCBhdXRvbWF0aWNhbGx5IGdl dCBpdHMgaW9tbXUgYXNzaWduZWQgcHJvcGVybHkuIg0KPiBQbGVhc2UgcmVmZXIgdG8gDQo+IA0K aHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvc3RhYmxlL2xp bnV4LmdpdC9jb21taXQvYXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDgxNzMuZHRzaT9o PXY1LjE0LjEmaWQ9ODEyNzg4MWY3NDFkYmJmOWExZGE5ZTliYzU5MTMzODIwMTYwYjIxNw0KPiAN CltzbmlwXQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7D82C433EF for ; Wed, 8 Dec 2021 02:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i4kXSY60QPuDvo1ydkcNggCGNMbW0kRF1w33c/017lU=; b=b7cIFucj5HGJrV SDUgQs7RkEKHWF1GJVNj047gd0MIuwa4xGs5NdVdLNFq6j6eIDa7k1svyBTrE7tt56JjK7KS9OXwE rdkkYDeQ/PN3/K/PaVz9OSjV+Mz4a6AOUnwZmkub5XnsnaRj/timV7VbhZF+ipHJpzh9rHQSjuhlF mavOXyPoYbR2DIPT88lyLR145lG+14e346W9DXbOKNlcZ6tlm/KeGP3g6aD3XNBvTHLqGDS5FrTn6 ZG1FDLX/Zhn6E67YseIt5zRd1RPByZIWfZQdUneR0SWoMlrn57WXv4s/aPEUp71N0CJh+sPlR35xg M/CjzRrJHvH6Cd+t/KOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mumNa-00Aflx-3c; Wed, 08 Dec 2021 02:08:22 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mumNX-00AflP-9z; Wed, 08 Dec 2021 02:08:21 +0000 X-UUID: 02bc68f537f945ed9fc874af215177dc-20211207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DZaORBOtJY/yncuKK0ASrYmOnUqpv3wP5VjwQJkPl2o=; b=b+UDQlVg4XGmaR/qFBZQ2UnrcsS4U9u3hEOst0+evmQLKEDBQc5+YTeybF9YdI2le6UgfGcwjLYs7HK33Fld6u8aYRUCOFNIFgZSmhdtnE7TPNSKvz15SVskae9YpUMy4K36oR8VctY7reduWByuNECn+GyfqSdZtz1YUxpIpus=; X-UUID: 02bc68f537f945ed9fc874af215177dc-20211207 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 809155642; Tue, 07 Dec 2021 19:08:12 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Dec 2021 18:01:01 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Dec 2021 10:00:59 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 8 Dec 2021 10:00:58 +0800 Message-ID: <00e62ae7e7764296023b34395e4d109139c10325.camel@mediatek.com> Subject: Re: [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components From: Yong Wu To: houlong wei , Ezequiel Garcia , Eizan Miyamoto , "Hans Verkuil" CC: Linux Kernel Mailing List , "chunkuang.hu@kernel.org" , "wenst@chromium.org" , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , Enric Balletbo i Serra , Yongqiang Niu =?UTF-8?Q?=28=E7=89=9B=E6=B0=B8=E5=BC=BA=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , linux-arm-kernel , linux-media , "moderated list:ARM/Mediatek SoC support" Date: Wed, 8 Dec 2021 10:00:54 +0800 In-Reply-To: References: <20210825063323.3607738-1-eizan@chromium.org> <20210825163247.v7.2.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_180819_390124_698E787C X-CRM114-Status: GOOD ( 39.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2021-09-06 at 00:23 +0800, houlong wei wrote: > Hi Ezequiel, > > Thank you for your attention to this series of patches. I answer > partial of your questions below. > Regards, > Houlong > > On Sat, 2021-09-04 at 20:34 +0800, Ezequiel Garcia wrote: > > Hi Eizan, > > > > Sorry for seeing this series so late. > > > > On Wed, 25 Aug 2021 at 03:35, Eizan Miyamoto > > wrote: > > > > > > Broadly, this patch (1) adds a driver for various MTK MDP > > > components to > > > go alongside the main MTK MDP driver, and (2) hooks them all > > > together > > > using the component framework. > > > > > > (1) Up until now, the MTK MDP driver controls 8 devices in the > > > device > > > tree on its own. When running tests for the hardware video > > > decoder, > > > we > > > found that the iommus and LARBs were not being properly > > > configured. > > > > Why were not being properly configured? What was the problem? > > Why not fixing that instead? > > > > Does this mean the driver is currently broken and unusable? > > This series of patches are supplements to another series, please > refer > to > https://patchwork.kernel.org/project/linux-mediatek/list/?series=515129c > , which add device link between the mtk-iommu consumer and the mtk- > larb > devices. Without that series of patches, the mtk-mdp driver can work > well so far. > But with that series, it seems the device link only can be > established > for the device which is registered as a platform driver. That's why > Eizan adds this series of patches to make all mdp components to be > registered as platform drivers. The mt8173 mdp has several devices: mediatek,mt8173-mdp-rdma, mediatek,mt8173-mdp mediatek,mt8173-mdp-rsz mediatek,mt8173-mdp-wdma mediatek,mt8173-mdp-wrot Except the first one, the last three devices are not the standard platform devices. Thus, they should not be the iommu consumer devices. Question 1: The last three device don't work actually in mt8173 chrome, right? or they access continuous buffers? Question 2: The IOMMU device-link patchset just replaces the pm runtime interfaces. It don't improve the mdp flow, also should not introduce regression. thus, my v8 don't rebase this mdp patches. Does the iommu patchset introduce regression for mdp? @Eizan, @houlong, Could you help confirm this? Thanks. > > > > > > To > > > configure them, a driver for each be added to mtk_mdp_comp so > > > that > > > mtk_iommu_add_device() can (eventually) be called from > > > dma_configure() > > > inside really_probe(). > > > > > > (2) The integration into the component framework allows us to > > > defer > > > the > > > registration with the v4l2 subsystem until all the MDP-related > > > devices > > > have been probed, so that the relevant device node does not > > > become > > > available until initialization of all the components is complete. > > > > > > Some notes about how the component framework has been integrated: > > > > > > - The driver for the rdma0 component serves double duty as the > > > "master" > > > (aggregate) driver as well as a component driver. This is a > > > non- > > > ideal > > > compromise until a better solution is developed. This device is > > > differentiated from the rest by checking for a "mediatek,vpu" > > > property > > > in the device node. > > > > > > > As I have stated in Yunfei, I am not convinced you need an async > > framework > > at all. It seems all these devices could have been linked together > > in the device tree, and then have a master device to tie them. > > > > I.e. something like > > > > mdp { > > mdp_rdma0 { > > } > > mdp_rsz0 { > > } > > mdp_rsz1 { > > } > > } > > > > The commit message of the patch below explains that " If the mdp_* > nodes are under an mdp sub-node, their corresponding platform device > does not automatically get its iommu assigned properly." > Please refer to > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.14.1&id=8127881f741dbbf9a1da9e9bc59133820160b217 > [snip] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C4F0C433F5 for ; Wed, 8 Dec 2021 02:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3wwnwQVsbcGSz7vme0KRLAn1XGIZvSg4m1S5QHmddYQ=; b=oHyIbuHNvjOalV fIUA6gGrNj9O4QUQeJdYcvfXYoXCehe7wjMGDesOBjgxOfGrbQ+j0JkX2sUJdj/uo5cX0+mZqu04y gpogjhw/HUwuUz3WGC1VSxLHk1XJCAeh08d38YDLeBgc8gPGkK0rwVy0ffiLDQH09zVR6EnkCCJFk ROqxxruyyJ4veImr4QIUD0ECuWfqLnwRoU/RjT8hPS44oT+lSG06CzYGXsOox+ndZWUV5VNUIkDoJ 1nhubMVbD6Mw35VpxgUBwyOkduCC6mTEPTWrzcvE8PeHQQu2PUWIAVhPIjSsS1jaBOPRLJbzqqIyY BR38icrSOGiKcS51ESaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mumNb-00Afm3-Rx; Wed, 08 Dec 2021 02:08:24 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mumNX-00AflP-9z; Wed, 08 Dec 2021 02:08:21 +0000 X-UUID: 02bc68f537f945ed9fc874af215177dc-20211207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DZaORBOtJY/yncuKK0ASrYmOnUqpv3wP5VjwQJkPl2o=; b=b+UDQlVg4XGmaR/qFBZQ2UnrcsS4U9u3hEOst0+evmQLKEDBQc5+YTeybF9YdI2le6UgfGcwjLYs7HK33Fld6u8aYRUCOFNIFgZSmhdtnE7TPNSKvz15SVskae9YpUMy4K36oR8VctY7reduWByuNECn+GyfqSdZtz1YUxpIpus=; X-UUID: 02bc68f537f945ed9fc874af215177dc-20211207 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 809155642; Tue, 07 Dec 2021 19:08:12 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Dec 2021 18:01:01 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Dec 2021 10:00:59 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 8 Dec 2021 10:00:58 +0800 Message-ID: <00e62ae7e7764296023b34395e4d109139c10325.camel@mediatek.com> Subject: Re: [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components From: Yong Wu To: houlong wei , Ezequiel Garcia , Eizan Miyamoto , "Hans Verkuil" CC: Linux Kernel Mailing List , "chunkuang.hu@kernel.org" , "wenst@chromium.org" , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , Enric Balletbo i Serra , Yongqiang Niu =?UTF-8?Q?=28=E7=89=9B=E6=B0=B8=E5=BC=BA=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , linux-arm-kernel , linux-media , "moderated list:ARM/Mediatek SoC support" Date: Wed, 8 Dec 2021 10:00:54 +0800 In-Reply-To: References: <20210825063323.3607738-1-eizan@chromium.org> <20210825163247.v7.2.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_180819_390124_698E787C X-CRM114-Status: GOOD ( 39.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2021-09-06 at 00:23 +0800, houlong wei wrote: > Hi Ezequiel, > > Thank you for your attention to this series of patches. I answer > partial of your questions below. > Regards, > Houlong > > On Sat, 2021-09-04 at 20:34 +0800, Ezequiel Garcia wrote: > > Hi Eizan, > > > > Sorry for seeing this series so late. > > > > On Wed, 25 Aug 2021 at 03:35, Eizan Miyamoto > > wrote: > > > > > > Broadly, this patch (1) adds a driver for various MTK MDP > > > components to > > > go alongside the main MTK MDP driver, and (2) hooks them all > > > together > > > using the component framework. > > > > > > (1) Up until now, the MTK MDP driver controls 8 devices in the > > > device > > > tree on its own. When running tests for the hardware video > > > decoder, > > > we > > > found that the iommus and LARBs were not being properly > > > configured. > > > > Why were not being properly configured? What was the problem? > > Why not fixing that instead? > > > > Does this mean the driver is currently broken and unusable? > > This series of patches are supplements to another series, please > refer > to > https://patchwork.kernel.org/project/linux-mediatek/list/?series=515129c > , which add device link between the mtk-iommu consumer and the mtk- > larb > devices. Without that series of patches, the mtk-mdp driver can work > well so far. > But with that series, it seems the device link only can be > established > for the device which is registered as a platform driver. That's why > Eizan adds this series of patches to make all mdp components to be > registered as platform drivers. The mt8173 mdp has several devices: mediatek,mt8173-mdp-rdma, mediatek,mt8173-mdp mediatek,mt8173-mdp-rsz mediatek,mt8173-mdp-wdma mediatek,mt8173-mdp-wrot Except the first one, the last three devices are not the standard platform devices. Thus, they should not be the iommu consumer devices. Question 1: The last three device don't work actually in mt8173 chrome, right? or they access continuous buffers? Question 2: The IOMMU device-link patchset just replaces the pm runtime interfaces. It don't improve the mdp flow, also should not introduce regression. thus, my v8 don't rebase this mdp patches. Does the iommu patchset introduce regression for mdp? @Eizan, @houlong, Could you help confirm this? Thanks. > > > > > > To > > > configure them, a driver for each be added to mtk_mdp_comp so > > > that > > > mtk_iommu_add_device() can (eventually) be called from > > > dma_configure() > > > inside really_probe(). > > > > > > (2) The integration into the component framework allows us to > > > defer > > > the > > > registration with the v4l2 subsystem until all the MDP-related > > > devices > > > have been probed, so that the relevant device node does not > > > become > > > available until initialization of all the components is complete. > > > > > > Some notes about how the component framework has been integrated: > > > > > > - The driver for the rdma0 component serves double duty as the > > > "master" > > > (aggregate) driver as well as a component driver. This is a > > > non- > > > ideal > > > compromise until a better solution is developed. This device is > > > differentiated from the rest by checking for a "mediatek,vpu" > > > property > > > in the device node. > > > > > > > As I have stated in Yunfei, I am not convinced you need an async > > framework > > at all. It seems all these devices could have been linked together > > in the device tree, and then have a master device to tie them. > > > > I.e. something like > > > > mdp { > > mdp_rdma0 { > > } > > mdp_rsz0 { > > } > > mdp_rsz1 { > > } > > } > > > > The commit message of the patch below explains that " If the mdp_* > nodes are under an mdp sub-node, their corresponding platform device > does not automatically get its iommu assigned properly." > Please refer to > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.14.1&id=8127881f741dbbf9a1da9e9bc59133820160b217 > [snip] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel