From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8D3C433E0 for ; Tue, 26 May 2020 15:36:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA205206D5 for ; Tue, 26 May 2020 15:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XzyrIudf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA205206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C0871752; Tue, 26 May 2020 17:36:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C0871752 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1590507414; bh=13yozKs4fkr1khrYCFz/6acH8xiHLt4YNeX3MoEbEv4=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XzyrIudfZ0X/Bpyzk+KGoy080YW0DAwF74GWy4SDu8kohuUpZTkdaaih3Fjw6n7TG /slR3EkJ7+KCFI0NIBBw5isXyaDX2+cuFYsuVLPTXCtJplaHej/g82hQTkPZc57mlw JEapMCeWqYKctP0a0ds/9a92Xyg8xc77XY+AhSa4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CBC13F8026A; Tue, 26 May 2020 17:35:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87BFFF8015C; Tue, 26 May 2020 17:35:09 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27C99F80146 for ; Tue, 26 May 2020 17:35:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27C99F80146 IronPort-SDR: JmMRg6i+/fDz7cHRBOgYycD+NXAfiob/j7Bx5ypTbvszQTKgTiIVYqFBBCW6NxNqqTDO0eT80m GnM6XO5jeSZw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2020 08:34:59 -0700 IronPort-SDR: EpfK93zYIqkHW+IzTlQzYrYr6z2Rj+/eStk4ucL7m3V39F2ZQ4ljs2gkAPB6qIKyXHL3UWjXK2 QrgdTHhfCxUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,437,1583222400"; d="scan'208";a="291234620" Received: from unknown (HELO [10.254.102.121]) ([10.254.102.121]) by fmsmga004.fm.intel.com with ESMTP; 26 May 2020 08:34:58 -0700 Subject: Re: [PATCH v2 0/2] ASoC topology header parsing refinement To: Cezary Rojewski , Keyon Jie , alsa-devel@alsa-project.org References: <20200521074847.71406-1-yang.jie@linux.intel.com> <32df1cf8-8a57-7fc8-c694-6ddcc03fffca@intel.com> From: Pierre-Louis Bossart Message-ID: <00e9e16f-87be-5585-3751-d605a2ceb326@linux.intel.com> Date: Tue, 26 May 2020 08:29:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <32df1cf8-8a57-7fc8-c694-6ddcc03fffca@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: tiwai@suse.de, broonie@kernel.org, ranjani.sridharan@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/26/20 7:40 AM, Cezary Rojewski wrote: > On 2020-05-21 9:48 AM, Keyon Jie wrote: >> This small series is to optimize the header logging during the topology >> parsing. This is verified work fine on both SOF and SST drivers >> (bxt_rt298 with dfw_sst.bin). >> >> Change History: >> v2: >> - Change the internal used array to be 'static' to fix the issue >>    reported by: kbuild test robot >> - Add testing coverage including Intel SST driver also. >> >> v1: >> - Initial version. >> >> Keyon Jie (2): >>    ASoC: topology: refine and log the header in the correct pass >>    ASoC: topology: remove the redundant pass checks >> >>   sound/soc/soc-topology.c | 99 ++++++++++++++++++---------------------- >>   1 file changed, 44 insertions(+), 55 deletions(-) >> > > No regression after applying these and running through SST CI on cAVS > 1.5+ (GLK) and 1.8 (CNL). Can the tests be run on SKL/KBL? That's where the cAVS driver will be used and where this patchset will have an impact. Thanks! > Given some comments on 1/2 though, believe it could be simplified. > > Czarek