From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C3ECC433F5 for ; Sun, 2 Oct 2022 01:14:55 +0000 (UTC) Received: from localhost ([::1]:35652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oenZG-0000mj-Op for qemu-devel@archiver.kernel.org; Sat, 01 Oct 2022 21:14:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oenYS-00005V-RH for qemu-devel@nongnu.org; Sat, 01 Oct 2022 21:14:04 -0400 Received: from prt-mail.chinatelecom.cn ([42.123.76.226]:58000 helo=chinatelecom.cn) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oenYQ-0000Zr-Nb for qemu-devel@nongnu.org; Sat, 01 Oct 2022 21:14:04 -0400 HMM_SOURCE_IP: 172.18.0.218:54490.756208713 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-118.116.19.226 (unknown [172.18.0.218]) by chinatelecom.cn (HERMES) with SMTP id 60D0D280169; Sun, 2 Oct 2022 09:13:45 +0800 (CST) X-189-SAVE-TO-SEND: huangy81@chinatelecom.cn Received: from ([118.116.19.226]) by app0025 with ESMTP id 956ab914770c421cb2207e0ab1c302eb for armbru@redhat.com; Sun, 02 Oct 2022 09:13:48 CST X-Transaction-ID: 956ab914770c421cb2207e0ab1c302eb X-Real-From: huangy81@chinatelecom.cn X-Receive-IP: 118.116.19.226 X-MEDUSA-Status: 0 Message-ID: <00eac029-89b0-04ae-f591-c91ac5baba51@chinatelecom.cn> Date: Sun, 2 Oct 2022 09:13:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v1 5/8] migration: Export dirty-limit time info To: Markus Armbruster Cc: qemu-devel , Peter Xu , Juan Quintela , "Dr. David Alan Gilbert" , Eric Blake , Thomas Huth , Laurent Vivier , Paolo Bonzini , "Daniel P. Berrange" References: <5ca0b4ae2aa787c1547d798521ab0e67867437a8.1662052189.git.huangy81@chinatelecom.cn> <87o7uvjszm.fsf@pond.sub.org> From: Hyman Huang In-Reply-To: <87o7uvjszm.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=42.123.76.226; envelope-from=huangy81@chinatelecom.cn; helo=chinatelecom.cn X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.743, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/10/2 2:31, Markus Armbruster 写道: > huangy81@chinatelecom.cn writes: > >> From: Hyman Huang(黄勇) >> >> Export dirty limit throttle time and estimated ring full >> time, through which we can observe the process of dirty >> limit during live migration. >> >> Signed-off-by: Hyman Huang(黄勇) > > [...] > >> diff --git a/qapi/migration.json b/qapi/migration.json >> index bc4bc96..c263d54 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -242,6 +242,12 @@ >> # Present and non-empty when migration is blocked. >> # (since 6.0) >> # >> +# @dirty-limit-throttle-us-per-full: Throttle time (us) during the period of >> +# dirty ring full (since 7.0) >> +# >> +# @dirty-limit-us-ring-full: Estimated periodic time (us) of dirty ring full. >> +# (since 7.0) >> +# > > Can you explain what is measured here a bit more verbosely? The two fields of migration info aims to export dirty-limit throttle time so that upper apps can check out the process of live migration, like 'cpu-throttle-percentage'. The commit "tests: Add migration dirty-limit capability test" make use of the 'dirty-limit-throttle-us-per-full' to checkout if dirty-limit has started, the commit "tests/migration: Introduce dirty-limit into guestperf" introduce the two field so guestperf tools also show the process of dirty-limit migration. And i also use qmp_query_migrate to observe the migration by checkout these two fields. I'm not sure if above explantation is what you want exactly, please be free to start any discussion about this features. Thank Markus. Yong > >> # Since: 0.14 >> ## >> { 'struct': 'MigrationInfo', >> @@ -259,7 +265,9 @@ >> '*postcopy-blocktime' : 'uint32', >> '*postcopy-vcpu-blocktime': ['uint32'], >> '*compression': 'CompressionStats', >> - '*socket-address': ['SocketAddress'] } } >> + '*socket-address': ['SocketAddress'], >> + '*dirty-limit-throttle-us-per-full': 'int64', >> + '*dirty-limit-us-ring-full': 'int64'} } >> >> ## >> # @query-migrate: > > [...] > -- Best regard Hyman Huang(黄勇)