From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B1FC433EF for ; Tue, 17 May 2022 14:05:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245740AbiEQOFY (ORCPT ); Tue, 17 May 2022 10:05:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348446AbiEQOFT (ORCPT ); Tue, 17 May 2022 10:05:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 931704D603; Tue, 17 May 2022 07:05:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29B64B818EC; Tue, 17 May 2022 14:05:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E541C385B8; Tue, 17 May 2022 14:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652796304; bh=GudX6koMKPd3WgZ5qgsXK2Xg18G4EDiE+FysY70LTi0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dbQhGv2YdItufG4Za9YLbDOenBhNHSNRPsxL3LsDfZeJJraMhxtnsj5w+GCOQIchy mbT7RFit/M5XFAP/O717QdsOTVn/cSq/B1unj5OWStMFyLOs2XlRe5xfDmwY7In4rU rshHWtzcO/FhTFL9SnN+KQd+vdI30GuseXGyCLm0Ba3fMMPueK+Y/GBSgMfdHZ1XDX iavatjJmx1hflB4L9zNU0l1Zuj5BXTYIehWE1en/c4hOYUeu64G7Eu42elhISPgG47 xQ+BnO7alXzdg/qdWYFy6XIcqFyFyKG8wE6jqqjTZZTgYqI8kIp47xRHYh2xz12XJ3 MZsbKImO5x5TA== Message-ID: <00f05f62-7bf5-0a57-d07a-2e068253b9e6@kernel.org> Date: Tue, 17 May 2022 16:04:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 16/20] media: s5p-mfc: Fix to handle reference queue during finishing Content-Language: en-US To: Smitha T Murthy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, linux-fsd@tesla.com References: <20220517125548.14746-1-smitha.t@samsung.com> <20220517125548.14746-17-smitha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220517125548.14746-17-smitha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/2022 14:55, Smitha T Murthy wrote: > On receiving last buffer driver puts MFC to > MFCINST_FINISHING state which in turn skips > transferring of frame from SRC to REF queue. > This causes driver to stop MFC encoding and > last frame is lost. What type of wrapping is it exactly? https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > This patch guarantees safe handling of frames > during MFCINST_FINISHING and correct clearing > of workbit to avoid early stopping of encoding. > This looks like a bugfix so: 1. Send it separately please. 2. Add Fixes tag. 3. Add Cc stable tag. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D54C433EF for ; Tue, 17 May 2022 14:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YOBP39E96A7UOqjwqsuIPsjR1iR7TRL3T/X/BSSmwE=; b=uVasbU36FNmj+L KpPlLVpUliOWVsieswNdYymvWcWufT3GnuO14w1ItxZDawnljx0MEYCv6ZCYbilJWSxWhih+X6Y61 UTI+56CNKKKWVpUJDCiresWemXkUvDjEwmWNXC3ZzlnhNbxrMytAcvLk2XRbOAjKeKD7a3p7HXLQT zcRRIdnJfexHit5KlfPjlwy9o1+MFdIZEq5XbOFoIgAOYK0VrMvmQNT6yEtxQutIgLxrCrCNuJ4O0 gCuultkBXZAd/oWXeyYGsPpdSLR36RPJ/W0aLY2Cczz7010gCmk5qcqoKjG8UUFm9ZTS2w3A8ObfA bUBAlzU4mNNF48FQezxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqxt7-00EDnj-1U; Tue, 17 May 2022 14:09:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqxow-00EBmB-Sl for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 14:05:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 643A3615A4; Tue, 17 May 2022 14:05:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E541C385B8; Tue, 17 May 2022 14:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652796304; bh=GudX6koMKPd3WgZ5qgsXK2Xg18G4EDiE+FysY70LTi0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dbQhGv2YdItufG4Za9YLbDOenBhNHSNRPsxL3LsDfZeJJraMhxtnsj5w+GCOQIchy mbT7RFit/M5XFAP/O717QdsOTVn/cSq/B1unj5OWStMFyLOs2XlRe5xfDmwY7In4rU rshHWtzcO/FhTFL9SnN+KQd+vdI30GuseXGyCLm0Ba3fMMPueK+Y/GBSgMfdHZ1XDX iavatjJmx1hflB4L9zNU0l1Zuj5BXTYIehWE1en/c4hOYUeu64G7Eu42elhISPgG47 xQ+BnO7alXzdg/qdWYFy6XIcqFyFyKG8wE6jqqjTZZTgYqI8kIp47xRHYh2xz12XJ3 MZsbKImO5x5TA== Message-ID: <00f05f62-7bf5-0a57-d07a-2e068253b9e6@kernel.org> Date: Tue, 17 May 2022 16:04:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 16/20] media: s5p-mfc: Fix to handle reference queue during finishing Content-Language: en-US To: Smitha T Murthy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, linux-fsd@tesla.com References: <20220517125548.14746-1-smitha.t@samsung.com> <20220517125548.14746-17-smitha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220517125548.14746-17-smitha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_070507_035193_6D53551B X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2022 14:55, Smitha T Murthy wrote: > On receiving last buffer driver puts MFC to > MFCINST_FINISHING state which in turn skips > transferring of frame from SRC to REF queue. > This causes driver to stop MFC encoding and > last frame is lost. What type of wrapping is it exactly? https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > This patch guarantees safe handling of frames > during MFCINST_FINISHING and correct clearing > of workbit to avoid early stopping of encoding. > This looks like a bugfix so: 1. Send it separately please. 2. Add Fixes tag. 3. Add Cc stable tag. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel